Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-23 Thread Valentin Kulichenko
Dmitry, Thanks for pointing this out. Fixed in master and 2.6. -Val On Sat, Jun 23, 2018 at 10:49 AM Dmitriy Govorukhin < dmitriy.govoruk...@gmail.com> wrote: > Valentin, > > Seems that these changes have classes without license head. TC link >

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-23 Thread Dmitriy Govorukhin
Valentin, Seems that these changes have classes without license head. TC link

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
Great, thanks! As always, happy to contribute! Thanks, Amir On Fri, Jun 22, 2018 at 7:32 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Amir, > > I merged you change to master and 2.6. Thanks! > > -Val > > On Fri, Jun 22, 2018 at 4:21 PM Amir Akhmedov > wrote: > >> Val, >> I

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Valentin Kulichenko
Amir, I merged you change to master and 2.6. Thanks! -Val On Fri, Jun 22, 2018 at 4:21 PM Amir Akhmedov wrote: > Val, > I replied to it already :) > > Thanks, > Amir > > > On Fri, Jun 22, 2018 at 7:20 PM Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > >> Amir, >> >> Thanks for

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
Val, I replied to it already :) Thanks, Amir On Fri, Jun 22, 2018 at 7:20 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Amir, > > Thanks for quick reaction. I added a follow up question in the ticket. > > -Val > > On Fri, Jun 22, 2018 at 3:48 PM Amir Akhmedov > wrote: > >>

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Valentin Kulichenko
Amir, Thanks for quick reaction. I added a follow up question in the ticket. -Val On Fri, Jun 22, 2018 at 3:48 PM Amir Akhmedov wrote: > Hi Val, > Thanks for your comments. I replied in the ticket with my vision of the > issue and how I tried to solve it. Please check it and let me know. > >

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Amir Akhmedov
Hi Val, Thanks for your comments. I replied in the ticket with my vision of the issue and how I tried to solve it. Please check it and let me know. Thanks, Amir On Fri, Jun 22, 2018 at 5:42 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Hi Amir, > > I reviewed the changes and

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Valentin Kulichenko
Hi Amir, I reviewed the changes and I'm not sure I understood how they fix they issue. I left more detailed comment in the ticket, can you please clarify? -Val On Fri, Jun 22, 2018 at 9:53 AM Dmitry Pavlov wrote: > Hi Amir, > > let me say sincere thank you for continuing to contribute. > >

Re: Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-22 Thread Dmitry Pavlov
Hi Amir, let me say sincere thank you for continuing to contribute. Bumping up this thread. Igniters, who has an expertise here? вс, 17 июн. 2018 г. в 17:59, Amir Akhmedov : > Hi All, > Can you please review my changes for IGNITE-8740. > > PR: https://github.com/apache/ignite/pull/4208 > TC:

Review request for IGNITE-8740: Support reuse of already initialized Ignite in IgniteSpringBean

2018-06-17 Thread Amir Akhmedov
Hi All, Can you please review my changes for IGNITE-8740. PR: https://github.com/apache/ignite/pull/4208 TC: https://ci.ignite.apache.org/viewLog.html?buildId=1397283=buildResultsDiv=IgniteTests24Java8_RunAll Thanks, Amir