Re: Should we annotate @CacheLocalStore as @Depricated?

2018-02-13 Thread Vyacheslav Daradur
Valentin, thank you for replying. The task [1][2] is ready for review. Please have a look. [1] https://issues.apache.org/jira/browse/IGNITE-5097 [2] https://github.com/apache/ignite/pull/3517/files On Tue, Feb 13, 2018 at 9:23 PM, Valentin Kulichenko wrote: >

Re: Should we annotate @CacheLocalStore as @Depricated?

2018-02-13 Thread Valentin Kulichenko
Vyacheslav, These are test classes, there is not reason to put deprecation on them. We need to deprecate anything that is part of public API (in this case I believe it's only this annotation, nothing else). -Val On Tue, Feb 13, 2018 at 7:09 AM, Vyacheslav Daradur wrote: >

Re: Should we annotate @CacheLocalStore as @Depricated?

2018-01-30 Thread Anton Vinogradov
+1 On Tue, Jan 30, 2018 at 9:02 AM, Yakov Zhdanov wrote: > +1 for deprecation > > > > --Yakov > > 2018-01-30 1:06 GMT+03:00 Valentin Kulichenko < > valentin.kuliche...@gmail.com > >: > > > +1 > > > > On Mon, Jan 29, 2018 at 8:31 AM, Andrey Mashenkov < > >

Re: Should we annotate @CacheLocalStore as @Depricated?

2018-01-29 Thread Yakov Zhdanov
+1 for deprecation --Yakov 2018-01-30 1:06 GMT+03:00 Valentin Kulichenko : > +1 > > On Mon, Jan 29, 2018 at 8:31 AM, Andrey Mashenkov < > andrey.mashen...@gmail.com> wrote: > > > Vyacheslav, > > > > +1 for dropping @CacheLocalStore. > > Ignite have no support

Re: Should we annotate @CacheLocalStore as @Depricated?

2018-01-29 Thread Valentin Kulichenko
+1 On Mon, Jan 29, 2018 at 8:31 AM, Andrey Mashenkov < andrey.mashen...@gmail.com> wrote: > Vyacheslav, > > +1 for dropping @CacheLocalStore. > Ignite have no support 2-phase commit for store and public API provides no > methods to users can easily implement it by themselves. > > > > > On Mon,

Re: Should we annotate @CacheLocalStore as @Depricated?

2018-01-29 Thread Andrey Mashenkov
Vyacheslav, +1 for dropping @CacheLocalStore. Ignite have no support 2-phase commit for store and public API provides no methods to users can easily implement it by themselves. On Mon, Jan 29, 2018 at 7:11 PM, Vyacheslav Daradur wrote: > Hi Igniters, > > I've worked

Should we annotate @CacheLocalStore as @Depricated?

2018-01-29 Thread Vyacheslav Daradur
Hi Igniters, I've worked with Apache Ignite 3rd Party Persistent Storage tools recently. I found that use of CacheLocalStore annotation has hidden issues, for example: * rebalancing issues [1] * possible data consistency issues [1] * handling of CacheLocalStore on clients nodes [2] Valentin K.