Re: Unexpected behavior of DiscoveryCustomMessage acks

2017-02-05 Thread Yakov Zhdanov
Alex, this will require some more coding. The difference between nodes and custom messages is that node can easily be identified by ID, but messages now do not have such strong IDs and is pretty hard to compare them in general case. However, this is, of course, possible. --Yakov 2017-02-03 19:32

Re: Unexpected behavior of DiscoveryCustomMessage acks

2017-02-03 Thread Alexey Goncharuk
I think we should have duplicate filtering logic in discovery manager. As far as I remember, we wanted custom events to be consistent with other discovery events and we rely on the fact that node joined and node left event won't be received twice. 2017-02-03 14:40 GMT+03:00 Sergey Chugunov

Re: Unexpected behavior of DiscoveryCustomMessage acks

2017-02-03 Thread Sergey Chugunov
Yakov, Thanks for clean explanation, also I found exactly that logic in RingMessageWorker code. But I strongly believe that this behavior should have been documented in *DiscoveryCustomMessage* interface (I think it is the best place for this). Messaging managers like discovery manager must

Unexpected behavior of DiscoveryCustomMessage acks

2017-02-02 Thread Sergey Chugunov
Hello folks, Working on IGNITE-4302 I developed a protocol for delivering metadata updates to all nodes in cluster. This protocol relies on a guarantee of *DiscoveryCustomMessage* that each message is delivered to *CustomEventListener* exactly