Re: method arguments code style

;: > >> Hi, Igniters! >> >> After the completion of publishing abbr-plugin [1][2] we will be able >> to automate checking of method arguments code style. >> >> It will be easy to check rules approved by the community during writing >> code. >> >> [

[jira] [Created] (IGNITE-8512) Abbr-plugin: Add check of method arguments code style

Vyacheslav Daradur created IGNITE-8512: -- Summary: Abbr-plugin: Add check of method arguments code style Key: IGNITE-8512 URL: https://issues.apache.org/jira/browse/IGNITE-8512 Project: Ignite

Re: method arguments code style

adu...@gmail.com>: > Hi, Igniters! > > After the completion of publishing abbr-plugin [1][2] we will be able > to automate checking of method arguments code style. > > It will be easy to check rules approved by the community during writing > code. > > [1] https://issues.apache

Re: method arguments code style

lugin [1][2] we will be able > to automate checking of method arguments code style. > > It will be easy to check rules approved by the community during writing > code. > > [1] https://issues.apache.org/jira/browse/IGNITE-5698 > [2] > http://apache-ignite-developers.2346864

Re: method arguments code style

Hi, Igniters! After the completion of publishing abbr-plugin [1][2] we will be able to automate checking of method arguments code style. It will be easy to check rules approved by the community during writing code. [1] https://issues.apache.org/jira/browse/IGNITE-5698 [2] http://apache-ignite

Re: method arguments code style

Folks, I've messed with another topic, where Vladimir was going to update review check-list. Here I've updated Coding Guidelines: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-MethodArguments Please review changes, so we can consider it is final.

Re: method arguments code style

I thought that Vladimir will update. By the way, Denis M, I propose to grant access to the wiki to Dmitry G. WDYT? вт, 8 мая 2018 г. в 19:28, Dmitriy Govorukhin : > Dmitriy, > > Сould you please update code style wiki page in accordance with the > results of the

Re: method arguments code style

Dmitriy, Сould you please update code style wiki page in accordance with the results of the discussion? On May 7 2018, at 11:00 am, Vladimir Ozerov wrote: > > Dmitry, > Agree, mixed style when some arguments share the same line and others don't > looks very bad. My

Re: method arguments code style

Dmitry, Agree, mixed style when some arguments share the same line and others don't looks very bad. My proposal was to allow two styles - first when all arguments are on the same line splitted by 120 char limit, second when all every arguments is on a separate line. Mixed style should be

Re: method arguments code style

Vladimir, My eyes cry when I see this public double getCost(Session ses, int[] masks, TableFilter[] filters, int filter, SortOrder sortOrder, HashSet cols) { return SpatialTreeIndex.getCostRangeIndex(masks,table.getRowCountApproximation(), columns) / 10; } Why did arguments split into

Re: method arguments code style

My opinion is that we should allow both styles and not enforce any of them. I hardly can say that this public double getCost( Session ses, int[] masks, TableFilter[] filters, int filter, SortOrder sortOrder, HashSet cols ) { return

Re: method arguments code style

Alexey, +1. I personally also follow this style. On Thu, May 3, 2018 at 12:45 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Actually, I've been following the suggested code style for quite a while. > I'm ok to add this to coding guidelines, however, I think we should allow > the

Re: method arguments code style

Actually, I've been following the suggested code style for quite a while. I'm ok to add this to coding guidelines, however, I think we should allow the old style when the method signature (without throws clause) fits the line. Thoughts? 2018-05-03 12:09 GMT+03:00 Dmitry Pavlov

Re: method arguments code style

Hi Dmitriy, I like your proposal, so +1 from me. I think it would make code more readable and easy to understand. Sincerely, Dmitriy Pavlov чт, 3 мая 2018 г. в 11:31, Dmitriy Govorukhin : > Hi folks, > > I read >

method arguments code style

Hi folks, I read https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines, but did not find anything about code style for method arguments. In many places in the code, I see different code style, this creates difficulties for reading. It seems to me an example below is rather