Re: stopAllGrids() used by default and further steps

2018-05-14 Thread Nikolay Izhikov
Yes. В Пн, 14/05/2018 в 20:48 +0300, Dmitry Pavlov пишет: > Hi Nikolay, > > Would you have a minute to finalize this review? > > Sincerely, > Dmitriy Pavlov > > пт, 4 мая 2018 г. в 16:05, Maxim Muzafarov : > > Dmitry, > > > > Task of migration to JUnit 4/5 sounds very

Re: stopAllGrids() used by default and further steps

2018-05-14 Thread Dmitry Pavlov
Hi Nikolay, Would you have a minute to finalize this review? Sincerely, Dmitriy Pavlov пт, 4 мая 2018 г. в 16:05, Maxim Muzafarov : > Dmitry, > > Task of migration to JUnit 4/5 sounds very interesting for me, but I'm not > sure that I will have time for it in the next few

Re: stopAllGrids() used by default and further steps

2018-05-04 Thread Maxim Muzafarov
Dmitry, Task of migration to JUnit 4/5 sounds very interesting for me, but I'm not sure that I will have time for it in the next few weeks. Anyway let's create new task to it e.g. "providing design and analisys for migration to JUnit 4/5". I'll try to help with it! Test cases

Re: stopAllGrids() used by default and further steps

2018-05-04 Thread Dmitry Pavlov
Hi Maxim, I think next step can be creation of Junit4/5 IgniteAbstractTest and/or IgniteTestRunner. Would you like to contribute this prototype? Regarding TC run there is a number of suspicious tests (e.g. IgnitePdsNativeIoTestSuite2:

stopAllGrids() used by default and further steps

2018-05-04 Thread Maxim Muzafarov
Igniters, Recenly, we've pached Ingite testing framework to stop all started instances after all test-cases completion by default. Details of impelemtaion can be viewed here [1]. This change leads us to a lot of boilerplate code. 1) I've created issue [2] and prepared PR [3] which removes all