Re: unused or only used in tests methonds

2018-06-25 Thread Dmitriy Govorukhin
Igniters, If no one objects, then I delete these methods in next refactoring task. On Fri, Jun 15, 2018 at 6:38 PM Alexey Goncharuk wrote: > I have no objections to remove these methods. > > --AG > > чт, 14 июн. 2018 г. в 17:39, Dmitriy Govorukhin < > dmitriy.govoruk...@gmail.com>: > > >

Re: unused or only used in tests methonds

2018-06-15 Thread Alexey Goncharuk
I have no objections to remove these methods. --AG чт, 14 июн. 2018 г. в 17:39, Dmitriy Govorukhin < dmitriy.govoruk...@gmail.com>: > Igniters, > > I found 2 methods, > > 1. PageStore.pageOffset(long pageId) - it unused, seem that old artifact. > 2. IgnitePageStoreManager.pagesAllocated(int

unused or only used in tests methonds

2018-06-14 Thread Dmitriy Govorukhin
Igniters, I found 2 methods, 1. PageStore.pageOffset(long pageId) - it unused, seem that old artifact. 2. IgnitePageStoreManager.pagesAllocated(int grpId) - used only in test, seem that same problem can be solved with IgnitePageStoreManager.pages(grpId, partId). I suggest, remove these methods