Re: New message on your code reviews when cherry-picking your change fails.

2018-05-11 Thread Sailesh Mukil
Thanks for doing this! On Fri, May 11, 2018 at 12:17 PM, Tim Armstrong wrote: > Thanks for setting this up, this should make things a lot easier. > > On Fri, May 11, 2018 at 12:02 PM, Philip Zeyliger > wrote: > > > Hey folks, > > > > I just updated

Re: New message on your code reviews when cherry-picking your change fails.

2018-05-11 Thread Tim Armstrong
Thanks for setting this up, this should make things a lot easier. On Fri, May 11, 2018 at 12:02 PM, Philip Zeyliger wrote: > Hey folks, > > I just updated https://jenkins.impala.io/job/cherrypick-2.x-and-test/ to > comment on a code review the first time a change causes the

New message on your code reviews when cherry-picking your change fails.

2018-05-11 Thread Philip Zeyliger
Hey folks, I just updated https://jenkins.impala.io/job/cherrypick-2.x-and-test/ to comment on a code review the first time a change causes the cherry-picking job to fail. A sample e-mail is forwarded below, with the message highlighted by me. I've used Gerrit to send e-mail, which, frankly, was

Re: Build error with sqlparse-0.1.14

2018-05-11 Thread Fredy Wijaya
We could also set the PYTHONPATH to be more explicit instead of using a wildcard: https://github.com/apache/impala/blob/master/bin/set-pythonpath.sh#L39 Thoughts? *Fredy Wijaya* | Software Engineer e. fwij...@cloudera.com cloudera.com [image: Cloudera]

Re: Build error with sqlparse-0.1.14

2018-05-11 Thread Fredy Wijaya
Thanks Tim. I was about to email the same thing. On Fri, May 11, 2018 at 11:28 AM, Tim Armstrong wrote: > Just an FYI, since everyone else is probably going to run into this. The > sqlparse version change breaks buildall.sh if you run it on a non-clean > tree. > >