Re: Help with fixing clang-diagnostic-over-aligned

Thanks for the explanation Todd and Dan! I had introduced a new CACHELINE_ALIGNED object into the class which caused this problem. Making the parent classes CACHELINE_ALIGNED too fixed the problem. On Wed, Feb 14, 2018 at 12:58 PM, Todd Lipcon wrote: > This probably means

Re: Help with fixing clang-diagnostic-over-aligned

This probably means that QueryExecMgr (or one of its descendent members) is annotated with __attribute__((aligned(64)), perhaps through something like a CACHELINE_ALIGNED macro. The issue is that, as the warning says, normal libc malloc doesn't make any hard guarantees about the alignment of

Re: Help with fixing clang-diagnostic-over-aligned

Anything that has an aligned field will also need to be aligned (otherwise the field alignment won't be respected). You can do it by inheriting from CacheLinedAlign which includes an operator new (see comment in aligned-new.h). On Wed, Feb 14, 2018 at 12:33 PM, Sailesh Mukil

Help with fixing clang-diagnostic-over-aligned

Does anyone have experience with fixing the following type of clang-tidy warning? /home/ubuntu/Impala/be/src/runtime/exec-env.cc:159:21: warning: type 'impala::QueryExecMgr' requires 64 bytes of alignment and the default allocator only guarantees 16 bytes [clang-diagnostic-over-aligned]