You might even consider doing #4 first - it's OK to have a file that
is only used by one other file, and that way would reduce the burden
to anyone who needs to make a change to a utility file, so they don't
have to make that change in multiple places.
On Thu, Nov 16, 2017 at 7:47 AM, Jin Chul Kim
Sure. Here is a plan to do this carefully.
1. The first change is to move only string part to test-string-expr.cc,
which just move/copy a chunk of code to a new file. There is a redundant
code in the both files between test-expr.cc and test-string-expr.cc because
we hope minimal code change.
2. It
I like this idea.
One thing to be careful of is to not modify the tests themselves when
you move them. It's hard to see such changes in gerrit and it's hard
to track them down in git history.
On Thu, Nov 16, 2017 at 5:34 AM, Jin Chul Kim wrote:
> Hi,
>
> https://issues.apache.org/jira/browse/IMP
Hi,
https://issues.apache.org/jira/browse/IMPALA-5078
I'd like to get your advice if I will refactor expr-test.cc. Henry suggests
grouping tests by string instructions and move them to expr-string-test.cc.
I like his idea. You know filenames (e.g. cast-functions*,
timestamp-functions*, aggregate-
