[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-08 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 22: patch 22: "fixed some of the describe commands" show create table metrics

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-08 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#22). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-08 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#21). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-08 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: (25 comments) > We also need to fix some of the describe commands: > >

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: We also need to fix some of the describe commands:

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 20: (27 comments) I think we can make a lot of small improvements but

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-06 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#19). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-06 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 19: (4 comments) 1.Refactor code in system-table-scan-node remove functions

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-06 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#20). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-06 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#19). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-06 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 18: (28 comments)

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 18: (29 comments)

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-02 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 18: (15 comments) made change based on review. 1. assign table id to metrics

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-02 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#18). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-02 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#18). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-01 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#18). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-09-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 17: (16 comments) Focused on the fe part. I think we need to sort out the

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#17). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 16: This patch add a SystemTableScanner and its subclass MetricScanner to

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-31 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 15: This two patch 1. add authz test and conjunct test. 2. make the scan

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-29 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#14). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-29 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#14). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-29 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#14). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose