Re: Prepare to vote on release candidate 1

2016-09-12 Thread Jim Apple
Just a quick update with where I am with your RC1 feedback. First, let me thank you for all of the feedback - it has been great for Impala, in my opinion. Here is a list of things that I am still planning to do for RC2: 1. Change the tarball name to remove the '-rc1'; instead, I will put the

Re: Prepare to vote on release candidate 1

2016-09-09 Thread Jim Apple
>> - would be nice if the version number didn't have 'cdh5' in it (eg >> impala-shell-2.7.0-cdh5-INTERNAL, seems to come from bin/version.info, >> bin/save-version.sh, etc). Should probably be '2.7.0-incubating' > > Lars is working on this now: > > https://gerrit.cloudera.org/#/c/4187/3 > > Some

Re: Prepare to vote on release candidate 1

2016-09-09 Thread Jim Apple
Do you mean of the tree, ala d4b8675dd7a717c80305f5c35ef0179e9c2034b3 is the hash of the tree https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=tree;h=d4b8675dd7a717c80305f5c35ef0179e9c2034b3;hb=fcb5c6821d1a0b2d49212dd791c4556dd5ac6c9e which I got by looking at this commit

Re: Prepare to vote on release candidate 1

2016-09-09 Thread Tim Armstrong
One thing is to make sure that you don't have any environment variables set pointing to a different directory. E.g. I have IMPALA_HOME in my environment. On Fri, Sep 9, 2016 at 2:09 AM, Lars Volker wrote: > I unpacked the tarball, added all files to a fresh git repo and ran >

Re: Prepare to vote on release candidate 1

2016-09-09 Thread Lars Volker
I unpacked the tarball, added all files to a fresh git repo and ran buildall.sh. It terminated with the following error: CMake Error at be/src/util/CMakeLists.txt:89 (add_library): Cannot find source file: /home/lv/asf/incubator-impala/be/src/thirdparty/squeasel/squeasel.c Can we add the

Re: Prepare to vote on release candidate 1

2016-09-09 Thread Tom White
On Thu, Sep 8, 2016 at 5:27 PM, Jim Apple wrote: > Sure, I can tag the tree where I git archive'd my next RC. Just to be > sure I understand you - what exactly do you mean by the "git SHA"? I just mean git hash. > > On Thu, Sep 8, 2016 at 2:24 AM, Tom White

Re: Prepare to vote on release candidate 1

2016-09-08 Thread Jim Apple
Sure, I can tag the tree where I git archive'd my next RC. Just to be sure I understand you - what exactly do you mean by the "git SHA"? On Thu, Sep 8, 2016 at 2:24 AM, Tom White wrote: > Jim, > > Can you provide a git tag and git SHA for the release when you send > out the

Re: Prepare to vote on release candidate 1

2016-09-08 Thread Jim Apple
I like this idea. For RC2, I'll plan to add a directory in https://dist.apache.org/repos/dist/dev/incubator/impala/2.7.0/ called "RC2", and put the files there with the names starting with "apache-impala-incubating-2.7.0.tar.gz". On Wed, Sep 7, 2016 at 5:01 PM, Tim Armstrong

Re: Prepare to vote on release candidate 1

2016-09-08 Thread Tom White
Jim, Can you provide a git tag and git SHA for the release when you send out the vote so we can check the tarball against the tag. Thanks! Tom On Thu, Sep 8, 2016 at 1:37 AM, Todd Lipcon wrote: > - agree with Tim that it would be nice if the tarball extracted into a >

Re: Prepare to vote on release candidate 1

2016-09-07 Thread Todd Lipcon
- agree with Tim that it would be nice if the tarball extracted into a directory named apache-impala-incubating-2.7.0 (to match the tarball prefix) - A couple places seem to keep a Cloudera copyright/license - eg common/thrift/beeswax.thrift, FrontEndTestBase.java, etc. (I grepped for Cloudera

Re: Prepare to vote on release candidate 1

2016-09-07 Thread Tim Armstrong
I'm in the process of testing this. One nit that I think we should fix: apache-impala-incubating-2.7.0-rc1.tar.gz unpacks to incubator-impala. I think we should stick with the normal convention of unpacking to a directory with the same name as the tarball (or maybe

Re: Prepare to vote on release candidate 1

2016-09-07 Thread Henry Robinson
Jim, this is great work (by everyone) and the culmination of a ton of effort. Thanks for getting us to this stage! On 7 September 2016 at 14:08, Jim Apple wrote: > I have put a release candidate, along with checksums and a > cryptographic signature, in > >

Prepare to vote on release candidate 1

2016-09-07 Thread Jim Apple
I have put a release candidate, along with checksums and a cryptographic signature, in https://dist.apache.org/repos/dist/dev/incubator/impala/2.7.0/ I will be calling for a vote from the PPMC soon. This thread is not the vote thread. That vote will only pass, according to our bylaws, if it has