Re: Small change to all-build-options job

2017-08-12 Thread Jim Apple
Thanks, Henry!

On Fri, Aug 11, 2017 at 11:08 PM, Henry Robinson  wrote:
> [You can probably skip this mail unless you're interested. TLDR: I slightly
> changed the all-build-options job in a very minor way; let me know if you
> see issues with it]
>
> Impala will shortly have a dependency on libkb5-dev, which provides
> Kerberos headers and libraries for security on the KRPC branch. As of Jim's
> recent work, the bootstrap_development.sh script installs that on an Ubuntu
> machine as a pre-requisite. I have added it to bootstrap_build.sh myself.
>
> However, the all-build-options job doesn't seem to use either script, and
> does not appear to install any dependencies. This blocks the patch that
> introduces the libkrb5 dependency from passing GVO. So for now, I've added
> the apt-get line from our bootstrap commands to the job script directly.
> This is a temporary change, and over the next few days I'll file a JIRA to
> sort out the bootstrap scripts so we can call it directly (if all GVO jobs
> are succeeding).
>
> My test jobs have passed the apt-get statement (having installed
> libkrb5-dev succesfully), and seem to be proceeding fine, so there will
> probably be no visible effect from this change. But if you see suspicious
> failures in all-build-options, let me know.
>
> Thanks,
> Henry


Small change to all-build-options job

2017-08-12 Thread Henry Robinson
[You can probably skip this mail unless you're interested. TLDR: I slightly
changed the all-build-options job in a very minor way; let me know if you
see issues with it]

Impala will shortly have a dependency on libkb5-dev, which provides
Kerberos headers and libraries for security on the KRPC branch. As of Jim's
recent work, the bootstrap_development.sh script installs that on an Ubuntu
machine as a pre-requisite. I have added it to bootstrap_build.sh myself.

However, the all-build-options job doesn't seem to use either script, and
does not appear to install any dependencies. This blocks the patch that
introduces the libkrb5 dependency from passing GVO. So for now, I've added
the apt-get line from our bootstrap commands to the job script directly.
This is a temporary change, and over the next few days I'll file a JIRA to
sort out the bootstrap scripts so we can call it directly (if all GVO jobs
are succeeding).

My test jobs have passed the apt-get statement (having installed
libkrb5-dev succesfully), and seem to be proceeding fine, so there will
probably be no visible effect from this change. But if you see suspicious
failures in all-build-options, let me know.

Thanks,
Henry