Re: New Impala contributors: outreach

2017-09-06 Thread Jim Apple 
OK, done:

https://github.com/yourfirstpr/yourfirstpr.github.io/issues/86

https://github.com/up-for-grabs/up-for-grabs.net/pull/717

Can whoever runs the Apache Impala twitter account tweet at
https://twitter.com/yourfirstpr?lang=en?

On Sun, Sep 3, 2017 at 7:27 PM, Jim Apple  wrote:
> I'd like to encourage people who haven't contributed to Impala before
> to get started making patches. One way to do that would be to engage
> with communities where people for reaching out to new contributors.
>
> It appears that Your First PR has a mechanism to invite new
> contributors to the project by filing a ticket:
>
> https://github.com/yourfirstpr/yourfirstpr.github.io/issues?q=is%3Aopen+is%3Aissue
>
> Any objections to me filing a ticket there and pointing to
> https://issues.apache.org/jira/issues/?filter=12341668? That's
> "newbie" open bugs with no assignee.
>
> We could also tweet at https://twitter.com/yourfirstpr?lang=en.
>
> I'm interested in also reaching out via
> https://github.com/up-for-grabs/up-for-grabs.net#add-a-project and
> maybe https://helpwanted.apache.org/, if
> https://issues.apache.org/jira/browse/COMDEV-225 gets fixed.
>
> I'll go ahead with these in a couple of days, unless I hear any
> objections before then.

Re: New Impala contributors: IMPALA-5754

2017-09-06 Thread Jim Apple 
I have posted a link on the ticket to
https://lists.apache.org/thread.html/6fbcfa650cbb920e2b517ae643bcd0859f1ba0368451d2949eda274d@%3Cdev.impala.apache.org%3E.
I hope to write some more of these, after which perhaps I should make
a space on the wiki to hold them all.

On Wed, Sep 6, 2017 at 10:08 AM, Todd Lipcon  wrote:
> Hey JIm,
>
> This is a great tutorial, thanks for posting it. One thought: would be
> great to put this somewhere on the web -- either as a blog post or wiki
> entry, so if someone googles they are more likely to find it. (sometimes
> mailing list archives are harder to bring up in google results)
>
> On Wed, Sep 6, 2017 at 10:05 AM, Jim Apple  wrote:
>
>> If you'd like to contribute a patch to Impala, but aren't sure what
>> you want to work on, you can look at Impala's newbie issues:
>> https://issues.apache.org/jira/issues/?filter=12341668. You can find
>> detailed instructions on submitting patches at
>> https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala.
>> This is a walkthrough of a ticket a new contributor could take on,
>> with hopefully enough detail to get you going but not so much to take
>> away the fun.
>>
>> How can we fix https://issues.apache.org/jira/browse/IMPALA-5754,
>> "rand() algorithm is very non-random"? This is a partial walk-through
>> of how to get started.
>>
>> Set up your development environment. Then, look for where we might
>> first write a failing test. The test case given in the ticket is
>> "select count(distinct(rand(867-5309))), count(*) from alltypes a,
>> alltypes b;". Tests that run a full query are considered "end-to-end
>> tests".
>>
>> End-to-end tests are described in two ways: .test files and .py files.
>>
>> .test files contain queries and their expected results. For example:
>>
>> 
>>  QUERY
>> # Regression test for IMPALA-938
>> select smallint_col, int_col, (cast("1970-01-01" as timestamp) +
>> interval smallint_col days)
>> from functional.alltypes where smallint_col = 1 limit 1
>>  RESULTS
>> 1,1,1970-01-02 00:00:00
>>  TYPES
>> smallint, int, timestamp
>> 
>>
>> That is taken from
>> testdata/workloads/functional-query/queries/QueryTest/exprs.test.
>> That's a good test file to add a test case to, since it is testing
>> "exprs", and the bug is in  MathFunctions::Rand, which is defined in
>> be/src/exprs.
>>
>> First, let's run all of the exprs tests to see that they pass. You can
>> see them called in tests/query_test/test_exprs.py. The Python scrips
>> in tests/ can run these .test files by calling ImpalaTestSuite's
>> run_test_case() method with an abbreviated name of the .test file. In
>> test_exprs.py, this looks like
>>
>> self.run_test_case('QueryTest/exprs', vector)
>>
>> That call is in the method TestExprs.test_exprs(); you can invoke it with:
>>
>> ./bin/impala-py.test
>> tests/query_test/test_exprs.py::TestExprs::test_exprs --sanity
>>
>> This should take about 40 seconds and should pass, indicated by a
>> return value of 0 and a green line printed to the terminal reading:
>>
>> ...== 1 passed in 39.85 seconds ==...
>>
>> Now add a test case, following the example from the ticket and the
>> format in exprs.test. Run the test again; it should fail.
>>
>> Fix the bug and run the test again. Once the test is passing, follow
>> the instructions on the wiki to send your patch for code review:
>> https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala
>>
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera

Re: [VOTE] 2.10.0 release candidate 2 (RC2)

2017-09-06 Thread Bharath Vissapragada 
Thanks to everyone who voted here. The voting window is now closed. I've
sent out a separate results thread.

On Tue, Sep 5, 2017 at 12:30 PM, Michael Brown  wrote:

> +1 (binding)
>
> - downloaded and verified tarballs
> - compiled and ran core tests
> - connected and ran a few queries
>
>
> On Wed, Aug 30, 2017 at 11:35 PM, Bharath Vissapragada <
> bhara...@cloudera.com> wrote:
>
> > This is a vote to release Impala 2.10.0.
> >
> > - The artefacts for testing can be downloaded from <
> > https://dist.apache.org/repos/dist/dev/incubator/impala/2.10.0/RC2/>
> >
> > - The git tag for this release candidate is 2.10.0-rc2 and treehash is
> > visible at
> > <
> > https://git-wip-us.apache.org/repos/asf?p=incubator-impala.
> git;a=tree;hb=
> > 23d79462da5d0108709e8b1399c97606f4ebdf92
> > >
> >
> > Please vote +1 or -1. -1 votes should be accompanied by an explanation of
> > the reason. Only PPMC members and mentors have binding votes, but other
> > community members are encouraged to cast non-binding votes. This vote
> will
> > pass if there are 3 binding +1 votes and more binding +1 votes than -1
> > votes.
> >
> > This wiki page describes how to check the release before you vote:
> > *https://cwiki.apache.org/confluence/display/IMPALA/How+
> > to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate
> >  > to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate>*
> >
> > The vote will be open until the end of day, September 5th, Pacific time
> > zone (UTC-08:00).
> > Once the vote passes the Impala PPMC vote, it still must pass the
> incubator
> > PMC vote before a release is made.
> >
>

Re: New Impala contributors: IMPALA-5754

2017-09-06 Thread Todd Lipcon 
Hey JIm,

This is a great tutorial, thanks for posting it. One thought: would be
great to put this somewhere on the web -- either as a blog post or wiki
entry, so if someone googles they are more likely to find it. (sometimes
mailing list archives are harder to bring up in google results)

On Wed, Sep 6, 2017 at 10:05 AM, Jim Apple  wrote:

> If you'd like to contribute a patch to Impala, but aren't sure what
> you want to work on, you can look at Impala's newbie issues:
> https://issues.apache.org/jira/issues/?filter=12341668. You can find
> detailed instructions on submitting patches at
> https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala.
> This is a walkthrough of a ticket a new contributor could take on,
> with hopefully enough detail to get you going but not so much to take
> away the fun.
>
> How can we fix https://issues.apache.org/jira/browse/IMPALA-5754,
> "rand() algorithm is very non-random"? This is a partial walk-through
> of how to get started.
>
> Set up your development environment. Then, look for where we might
> first write a failing test. The test case given in the ticket is
> "select count(distinct(rand(867-5309))), count(*) from alltypes a,
> alltypes b;". Tests that run a full query are considered "end-to-end
> tests".
>
> End-to-end tests are described in two ways: .test files and .py files.
>
> .test files contain queries and their expected results. For example:
>
> 
>  QUERY
> # Regression test for IMPALA-938
> select smallint_col, int_col, (cast("1970-01-01" as timestamp) +
> interval smallint_col days)
> from functional.alltypes where smallint_col = 1 limit 1
>  RESULTS
> 1,1,1970-01-02 00:00:00
>  TYPES
> smallint, int, timestamp
> 
>
> That is taken from
> testdata/workloads/functional-query/queries/QueryTest/exprs.test.
> That's a good test file to add a test case to, since it is testing
> "exprs", and the bug is in  MathFunctions::Rand, which is defined in
> be/src/exprs.
>
> First, let's run all of the exprs tests to see that they pass. You can
> see them called in tests/query_test/test_exprs.py. The Python scrips
> in tests/ can run these .test files by calling ImpalaTestSuite's
> run_test_case() method with an abbreviated name of the .test file. In
> test_exprs.py, this looks like
>
> self.run_test_case('QueryTest/exprs', vector)
>
> That call is in the method TestExprs.test_exprs(); you can invoke it with:
>
> ./bin/impala-py.test
> tests/query_test/test_exprs.py::TestExprs::test_exprs --sanity
>
> This should take about 40 seconds and should pass, indicated by a
> return value of 0 and a green line printed to the terminal reading:
>
> ...== 1 passed in 39.85 seconds ==...
>
> Now add a test case, following the example from the ticket and the
> format in exprs.test. Run the test again; it should fail.
>
> Fix the bug and run the test again. Once the test is passing, follow
> the instructions on the wiki to send your patch for code review:
> https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala
>



-- 
Todd Lipcon
Software Engineer, Cloudera

New Impala contributors: IMPALA-5754

2017-09-06 Thread Jim Apple 
If you'd like to contribute a patch to Impala, but aren't sure what
you want to work on, you can look at Impala's newbie issues:
https://issues.apache.org/jira/issues/?filter=12341668. You can find
detailed instructions on submitting patches at
https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala.
This is a walkthrough of a ticket a new contributor could take on,
with hopefully enough detail to get you going but not so much to take
away the fun.

How can we fix https://issues.apache.org/jira/browse/IMPALA-5754,
"rand() algorithm is very non-random"? This is a partial walk-through
of how to get started.

Set up your development environment. Then, look for where we might
first write a failing test. The test case given in the ticket is
"select count(distinct(rand(867-5309))), count(*) from alltypes a,
alltypes b;". Tests that run a full query are considered "end-to-end
tests".

End-to-end tests are described in two ways: .test files and .py files.

.test files contain queries and their expected results. For example:


 QUERY
# Regression test for IMPALA-938
select smallint_col, int_col, (cast("1970-01-01" as timestamp) +
interval smallint_col days)
from functional.alltypes where smallint_col = 1 limit 1
 RESULTS
1,1,1970-01-02 00:00:00
 TYPES
smallint, int, timestamp


That is taken from
testdata/workloads/functional-query/queries/QueryTest/exprs.test.
That's a good test file to add a test case to, since it is testing
"exprs", and the bug is in  MathFunctions::Rand, which is defined in
be/src/exprs.

First, let's run all of the exprs tests to see that they pass. You can
see them called in tests/query_test/test_exprs.py. The Python scrips
in tests/ can run these .test files by calling ImpalaTestSuite's
run_test_case() method with an abbreviated name of the .test file. In
test_exprs.py, this looks like

self.run_test_case('QueryTest/exprs', vector)

That call is in the method TestExprs.test_exprs(); you can invoke it with:

./bin/impala-py.test
tests/query_test/test_exprs.py::TestExprs::test_exprs --sanity

This should take about 40 seconds and should pass, indicated by a
return value of 0 and a green line printed to the terminal reading:

...== 1 passed in 39.85 seconds ==...

Now add a test case, following the example from the ticket and the
format in exprs.test. Run the test again; it should fail.

Fix the bug and run the test again. Once the test is passing, follow
the instructions on the wiki to send your patch for code review:
https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala