Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-18 Thread jincheng sun
It seems that step 7 should be performed first to ensure that the commit for step 2 is there. jincheng sun 于2021年2月18日周四 下午8:57写道: > Hi folks, > > We have merged the PRs of IOTDB-1156, i.e., the Spotless with > google-java-format now in effect. > > This change touched most of single java file

[ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-18 Thread jincheng sun
Hi folks, We have merged the PRs of IOTDB-1156, i.e., the Spotless with google-java-format now in effect. This change touched most of single java file in the repository(70K+). So most of PRs will require a rebase, follow the steps below: 1. git checkout YOUR_PR 2. git cherry-pick

Re: [DISCUSS] Create a new Repo to upload binary files (images for markdown, compiled thrift binary, etc..)

2021-02-18 Thread Jialin Qiao
+1 -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 -原始邮件- 发件人: "Chao Wang" 576749...@qq.com 发送时间: 2021-02-18 16:35:20 (星期四) 收件人: dev 抄送: 主题: Re: [DISCUSS] Create a new Repo to upload binary files (images for markdown, compiled thrift binary, etc..) + 1

Re: [DISCUSS] Create a new Repo to upload binary files (images for markdown, compiled thrift binary, etc..)

2021-02-18 Thread Chao Wang
+ 1 ---Original--- From: "Xiangdong Huang"https://user-images.githubusercontent.com/19167280/73625222-ddd88680-467e-11ea-9098-e808ed4979c5.png Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz

Re: [DISCUSS] Create a new Repo to upload binary files (images for markdown, compiled thrift binary, etc..)

2021-02-18 Thread Xiangdong Huang
Hi, any suggestions about this discussion? (I need at least 3 +1 for the next step or a formal vote) Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 jincheng sun 于2021年2月15日周一 下午10:50写道: > Thanks for bring up this discussion,