Re: [DISCUSS] Adding the generation of sboms to our build?

2023-07-14 Thread Xiangdong Huang
Hi Chris, Look forward! SBOM has also received a lot of attention in China. Which kind of format/standard it will obey? Best, --- Xiangdong Huang Christofer Dutz 于2023年7月14日周五 21:28写道: > > Hi all, > > here in Europe we’re currently preparing for quite a bit of a

Re: Usage of Singleton pattern?

2023-07-14 Thread Xiangdong Huang
+1, too. --- Xiangdong Huang Jialin Qiao 于2023年7月14日周五 21:30写道: > > +1 for cleaning it > — > Jialin Qiao > Apache IoTDB PMC > > Yuan Tian 于2023年7月14日周五 21:28写道: > > > > Sure! Do as you want! We would love to see these refactoring prs. > > > > > >

Re: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Xiangdong Huang
+1 for renaming. BTW, seems IoTDB's sonar setting has some errors that test code coverage can not be catched. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Yuan Tian 于2023年7月15日周六 09:50写道: > > We would like to see that for su

[BUILD-FAILURE]: Job 'IoTDB/IoTDB-pip-new/master [master] [288]'

2023-07-14 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'IoTDB/IoTDB-pip-new/master [master] [288]': Check console output at "https://ci-builds.apache.org/job/IoTDB/job/IoTDB-pip-new/job/master/288/";>IoTDB/IoTDB-pip-new/master [master] [288]"

Re: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Yuan Tian
We would like to see that for sure. Best, -- Yuan Tian On Fri, Jul 14, 2023 at 10:13 PM Christofer Dutz wrote: > > We have to file a Jira ticket for Infra … but wanted to know, if it would be > ok for you folks for me to do that. > > Chris > > Von: Yuan Tian > Datum: Freitag, 14.

AW: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Christofer Dutz
We have to file a Jira ticket for Infra … but wanted to know, if it would be ok for you folks for me to do that. Chris Von: Yuan Tian Datum: Freitag, 14. Juli 2023 um 15:40 An: dev@iotdb.apache.org Betreff: Re: [DISCUSS] Setup Sonarcloud for IoTDB? Aha, that's right. Do you know how to change

Re: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Yuan Tian
Aha, that's right. Do you know how to change that name? I didn't find where to change that name before. Best, Yuan Tian On Fri, Jul 14, 2023 at 9:31 PM Christofer Dutz wrote: > > Hehe … ok … so because of the “incubator” in there, I didn’t find it ;-) > > Chris > > > Von: Jialin

AW: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Christofer Dutz
Hi all, Any objections to rename the project from “incubator-iotdb” to “iotdb”? It seems that we’d need to file an infra ticket and they’d rename it for us. Chris Von: Christofer Dutz Datum: Freitag, 14. Juli 2023 um 15:34 An: dev@iotdb.apache.org Betreff: AW: [DISCUSS] Setup Sonarcloud for Io

AW: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Christofer Dutz
So, we’re currently running it in GitHub Actions? In PLC4X we’re running it as part of our Jenkins build. But I guess there too it’s only for committers … but that makes sense as I think even running it on multiple branches would mix up the results, right? Chris Von: Jialin Qiao Datum: Freitag,

AW: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Christofer Dutz
Hehe … ok … so because of the “incubator” in there, I didn’t find it ;-) Chris Von: Jialin Qiao Datum: Freitag, 14. Juli 2023 um 15:29 An: dev@iotdb.apache.org Betreff: Re: [DISCUSS] Setup Sonarcloud for IoTDB? Hi, We have the sonar cloud: https://sonarcloud.io/project/overview?id=apache_incu

Re: Usage of Singleton pattern?

2023-07-14 Thread Jialin Qiao
+1 for cleaning it — Jialin Qiao Apache IoTDB PMC Yuan Tian 于2023年7月14日周五 21:28写道: > > Sure! Do as you want! We would love to see these refactoring prs. > > > Best, > -- > Yuan Tian > > On Fri, Jul 14, 2023 at 9:20 PM Christofer Dutz > wrote: > > > > Aaah cool, >

Re: [DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Jialin Qiao
Hi, We have the sonar cloud: https://sonarcloud.io/project/overview?id=apache_incubator-iotdb But it is only for committers: https://github.com/apache/iotdb/pull/10548 Thanks, — Jialin Qiao Apache IoTDB PMC Christofer Dutz 于2023年7月14日周五 21:24写道: > > Hi folks, > > I just had a lo

Re: Usage of Singleton pattern?

2023-07-14 Thread Yuan Tian
Sure! Do as you want! We would love to see these refactoring prs. Best, -- Yuan Tian On Fri, Jul 14, 2023 at 9:20 PM Christofer Dutz wrote: > > Aaah cool, > > and sorry for asking so much … much of IoTDBs history is not recorded and I’m > just starting to get my hands dirty. >

[DISCUSS] Adding the generation of sboms to our build?

2023-07-14 Thread Christofer Dutz
Hi all, here in Europe we’re currently preparing for quite a bit of an earthquake caused by the Cyber-Resiliency-Act. In some projects I’m involved in (Mainly PLC4X) I’ve started initiating small changes which could make us come out without too many problems. One thing that seems to be coming

[DISCUSS] Setup Sonarcloud for IoTDB?

2023-07-14 Thread Christofer Dutz
Hi folks, I just had a look and noticed that we currently don’t have Sonarcloud analysis setup. At apache we have free access to using it for open-soucre and I’d like to suggest to start using it. Some of the things it reports are definitely going to be false positives, but it also spots a lot

AW: Usage of Singleton pattern?

2023-07-14 Thread Christofer Dutz
Aaah cool, and sorry for asking so much … much of IoTDBs history is not recorded and I’m just starting to get my hands dirty. I am afraid, that I’ll probably have more questions like this as they come up. But that means, if I see something that can be refactored quickly, I can create PRs for st

Re: Usage of Singleton pattern?

2023-07-14 Thread Yuan Tian
Hi Chris, Actually, most of the existing Singleton pattern Class is just for simplifying things during development. And we did run into trouble when writing some UTs(In such case, I will change related Singleton pattern Class ). But there are always higher priority tasks, so there is no time to c

Usage of Singleton pattern?

2023-07-14 Thread Christofer Dutz
Hi all, as I’m digging into IoTDB more and more, I noticed a quite excessive usage of the Singleton pattern … some times even for things where it doesn’t really make much sense. For example in SystemFileFactory, the methods don’t really have much state and simply fire RuntimeExceptions if fsTyp

AW: What are all the empty "ext" directories for?

2023-07-14 Thread Christofer Dutz
Ok … so having had a look, it seems as if this happens in the UDFExecutableManager Class (And the matching other Manager components. The “SystemFileFactory .makeDirIfNecessary” are the ones creating them. Possibly worth investigating if they really need to exist, of if we could change the Manager

Re: What are all the empty "ext" directories for?

2023-07-14 Thread Xiangdong Huang
> I can imagine what it’s used for … I was more just asking, why it’s creating > these directories locally instead of just looking if they exist. Always feels > a bit odd, if loads of empty directories are in my filesystem. agree with that feeling... this can be indeed an improvement if it does