Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-26 Thread Xiangwei Wei
My fault! Thank you for correcting~ Steve Su 于2021年2月26日周五 下午7:26写道: > Hi, > > Thank you for sharing the solution, Xiangwei! > > There is just one thing to note, the correct imports layout should be as > follows: > > import org.apache.iotdb.* > > import all other imports > > import java.* >

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-26 Thread Steve Su
Hi, Thank you for sharing the solution, Xiangwei! There is just one thing to note, the correct imports layout should be as follows: import org.apache.iotdb.* import all other imports import java.* import static all other imports Best, Steve Su --

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-25 Thread Xiangwei Wei
Hi, I tried to configure it in a new computer without code style file. Unfortunately, it merged java packages with *. Then I imported the code style file again, and again, the order of import file was incorrect. Thanks the help of @Steve Su I found the solution of this problem. Search code

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-23 Thread jincheng sun
Thanks for the feedback XiangWei! Just like Xiangdong said, we do not need download the code style file just import from our project is enough. I'd like to know if the plug-in works well to you now? Best, Jincheng Sun 孙金城 Xiangdong Huang 于2021年2月23日周二 上午12:03写道: > > The import ordering is

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-22 Thread Xiangdong Huang
> The import ordering is not handled by this plugin Really? On my IDEA, it works. I did not set the step: "download the IntelliJ Java Google Style file and import it into File→Settings→Editor→Code Style" Best, --- Xiangdong Huang School of Software, Tsinghua

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-22 Thread Xiangwei Wei
Hi Jincheng, I followed the user guide in [1], installed the google-java-format plugin and Save Actions plugin. But it seems the import ordering is not handled properly. In the site of google-java-format [2], the problem is mentioned: "The import ordering is not handled by this plugin,

Re: [ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-18 Thread jincheng sun
It seems that step 7 should be performed first to ensure that the commit for step 2 is there. jincheng sun 于2021年2月18日周四 下午8:57写道: > Hi folks, > > We have merged the PRs of IOTDB-1156, i.e., the Spotless with > google-java-format now in effect. > > This change touched most of single java file

[ANNOUNCE] The Spotless with google-java-format now in effect

2021-02-18 Thread jincheng sun
Hi folks, We have merged the PRs of IOTDB-1156, i.e., the Spotless with google-java-format now in effect. This change touched most of single java file in the repository(70K+). So most of PRs will require a rebase, follow the steps below: 1. git checkout YOUR_PR 2. git cherry-pick