AW: [DISCUSS] Refactor the way we're building/using Thrift

2023-08-04 Thread Christofer Dutz
the way we're building/using Thrift Ok … so after quite a while of refactoring and cleaning up and tweaking, I think my PR is ready for a review. Chris Von: Christofer Dutz Datum: Montag, 31. Juli 2023 um 10:00 An: dev@iotdb.apache.org Betreff: AW: [DISCUSS] Refactor the way we're building/using

AW: [DISCUSS] Refactor the way we're building/using Thrift

2023-08-01 Thread Christofer Dutz
Ok … so after quite a while of refactoring and cleaning up and tweaking, I think my PR is ready for a review. Chris Von: Christofer Dutz Datum: Montag, 31. Juli 2023 um 10:00 An: dev@iotdb.apache.org Betreff: AW: [DISCUSS] Refactor the way we're building/using Thrift And again sorry, turns

AW: [DISCUSS] Refactor the way we're building/using Thrift

2023-07-31 Thread Christofer Dutz
@iotdb.apache.org Betreff: AW: [DISCUSS] Refactor the way we're building/using Thrift Well it seems it’s not quite that simple. Because for example the CMakeList.txt references directories outside of the module itself. https://github.com/apache/iotdb/blob/master/iotdb-client/client-cpp/src/main

AW: [DISCUSS] Refactor the way we're building/using Thrift

2023-07-31 Thread Christofer Dutz
@iotdb.apache.org Betreff: AW: [DISCUSS] Refactor the way we're building/using Thrift Well it seems it’s not quite that simple. Because for example the CMakeList.txt references directories outside of the module itself. https://github.com/apache/iotdb/blob/master/iotdb-client/client-cpp/src/main

AW: [DISCUSS] Refactor the way we're building/using Thrift

2023-07-29 Thread Christofer Dutz
version, we update that module and release it (and stage new thrift assembies in Nexus) This would eliminate all complexities in the build. Chris Von: Xiangdong Huang Datum: Samstag, 29. Juli 2023 um 08:37 An: dev@iotdb.apache.org Betreff: Re: [DISCUSS] Refactor the way we're building/using

Re: [DISCUSS] Refactor the way we're building/using Thrift

2023-07-29 Thread Xiangdong Huang
Hi Chris, > I would like to move the compile-tools directory into the root of the project > and detach it from the rest of the project (So it’s not called from the build > if we build the project). I quickly check current compile-tool, now it is only used by client-cpp. So is it really

[DISCUSS] Refactor the way we're building/using Thrift

2023-07-28 Thread Christofer Dutz
Hi, So, I've been fighting to simplify our use of Thrift, as there were several problems with how we do it today on my M2 Mac (Mostly however to an updated Homebrew, which uses different paths). While going through the project, I noticed that everything in "protocol" downloads a pre-built