The difference is between `/**` and `/*`, i.e., we have very strict control
on javadoc annotation, and multi line annotation will be more flexible.
Xiangdong Huang 于2021年2月17日周三 下午9:40写道：
> Hi,
>
> why moving comments ahead of a class into the inside of the class can
> avoid that?
>
>
Hi,
why moving comments ahead of a class into the inside of the class can
avoid that?
---
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
jincheng sun 于2021年2月17日周三 下午6:21写道：
> Thank you for your positive feedback, Dawei !
>
> #1: May
Thank you for your positive feedback, Dawei !
#1: May be we can turn special class comments into multiline comments for
ensure example readability. more detail can be find [1].
#2: We can fix the incorrect license headers, i.e., `/**` to `/*` in
license header.
It would be great if you have time
Hi,
+1
But there are a few minor issues to watch out for:
1.Formed comments will be corrupted, example:
original:
* +---+ +---+ +---+
* |1 |0 |1 |1 |0 |0 |1 |1 | |1 |0 |1 |1 |0 |0 |0 |0 | |0 |1 |0 |1 |1 |0 |1 |0 |
*
+1
Best,
Jincheng
weizihan0110 于2021年2月16日周二 上午11:16写道：
> +1
>
>
> | |
> Al Wei
> |
> |
> 邮箱：wzh1007181...@163.com
> |
>
> 签名由 网易邮箱大师 定制
>
> On 02/16/2021 10:44, Xiangdong Huang wrote:
> +1. 【please pay attention】, If no -1, I will merge the PR [1] (+70K and
> -69K lines of codes).
>
> I have
+1
| |
Al Wei
|
|
邮箱：wzh1007181...@163.com
|
签名由 网易邮箱大师 定制
On 02/16/2021 10:44, Xiangdong Huang wrote:
+1. 【please pay attention】, If no -1, I will merge the PR [1] (+70K and
-69K lines of codes).
I have tried the commands for solving conflicts. No much work to do.
[1]
+1. 【please pay attention】, If no -1, I will merge the PR [1] (+70K and
-69K lines of codes).
I have tried the commands for solving conflicts. No much work to do.
[1] https://github.com/apache/iotdb/pull/2684
Best,
---
Xiangdong Huang
School of Software, Tsinghua
Hi,
I applied Spotless and Google Java format in the [1] branch, which contains
two commits, one is the POM configuration of spotless, and the other is the
change after the code is automatically formatted. I'm glad to see that we
have automatically fixed many of our problems of mixing 2-space and
Hi,
Thank you all for the feedback Chris，Dawei and Xiangdong!
@Chris You're right. We don't want developers to pay too much attention to
code styles, so I would like to make more efforts to make code styles
automatic, transparent to developers (try our best), when we have finished
the agreed
Take away:
I opt for uniforming the code style. But we have to consider how
to maintain current opened PRs (we have about 40+ PRs) to solve potential
conflicts.
Details:
I opt for uniforming the code style.
In some PRs, we can find many lines are changed just because the indent is
changed...
Perhaps it's just me, but ...
If discussing formatting issues has been consuming a lot of your time, I would
consider this time wasted. Especially as for newcomers this is particularly
frustrating if you sort of provide the solution for a real problem and your
response is "Yeah thanks
11 matches
Mail list logo
