ocate more standard commit process(with pictures)
+1
Agree. A standardized flow is crucial for a growing project.
Xiangwei Wei 于2020年12月30日周三 下午4:12写道：
Hi all,
Recently I found there are some problems existing in the commit
process of
IoTDB and it's getting worse.
Let's see
+1
Agree. A standardized flow is crucial for a growing project.
Xiangwei Wei 于2020年12月30日周三 下午4:12写道：
> Hi all,
>
> Recently I found there are some problems existing in the commit process of
> IoTDB and it's getting worse.
>
> Let's see the actual situation directly. (The screenshots are just
Hi,
There is no meaning to be directed at my examples... There are many commits
like that I show in our Git log.
We'd better pay attention to how to improve this, that's my intention. :D
Xiangdong Huang 于2020年12月30日周三 下午7:45写道：
> Hi,
>
> I'd like to know who merged commits 3496136e9,
Ah... My fault, commit 3da20a (PR #2336) is approved and merged by me...
Another two are approved and merged by others.
I have CC'd to these guys and authors.
Best,
---
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang
Hi,
I'd like to know who merged commits 3496136e9, d76076dc, 3da20a (shown in
your figure).
The committer who click "merge" is the last goalkeeper.
If a contributor submits some meaningless commit log, we have the
responsibility to squash them and write useful log. If we can not, then
just
Hi,
thanks for the suggestions~
> A pull request that changes many files should include many commits that
descript the changing intention in order to make reviews easier.
+1 for that. A pull request is supposed to describe the intention of it in
description in detail. And of course, the commit
+1,
Some other suggestions:
1. A pull request that changes many files should include many commits that
descript the changing intention in order to make reviews easier.
2. Issue description should be both in Chinese and English, especially the
issue title. As issue title can be a navigator,
Sorry guys, it seems that the email @dev can't show the pictures directly.
- -..
The pictures are in the following link:
[1]
https://user-images.githubusercontent.com/34242296/103338924-eddd2e00-4aba-11eb-800f-f89cf052b268.png
[2]
Hi all,
Recently I found there are some problems existing in the commit process of
IoTDB and it's getting worse.
Let's see the actual situation directly. (The screenshots are just
examples, there is no offence.)
First,
It's necessary to create an issue and pull a request for each commit. Maybe
