Re: Who can review this pr?

2019-12-24 Thread atoiLiu
Hi , Thank you very much for your reply. I have revised all the Suggestions you proposed, and added the modification of the document after your review. If you have time, please check the new modification. Best > 在 2019年12月24日,下午5:39,Jialin Qiao 写道: > > Hi, > > Thanks for your contribution

Re: Who can review this pr?

2019-12-24 Thread Jialin Qiao
Hi, Thanks for your contribution :) I have reviewed your PR and give some advice. Best, Jialin Qiao atoiLiu 于2019年12月24日周二 下午5:35写道: > Hi , > The document has not been updated for a long time. I found some problems > in the process of reading the document today and made some changes. > >

Who can review this pr?

2019-12-24 Thread atoiLiu
Hi , The document has not been updated for a long time. I found some problems in the process of reading the document today and made some changes. 1.add Frequently asked questions CN doc 2.add Docker Image CN doc 3.add Programming-JDBC CN doc 4.add TsFile API CN doc 5.some mini modifications

AW: Who can review this pr?

2019-11-26 Thread Christofer Dutz
An: dev@iotdb.apache.org Betreff: Re: Who can review this pr? It is about upgrading antlr3 to antlr4, I don't think it's a good idea to use a software that is no longer maintained. On Wed, Nov 27, 2019 at 9:16 AM Boris Zhu wrote: > Hi, > Can someone help me with reviewing this pr? &

Re: Who can review this pr?

2019-11-26 Thread Lei Rui
Agree. The plugin for Antlr4 in IDEA is really easy to use. Thank you for your work. I can review this pr this week. Lei Rui On 11/27/2019 10:19,Boris Zhu wrote: It is about upgrading antlr3 to antlr4, I don't think it's a good idea to use a software that is no longer maintained. On Wed,

Re: Who can review this pr?

2019-11-26 Thread Boris Zhu
It is about upgrading antlr3 to antlr4, I don't think it's a good idea to use a software that is no longer maintained. On Wed, Nov 27, 2019 at 9:16 AM Boris Zhu wrote: > Hi, > Can someone help me with reviewing this pr? > https://github.com/apache/incubator-iotdb/pull/564 > > Best > Boris >

Who can review this pr?

2019-11-26 Thread Boris Zhu
Hi, Can someone help me with reviewing this pr? https://github.com/apache/incubator-iotdb/pull/564 Best Boris