Re: refactor the modules (for thrift and antlr code generation)

2020-07-02 Thread Xiangdong Huang
Hi, I have finished the PR [1]. After the refactor, everything is wonderful... You either just need to run `mvn generate-source` or `mvn compile -pl thrift,antlr` (very very very fast) to eliminate IDEA's error, or, JUST right-click the project name and choose "maven -> Generate Sources and

Re: refactor the modules (for thrift and antlr code generation)

2020-07-02 Thread Dawei Liu
Hi, +1 for refactor the modules. I ran into the same problem during the compilation. Thanks for bring up this discussion Xiangdong! Best, Dawei Liu On 07/2/2020 17:16,jincheng sun wrote: +1 for the proposal, Thanks for bring up this discussion Xiangdong! Best, Jincheng Julian Feinauer

Re: refactor the modules (for thrift and antlr code generation)

2020-07-02 Thread jincheng sun
+1 for the proposal, Thanks for bring up this discussion Xiangdong! Best, Jincheng Julian Feinauer 于2020年6月29日周一 下午3:41写道: > Hi, > > good point, I agree. > > Julian > > Am 29.06.20, 09:03 schrieb "Xiangdong Huang" : > > Hi, > > > we could also consider migrating to protobuf and grpc

Re: refactor the modules (for thrift and antlr code generation)

2020-06-29 Thread Julian Feinauer
Hi, good point, I agree. Julian Am 29.06.20, 09:03 schrieb "Xiangdong Huang" : Hi, > we could also consider migrating to protobuf and grpc then as I like their maven plugin and it really works flawlessly (and downloads the protoc automagically). I think we can postpone

Re: refactor the modules (for thrift and antlr code generation)

2020-06-29 Thread Xiangdong Huang
Hi, > we could also consider migrating to protobuf and grpc then as I like their maven plugin and it really works flawlessly (and downloads the protoc automagically). I think we can postpone the discussion about the replacement after the cluster module is merged... It will be a disaster if we do

Re: refactor the modules (for thrift and antlr code generation)

2020-06-29 Thread Julian Feinauer
Hi, we could also consider migrating to protobuf and grpc then as I like their maven plugin and it really works flawlessly (and downloads the protoc automagically). But I would also be fine with extracting it. Julian Am 29.06.20, 08:30 schrieb "Xiangdong Huang" : Hi, I suffer from

refactor the modules (for thrift and antlr code generation)

2020-06-29 Thread Xiangdong Huang
Hi, I suffer from this issue for a long time: When I checkout to some branch where the version is xxx-SNAPSHOT and want to run the source codes on the branch in IDE (IDEA), I have to run `mvn generate-sources` first to generate the thrift and antlr4 codes, otherwise, the IDEA will say some