AW: [PR summary] #83 Enable float precision control

2019-03-03 Thread Julian Feinauer
Hi xiangdong, I cannot comment much on the content as I'm still lacking detailed knowledge. But a big +1 for the excellent write up on the list! Julian Von meinem Mobiltelefon gesendet Ursprüngliche Nachricht Betreff: [PR summary] #83 Enable float precision control Von: Xian

[BUILD-STABLE]: Job 'IoTDB-Pipeline/master [master] [59]'

2019-03-03 Thread Apache Jenkins Server
BUILD-STABLE: Job 'IoTDB-Pipeline/master [master] [59]': Is back to normal.

Re: Problems about rat plugin and apache header check

2019-03-03 Thread yi xu
Just in curiosity, our rat plugin is org.apache.rat apache-rat-plugin license-check verify check According to maven grammar, if I want to execute this plugin manually, use ‘mvn rat:check’. Ho

[BUILD-FAILURE]: Job 'IoTDB-Pipeline/master [master] [58]'

2019-03-03 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'IoTDB-Pipeline/master [master] [58]': Check console output at "https://builds.apache.org/job/IoTDB-Pipeline/job/master/58/";>IoTDB-Pipeline/master [master] [58]"

[PR summary] #83 Enable float precision control

2019-03-03 Thread Xiangdong Huang
Hi, As what we discuss in other mailing thread, I will post the summary of my new PRs to this mailing list. This email is for summary the info of PR #83 from Github to this mailing list. PR #83 and #81 is for fixing the issue of IoTDB-31 on JIRA. Yi Xu has reviewed the codes and approved it. N

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread Xiangdong Huang
Hi, In PR #84, I add missing Apache rat on two textual files, I will merge it now to let Apache Jenkins CI works. In this PR, I skip the apache-rat check on Win temporarily, for letting Travis CI works. I also create an issue on JIRA to fix this problem eventually: https://issues.apache.org/jira/

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread Christofer Dutz
Hi all, I have observed the windows and non-windows version to differently detect binary files. Usually it is best not to rely on default detection of binary types (as soon as the plugin detects a binary, it will not comment on it having no headers) Chris Am 03.03.19, 15:17 schrieb "徐毅" :

AW: AW: Problems about rat plugin and apache header check

2019-03-03 Thread Julian Feinauer
Von meinem Mobiltelefon gesendet Hi Xiangdong, Good observation.could it be due to slashes or something? Julian Ursprüngliche Nachricht Betreff: Re: AW: Problems about rat plugin and apache header check Von: 徐毅 An: dev@iotdb.apache.org Cc: It seems that `exclude` configurati

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread 徐毅
It seems that `exclude` configuration does not work on windows, I run "mvn rat:check" command on win10 and jdk8. Tha rat.txt outputs as follow: * Printing headers for files without AL header... =

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread 徐毅
In .travis.yml file. no matter how many os environments you configure, they all execute same commands, for example "mvn clean test". Can we configure a special os to only run 'mvn rat:check' command while other os run 'mvn clean test'? On 3/3/2019 21:50,Xiangdong Huang wrote: Hi, I am not s

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread Xiangdong Huang
Hi, I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11 fails on https://travis-ci.org/apache/incubator-iotdb/builds/500987110 It is easy that just skip apache-rat check on the above 3 jobs. But, I wonder why they failed before I skip that... Does anyone know how to print the file

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread Xiangdong Huang
Hi, > I am not sure whether travis can provide a separated pipeline to run user-specified command. What do you mean about `user-specified command`? Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 徐毅 于2019年3月3日周日 下午8:13写道: > H

Re: TsFilySync

2019-03-03 Thread Xiangdong Huang
Hi, I think Tsfilesync refers to `postback` in the source code, it is in the iotdb module: iotdb/src/main/java/org/apache/iotdb/db/postback. By the way, doesn't like other modules, I think current postback function lacks enough tests. Best, --- Xiangdong Huang Sch

Re: AW: Problems about rat plugin and apache header check

2019-03-03 Thread 徐毅
Hi When someone creates a pull request from forked repo, jenkins won't trigger to run tests. So we use travis-ci to trigger tests on different os. I am not sure whether travis can provide a separated pipeline to run user-specified command. Thanks XuYi On 3/3/2019 19:46,Julian Feinauer wrote

AW: Problems about rat plugin and apache header check

2019-03-03 Thread Julian Feinauer
Hi, this behavior sounds strange. But I think this pipeline should be build into the Jenkins build, or? It should be pretty easy to force one build step to a specific os. Perhaps we should open a Jira for that issue to finally track down the real source of the problem. Julian Von meinem Mobilt

Problems about rat plugin and apache header check

2019-03-03 Thread 徐毅
Hi, Now we use rat plugin to check apache header, it seems that our project can pass rat check on linux but failed on windows. If someone creates a pull request from his forked repo, we use travis-ci to run tests on different os without checking apache header. If we add apache header check i

TsFilySync

2019-03-03 Thread Julian Feinauer
Hi all, While learning the fundamentals of the project I went through the code and the docs. In the docs, especially in the images there is multiple times a mention of tsfilysync. But I cannot find code for this. Is the docu out of sync or can you point me to where i find the classes and give a

AW: Podling Report Reminder - March 2019

2019-03-03 Thread Julian Feinauer
Hi, I totally agree with what's been said by Chris and Justin. This is one of the mature learnings towards becoming a tlp from my perspective. Especially when the community grows and more developer or groups join the project. So with regards to calcite integration i can of course only integrate

AW: Welcome to the IoTDB project

2019-03-03 Thread Julian Feinauer
Hi, I have to check the calcite code to see whether remarks are passed via the Meta or not. Generally your implementation of the table interface should provide its meta data via the present abstract functions. Can you give a mwe or a link to a branch, then I could check. Julian Von meinem Mob