Hi Chris,

Thank you already for jumping in!

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Issues with the assembly
Von: Christofer Dutz
An: dev@iotdb.apache.org
Cc:

Hi all,

so I spared some time between all of my pre-ApacheCon duties and had a look at 
the assembly issues.
We have to change something for the binary release to work.

The problem is that the assembly is executed immediately at the beginning of 
the build. While this doesn’t matter for Source releases (All the sources are 
already there),
For the binary release, the jars have not yet been built. If you run a “maven 
package” and then again with the release-profile, then it will find jars and 
pack them in, but this is not what we want.
During a release, the plugin checks out the tagged version into 
“target/checkout” therefore the assembly will stay empty in every attempt.

Having an even deeper look into the descriptor the main problem is that you are 
referencing files so in order to include them into the assembly.
This is considered bad practice and you should use moduleSets and reference the 
artifacts directly. Also is there a pretty new.

I’ve already cleaned up quite a bit and will continue tomorrow … as soon as 
that’s done I’ll submit a PR (Or send it to Julian).

Chris

PS: Perhaps some good reading points:
https://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html




Reply via email to