Sending the PR from forked branch is good way, it's much safe way for the newbee to go. Not sure if the Jenkins can send a comments for the PR result. In ServiceComb Pack [1], we just leverage travis to run the CI, once the test passed, travis send a message to github, we can easily tell the PR is good or bad.
[1]https://github.com/apache/servicecomb-pack/pull/403 Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Feb 1, 2019 at 11:17 PM Xiangdong Huang <saint...@gmail.com> wrote: > > Hi, > > I remember some mentor said that "do not submit PR from your forked repo" > if you are an initial committer. > > If you create a new branch, then Apache Jenkins can cover it. So, we can > guarantee the master can pass the Apache Jenkins test after merging the PR. > > However, if you create a new branch in your repo and submit a PR, we have > no idea to guarantee the master is ok after mergence. (e.g., PR #36 @Yi Xu) > > I think we may need to require all PRs that come from forked Repo target to > the dev branch, rather than the master branch. Then, the steps are: > > 1. Merge the PR into the dev branch; > 2. run Apache's Jenkins for the dev branch; > 3. If Step 2 is ok, then merge the master with the dev branch; > In this way, we can avoid to roll back the master branch. > > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院
