Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread GESCONSULTOR - Óscar Bou
Really well-looking, Jeroen. Regarding navigability through actions, I think that perhaps there are 2 distinct use cases that should be treated differently as such: 1. The user creates an Aggregate Root (such as an Order). As such, normally want to navigate to the newly created one. 2. The

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread Dan Haywood
That's an interesting idea, Oscar. The issue arises from the fact that there are potentially two different callers of the Order#createItem method: a) the Isis framework itself - in which case, as we all know, the signature of the methdo is used to determine presentation/navigation b) other domain

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread GESCONSULTOR - Óscar Bou
Hi, Dan. I like a lot the idea of explicitly having an annotation for Aggregate Roots (and, commercially speaking, it can be a big call to all those interested on DDD...). I'm sure we will find more use cases for that annotation in the near future, as it will force us to consider the distinct

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread Jeroen van der Wal
I also prefer an annotation and not put boilerplate code in the domain for ui purposes. An @AggregateRoot annotation doesn't meet all our requirements though: we have cases where child objects are an aggregate in it's own: Lease - @AggregateRoot + LeaseItem - aggregate for terms + LeaseTerm

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread GESCONSULTOR - Óscar Bou
This is a mixed approach and I would prefer it also. The viewer annotation @Void (if it's for the viewer, perhaps @NotNavigate or something more specific or explicit would be better than the generic term void ) would have preference on the viewer's behavior. In absence, the logic could be to

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread Jeroen van der Wal
@NotNagivate is indeed a better term. But if we use @AggregateRoot as default behavior we also need a directive to excplicity move away from the aggregate: @AggregateRoot public class Invoice { ... public Invoice creditThisInvoice() { // The @AR annotation prevents the viewer

Re: ISIS-486: modal dialogs for action prompts

2013-12-03 Thread GESCONSULTOR - Óscar Bou
Simple and clear. I like it. :-)) But not sure if on the provided example the viewer would prevent to navigate to the newly created one. I would expect the logic to be the next one: 1. Verify if the action is annotated with @NotNavigate or @Navigate. If so, execute that behavior (as it's

[jira] [Commented] (ISIS-486) Show action dialogs in a modal dialog rather than new page (less context switching for user)

2013-12-03 Thread Jeroen van der Wal (JIRA)
[ https://issues.apache.org/jira/browse/ISIS-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838268#comment-13838268 ] Jeroen van der Wal commented on ISIS-486: - I did a quick-n-dirty fix on the css to

[jira] [Commented] (ISIS-621) Wicket viewer's parsing of numbers silently ignores invalidly formatted numbers

2013-12-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/ISIS-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838416#comment-13838416 ] ASF subversion and git services commented on ISIS-621: -- Commit