[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model

2023-01-19 Thread GitBox
andi-huber commented on PR #1371: URL: https://github.com/apache/isis/pull/1371#issuecomment-1396607319 I'll see that I add this new menu bar entry to our demo app. I might do some tiny refactoring. And as I said I like the idea, but don't particularly like the programmatic HTML

[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model

2023-01-17 Thread GitBox
andi-huber commented on PR #1371: URL: https://github.com/apache/isis/pull/1371#issuecomment-1386461365 For now, let's keep this PR open for further discussion and ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model

2023-01-17 Thread GitBox
andi-huber commented on PR #1371: URL: https://github.com/apache/isis/pull/1371#issuecomment-1386429923 While there is nothing wrong with the code, I don't think we'll merge it into the framework. Mainly because I think the docs created are suitable to provide a documentation blueprint,