[jira] [Commented] (ISIS-2383) Regression: cannot create mementos from detached choice pojos

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148376#comment-17148376
 ] 

ASF subversion and git services commented on ISIS-2383:
---

Commit d85f81db3a599974817957e7468a7b32446da362 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d85f81d ]

ISIS-2383: add CanVector a mutable, but fixed size vector of Can

> Regression: cannot create mementos from detached choice pojos
> -
>
> Key: ISIS-2383
> URL: https://issues.apache.org/jira/browse/ISIS-2383
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> For supporting methods that provide choices of entity objects, those might 
> get detached before the framework gets a chance to create mementos for these.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2222) Flesh out demo app with extra examples.

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148647#comment-17148647
 ] 

ASF subversion and git services commented on ISIS-:
---

Commit bbe4454695ac07ef632594386deeb740aa56fadb in isis's branch 
refs/heads/ISIS- from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bbe4454 ]

ISIS-: wip


> Flesh out demo app with extra examples.
> ---
>
> Key: ISIS-
> URL: https://issues.apache.org/jira/browse/ISIS-
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Examples
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2222) Flesh out demo app with extra examples.

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148650#comment-17148650
 ] 

ASF subversion and git services commented on ISIS-:
---

Commit 9578e3507095be64d829c7fe0b4d92d9c257dc61 in isis's branch 
refs/heads/ISIS- from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9578e35 ]

ISIS-: wip


> Flesh out demo app with extra examples.
> ---
>
> Key: ISIS-
> URL: https://issues.apache.org/jira/browse/ISIS-
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Examples
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2222) Flesh out demo app with extra examples.

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148649#comment-17148649
 ] 

ASF subversion and git services commented on ISIS-:
---

Commit d3afa9ebfe9fcdca21a8aa62d440f56a77870ad3 in isis's branch 
refs/heads/ISIS- from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d3afa9e ]

ISIS-: wip


> Flesh out demo app with extra examples.
> ---
>
> Key: ISIS-
> URL: https://issues.apache.org/jira/browse/ISIS-
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Examples
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148644#comment-17148644
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 6e1ba6fd11dce24c0930dc3605023072a0cb49db in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6e1ba6f ]

ISIS-2340: fx Markup: handle href links with system default browser

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2383) Regression: cannot create mementos from detached choice pojos

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148737#comment-17148737
 ] 

ASF subversion and git services commented on ISIS-2383:
---

Commit 7dfd10e8e73386210f89f677b92a4e0e3eee939b in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=7dfd10e ]

ISIS-2383: intermediate: re-model choice providers to use
CanVector instead of Pojo Object Arrays

- make the choice providers more robust against wrong choice spec types,
by explicitly passing over the required spec
- yet has some lines for debugging, to be removed later


> Regression: cannot create mementos from detached choice pojos
> -
>
> Key: ISIS-2383
> URL: https://issues.apache.org/jira/browse/ISIS-2383
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> For supporting methods that provide choices of entity objects, those might 
> get detached before the framework gets a chance to create mementos for these.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148641#comment-17148641
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit aa8cdfb72a59ce66c38b37cc145d9df1c5c6d680 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=aa8cdfb ]

ISIS-2340: fx: stubs for a FormPane

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148640#comment-17148640
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 45a9aa8915395695b7d477a3dcdb421689e68428 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=45a9aa8 ]

ISIS-2340: fx: basic support for bs3 grid layout

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148642#comment-17148642
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 53a25095d36822ddf31fbe5c48157385d26e6732 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=53a2509 ]

ISIS-2340: fx: simple form/field rendering

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2383) Regression: cannot create mementos from detached choice pojos

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148648#comment-17148648
 ] 

ASF subversion and git services commented on ISIS-2383:
---

Commit d85f81db3a599974817957e7468a7b32446da362 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d85f81d ]

ISIS-2383: add CanVector a mutable, but fixed size vector of Can

> Regression: cannot create mementos from detached choice pojos
> -
>
> Key: ISIS-2383
> URL: https://issues.apache.org/jira/browse/ISIS-2383
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> For supporting methods that provide choices of entity objects, those might 
> get detached before the framework gets a chance to create mementos for these.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2222) Flesh out demo app with extra examples.

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148646#comment-17148646
 ] 

ASF subversion and git services commented on ISIS-:
---

Commit 39dcfbf63b14b69d99d36314cc4d20f41e502bc1 in isis's branch 
refs/heads/ISIS- from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=39dcfbf ]

ISIS-: wip


> Flesh out demo app with extra examples.
> ---
>
> Key: ISIS-
> URL: https://issues.apache.org/jira/browse/ISIS-
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Examples
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148645#comment-17148645
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 34d691574dec3fcc69362b6f29aa18f4343e48d0 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=34d6915 ]

ISIS-2340: fx: adds TextFieldFactory (in preparation of. a binding API)

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148643#comment-17148643
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 0bf0750f39afc3e7f83f5086f7b03a262762f662 in isis's branch 
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0bf0750 ]

ISIS-2340: fx: WebView with autofit, to render Markup types

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2383) Regression: cannot create mementos from detached choice pojos

2020-06-30 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-2383.
--
Resolution: Fixed

supposedly fixed

> Regression: cannot create mementos from detached choice pojos
> -
>
> Key: ISIS-2383
> URL: https://issues.apache.org/jira/browse/ISIS-2383
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> For supporting methods that provide choices of entity objects, those might 
> get detached before the framework gets a chance to create mementos for these.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2384) Action that takes a List of view models fails to gather them when object has been viewed already

2020-06-30 Thread Brian Kalbfus (Jira)
Brian Kalbfus created ISIS-2384:
---

 Summary: Action that takes a List of view models fails to gather 
them when object has been viewed already
 Key: ISIS-2384
 URL: https://issues.apache.org/jira/browse/ISIS-2384
 Project: Isis
  Issue Type: Bug
  Components: Isis Examples
Affects Versions: 2.0.0-M3
Reporter: Brian Kalbfus


>From demo in master, apply this patch:
{code:java}
diff --git 
a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
 
b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
index 92a26bc..476ca60 100644
--- 
a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
+++ 
b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
@@ -37,11 +37,10 @@
 import org.apache.isis.applib.annotation.Property;
 import org.apache.isis.applib.annotation.SemanticsOf;
 
+import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
 import lombok.Getter;
 import lombok.Setter;
 
-import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
-
 //tag::class[]
 @XmlRootElement(name = "demo.StatefulViewModelJaxbRefsEntity")
 @XmlType(
@@ -103,6 +102,14 @@
 @XmlElement(name = "child")
 private List children = new ArrayList<>();
 
+@Action(associateWith = "children")
+public StatefulViewModelJaxbRefsEntity suffixChildren(List 
children) {
+   for(ChildJdoEntity child : children) {
+   child.setName(child.getName() + ", Jr");
+   }
+   return this;
+}
+
 @Action(associateWith = "children", associateWithSequence = "1", semantics 
= SemanticsOf.NON_IDEMPOTENT)
 public StatefulViewModelJaxbRefsEntity addChild(final ChildJdoEntity 
child) {
 children.add(child);

{code}
Then, on the demo wicket page, go to the view models refs entity.  Add all 
children.  Then view all children individually (I used ctrl-click). 

 

Then, select all the children and run the "Suffix Children" action.  Before 
being prompted to affirm the selected children, an NPE occurs:
{noformat}

java.lang.NullPointerException




java.util.Objects#requireNonNull(Objects.java:222)



org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.LinkAndLabelFactoryAbstract$1#doOnClick(LinkAndLabelFactoryAbstract.java:112)



org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLink#onClick(ActionLink.java:100)



org.apache.wicket.ajax.markup.html.AjaxLink$1#onEvent(AjaxLink.java:85)



org.apache.wicket.ajax.AjaxEventBehavior#respond(AjaxEventBehavior.java:127)



org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#onRequest(AbstractDefaultAjaxBehavior.java:598)



org.apache.wicket.core.request.handler.ListenerRequestHandler#internalInvoke(ListenerRequestHandler.java:306)



org.apache.wicket.core.request.handler.ListenerRequestHandler#invoke(ListenerRequestHandler.java:280)



org.apache.wicket.core.request.handler.ListenerRequestHandler#invokeListener(ListenerRequestHandler.java:222)



org.apache.wicket.core.request.handler.ListenerRequestHandler#respond(ListenerRequestHandler.java:208)



org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:914)



org.apache.wicket.request.RequestHandlerExecutor#execute(RequestHandlerExecutor.java:65)



org.apache.wicket.request.cycle.RequestCycle#execute(RequestCycle.java:282)



org.apache.wicket.request.cycle.RequestCycle#processRequest(RequestCycle.java:253)


 

[jira] [Resolved] (ISIS-2384) Action that takes a List of view models fails to gather them when object has been viewed already

2020-06-30 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-2384.
--
Resolution: Fixed

fortunately 'just' a simple de-serialization bug

> Action that takes a List of view models fails to gather them when object has 
> been viewed already
> 
>
> Key: ISIS-2384
> URL: https://issues.apache.org/jira/browse/ISIS-2384
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Examples
>Affects Versions: 2.0.0-M3
>Reporter: Brian Kalbfus
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> From demo in master, apply this patch:
> {code:java}
> diff --git 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
>  
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> index 92a26bc..476ca60 100644
> --- 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> +++ 
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> @@ -37,11 +37,10 @@
>  import org.apache.isis.applib.annotation.Property;
>  import org.apache.isis.applib.annotation.SemanticsOf;
>  
> +import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
>  import lombok.Getter;
>  import lombok.Setter;
>  
> -import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
> -
>  //tag::class[]
>  @XmlRootElement(name = "demo.StatefulViewModelJaxbRefsEntity")
>  @XmlType(
> @@ -103,6 +102,14 @@
>  @XmlElement(name = "child")
>  private List children = new ArrayList<>();
>  
> +@Action(associateWith = "children")
> +public StatefulViewModelJaxbRefsEntity 
> suffixChildren(List children) {
> + for(ChildJdoEntity child : children) {
> + child.setName(child.getName() + ", Jr");
> + }
> + return this;
> +}
> +
>  @Action(associateWith = "children", associateWithSequence = "1", 
> semantics = SemanticsOf.NON_IDEMPOTENT)
>  public StatefulViewModelJaxbRefsEntity addChild(final ChildJdoEntity 
> child) {
>  children.add(child);
> {code}
> Then, on the demo wicket page, go to the view models refs entity.  Add all 
> children.  Then view all children individually (I used ctrl-click). 
>  
> Then, select all the children and run the "Suffix Children" action.  Before 
> being prompted to affirm the selected children, an NPE occurs:
> {noformat}
> 
> java.lang.NullPointerException
> 
> 
> 
> 
> java.util.Objects#requireNonNull(Objects.java:222)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.LinkAndLabelFactoryAbstract$1#doOnClick(LinkAndLabelFactoryAbstract.java:112)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLink#onClick(ActionLink.java:100)
> 
> 
> org.apache.wicket.ajax.markup.html.AjaxLink$1#onEvent(AjaxLink.java:85)
> 
> 
> org.apache.wicket.ajax.AjaxEventBehavior#respond(AjaxEventBehavior.java:127)
> 
> 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#onRequest(AbstractDefaultAjaxBehavior.java:598)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#internalInvoke(ListenerRequestHandler.java:306)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invoke(ListenerRequestHandler.java:280)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invokeListener(ListenerRequestHandler.java:222)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#respond(ListenerRequestHandler.java:208)
> 
> 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:914)
> 

[jira] [Created] (ISIS-2385) Jaxb PersistentEntityAdapter fails when asked to marshal detached entities

2020-06-30 Thread Andi Huber (Jira)
Andi Huber created ISIS-2385:


 Summary: Jaxb PersistentEntityAdapter fails when asked to marshal 
detached entities
 Key: ISIS-2385
 URL: https://issues.apache.org/jira/browse/ISIS-2385
 Project: Isis
  Issue Type: Bug
  Components: Isis Core
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M4


Reason: BookmarkService cannot create bookmark for detached entity.

is related to https://issues.apache.org/jira/browse/ISIS-2383

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ISIS-2384) Action that takes a List of view models fails to gather them when object has been viewed already

2020-06-30 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-2384:


Assignee: Andi Huber

> Action that takes a List of view models fails to gather them when object has 
> been viewed already
> 
>
> Key: ISIS-2384
> URL: https://issues.apache.org/jira/browse/ISIS-2384
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Examples
>Affects Versions: 2.0.0-M3
>Reporter: Brian Kalbfus
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> From demo in master, apply this patch:
> {code:java}
> diff --git 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
>  
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> index 92a26bc..476ca60 100644
> --- 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> +++ 
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> @@ -37,11 +37,10 @@
>  import org.apache.isis.applib.annotation.Property;
>  import org.apache.isis.applib.annotation.SemanticsOf;
>  
> +import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
>  import lombok.Getter;
>  import lombok.Setter;
>  
> -import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
> -
>  //tag::class[]
>  @XmlRootElement(name = "demo.StatefulViewModelJaxbRefsEntity")
>  @XmlType(
> @@ -103,6 +102,14 @@
>  @XmlElement(name = "child")
>  private List children = new ArrayList<>();
>  
> +@Action(associateWith = "children")
> +public StatefulViewModelJaxbRefsEntity 
> suffixChildren(List children) {
> + for(ChildJdoEntity child : children) {
> + child.setName(child.getName() + ", Jr");
> + }
> + return this;
> +}
> +
>  @Action(associateWith = "children", associateWithSequence = "1", 
> semantics = SemanticsOf.NON_IDEMPOTENT)
>  public StatefulViewModelJaxbRefsEntity addChild(final ChildJdoEntity 
> child) {
>  children.add(child);
> {code}
> Then, on the demo wicket page, go to the view models refs entity.  Add all 
> children.  Then view all children individually (I used ctrl-click). 
>  
> Then, select all the children and run the "Suffix Children" action.  Before 
> being prompted to affirm the selected children, an NPE occurs:
> {noformat}
> 
> java.lang.NullPointerException
> 
> 
> 
> 
> java.util.Objects#requireNonNull(Objects.java:222)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.LinkAndLabelFactoryAbstract$1#doOnClick(LinkAndLabelFactoryAbstract.java:112)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLink#onClick(ActionLink.java:100)
> 
> 
> org.apache.wicket.ajax.markup.html.AjaxLink$1#onEvent(AjaxLink.java:85)
> 
> 
> org.apache.wicket.ajax.AjaxEventBehavior#respond(AjaxEventBehavior.java:127)
> 
> 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#onRequest(AbstractDefaultAjaxBehavior.java:598)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#internalInvoke(ListenerRequestHandler.java:306)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invoke(ListenerRequestHandler.java:280)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invokeListener(ListenerRequestHandler.java:222)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#respond(ListenerRequestHandler.java:208)
> 
> 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:914)
> 
>

[jira] [Updated] (ISIS-2384) Action that takes a List of view models fails to gather them when object has been viewed already

2020-06-30 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2384:
-
Fix Version/s: 2.0.0-M4

> Action that takes a List of view models fails to gather them when object has 
> been viewed already
> 
>
> Key: ISIS-2384
> URL: https://issues.apache.org/jira/browse/ISIS-2384
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Examples
>Affects Versions: 2.0.0-M3
>Reporter: Brian Kalbfus
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> From demo in master, apply this patch:
> {code:java}
> diff --git 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
>  
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> index 92a26bc..476ca60 100644
> --- 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> +++ 
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> @@ -37,11 +37,10 @@
>  import org.apache.isis.applib.annotation.Property;
>  import org.apache.isis.applib.annotation.SemanticsOf;
>  
> +import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
>  import lombok.Getter;
>  import lombok.Setter;
>  
> -import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
> -
>  //tag::class[]
>  @XmlRootElement(name = "demo.StatefulViewModelJaxbRefsEntity")
>  @XmlType(
> @@ -103,6 +102,14 @@
>  @XmlElement(name = "child")
>  private List children = new ArrayList<>();
>  
> +@Action(associateWith = "children")
> +public StatefulViewModelJaxbRefsEntity 
> suffixChildren(List children) {
> + for(ChildJdoEntity child : children) {
> + child.setName(child.getName() + ", Jr");
> + }
> + return this;
> +}
> +
>  @Action(associateWith = "children", associateWithSequence = "1", 
> semantics = SemanticsOf.NON_IDEMPOTENT)
>  public StatefulViewModelJaxbRefsEntity addChild(final ChildJdoEntity 
> child) {
>  children.add(child);
> {code}
> Then, on the demo wicket page, go to the view models refs entity.  Add all 
> children.  Then view all children individually (I used ctrl-click). 
>  
> Then, select all the children and run the "Suffix Children" action.  Before 
> being prompted to affirm the selected children, an NPE occurs:
> {noformat}
> 
> java.lang.NullPointerException
> 
> 
> 
> 
> java.util.Objects#requireNonNull(Objects.java:222)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.LinkAndLabelFactoryAbstract$1#doOnClick(LinkAndLabelFactoryAbstract.java:112)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLink#onClick(ActionLink.java:100)
> 
> 
> org.apache.wicket.ajax.markup.html.AjaxLink$1#onEvent(AjaxLink.java:85)
> 
> 
> org.apache.wicket.ajax.AjaxEventBehavior#respond(AjaxEventBehavior.java:127)
> 
> 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#onRequest(AbstractDefaultAjaxBehavior.java:598)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#internalInvoke(ListenerRequestHandler.java:306)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invoke(ListenerRequestHandler.java:280)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invokeListener(ListenerRequestHandler.java:222)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#respond(ListenerRequestHandler.java:208)
> 
> 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:914)
> 
> 

[jira] [Commented] (ISIS-2384) Action that takes a List of view models fails to gather them when object has been viewed already

2020-06-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149101#comment-17149101
 ] 

ASF subversion and git services commented on ISIS-2384:
---

Commit 26bcd39aefefa563aefa0c68398ad03b89cbebb8 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=26bcd39 ]

ISIS-2384: fixes ActionLink not being properly deserialized

> Action that takes a List of view models fails to gather them when object has 
> been viewed already
> 
>
> Key: ISIS-2384
> URL: https://issues.apache.org/jira/browse/ISIS-2384
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Examples
>Affects Versions: 2.0.0-M3
>Reporter: Brian Kalbfus
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> From demo in master, apply this patch:
> {code:java}
> diff --git 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
>  
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> index 92a26bc..476ca60 100644
> --- 
> a/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> +++ 
> b/examples/demo/domain/src/main/java/demoapp/dom/viewmodels/jaxbrefentity/StatefulViewModelJaxbRefsEntity.java
> @@ -37,11 +37,10 @@
>  import org.apache.isis.applib.annotation.Property;
>  import org.apache.isis.applib.annotation.SemanticsOf;
>  
> +import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
>  import lombok.Getter;
>  import lombok.Setter;
>  
> -import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
> -
>  //tag::class[]
>  @XmlRootElement(name = "demo.StatefulViewModelJaxbRefsEntity")
>  @XmlType(
> @@ -103,6 +102,14 @@
>  @XmlElement(name = "child")
>  private List children = new ArrayList<>();
>  
> +@Action(associateWith = "children")
> +public StatefulViewModelJaxbRefsEntity 
> suffixChildren(List children) {
> + for(ChildJdoEntity child : children) {
> + child.setName(child.getName() + ", Jr");
> + }
> + return this;
> +}
> +
>  @Action(associateWith = "children", associateWithSequence = "1", 
> semantics = SemanticsOf.NON_IDEMPOTENT)
>  public StatefulViewModelJaxbRefsEntity addChild(final ChildJdoEntity 
> child) {
>  children.add(child);
> {code}
> Then, on the demo wicket page, go to the view models refs entity.  Add all 
> children.  Then view all children individually (I used ctrl-click). 
>  
> Then, select all the children and run the "Suffix Children" action.  Before 
> being prompted to affirm the selected children, an NPE occurs:
> {noformat}
> 
> java.lang.NullPointerException
> 
> 
> 
> 
> java.util.Objects#requireNonNull(Objects.java:222)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.LinkAndLabelFactoryAbstract$1#doOnClick(LinkAndLabelFactoryAbstract.java:112)
> 
> 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLink#onClick(ActionLink.java:100)
> 
> 
> org.apache.wicket.ajax.markup.html.AjaxLink$1#onEvent(AjaxLink.java:85)
> 
> 
> org.apache.wicket.ajax.AjaxEventBehavior#respond(AjaxEventBehavior.java:127)
> 
> 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#onRequest(AbstractDefaultAjaxBehavior.java:598)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#internalInvoke(ListenerRequestHandler.java:306)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invoke(ListenerRequestHandler.java:280)
> 
> 
> org.apache.wicket.core.request.handler.ListenerRequestHandler#invokeListener(ListenerRequestHandler.java:222)
> 
> 
>