[jira] [Updated] (ISIS-235) Remove dependency on @Named to return parameter name
[ https://issues.apache.org/jira/browse/ISIS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-235: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Remove dependency on @Named to return parameter name > > > Key: ISIS-235 > URL: https://issues.apache.org/jira/browse/ISIS-235 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Jeroen van der Wal >Assignee: Dan Haywood >Priority: Minor > Fix For: core-2.0.0 > > > Parameter names have to be annotated with @Named to have the Isis show the > parameter name of an action in the viewers and restful api. Implementing > Paranamer [1] in Isis solves the problem that currently Java reflection does > not return parameter names. The current behaviour of @Named should not change > and will override the parameter name. > [1] http://paranamer.codehaus.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (ISIS-235) Remove dependency on @Named to return parameter name
[ https://issues.apache.org/jira/browse/ISIS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-235: Assignee: Dan Haywood > Remove dependency on @Named to return parameter name > > > Key: ISIS-235 > URL: https://issues.apache.org/jira/browse/ISIS-235 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Jeroen van der Wal >Assignee: Dan Haywood >Priority: Minor > Fix For: core-2.0.0 > > > Parameter names have to be annotated with @Named to have the Isis show the > parameter name of an action in the viewers and restful api. Implementing > Paranamer [1] in Isis solves the problem that currently Java reflection does > not return parameter names. The current behaviour of @Named should not change > and will override the parameter name. > [1] http://paranamer.codehaus.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-643) FrameworkSynchronizer throws NPE on delete of child entity in 1-N relationship
[ https://issues.apache.org/jira/browse/ISIS-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131704#comment-14131704 ] ASF subversion and git services commented on ISIS-643: -- Commit eb5b2b07f1191b92fb32993e625d15d594e6c8e2 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eb5b2b0 ] ISIS-643: similar fix in preDelete processing. But here, rather than an NPE guard, instead force the adapter to be loaded such that it can be enlisted in the xactn. > FrameworkSynchronizer throws NPE on delete of child entity in 1-N relationship > -- > > Key: ISIS-643 > URL: https://issues.apache.org/jira/browse/ISIS-643 > Project: Isis > Issue Type: Bug > Components: Core: Objectstore: JDO >Affects Versions: objectstore-jdo-1.3.0 >Reporter: Ranganath Chittari >Assignee: Dan Haywood >Priority: Blocker > Fix For: core-1.7.0 > > Attachments: ISIS-JDO-Delete.log, MOrganisation.java, > OmOrgExtendedAttr.java > > > Hello, > Scenario is: > There is 1-N relationship between MOrganisation and OmOrgExtendedAttr > entities. MOrganisation is parent entity and OmOrgExtendedAttr is child > entity. > OmOrgExtendedAttr cannot exist without MOrganisation. > MOrganisation can exist without OmOrgExtendedAttr > So on delete of MOrganisation, OmOrgExtendedAttr is also deleted. There is > no problem in this case. > But problem is on delete of OmOrgExtendedAttr . The error that is coming is > NullPointerException in FrameworkSynchronizer of > isis-objectstore-jdo-datanucleous component for adpater for the POJO. > Please find attached log and also the java files > Could you please help on this issue ASAP. > Thanks > Ranganath -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-368) Parser for java.util.Date should respect the configuration settings.
[ https://issues.apache.org/jira/browse/ISIS-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-368: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Parser for java.util.Date should respect the configuration settings. > > > Key: ISIS-368 > URL: https://issues.apache.org/jira/browse/ISIS-368 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: core-1.1.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-2.0.0 > > > "Putting the isis.value.format.date=dd-MM- in the configuration, my > expectation is that the parser accept a string like "13-03-2013" as a > valid date. I got exception, so I feel I miss something." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-405) Clearer messages for Validation exceptions including field or parameter name and class/action name
[ https://issues.apache.org/jira/browse/ISIS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-405. -- Resolution: Won't Fix Fix Version/s: (was: core-1.7.0) Actually I think this was fixed through some other ticket. But re-open if I'm wrong on that score. > Clearer messages for Validation exceptions including field or parameter name > and class/action name > -- > > Key: ISIS-405 > URL: https://issues.apache.org/jira/browse/ISIS-405 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: core-1.1.0 > Environment: Testing against the 1.0.2 quickstart prototype. >Reporter: Oscar Bou >Assignee: Oscar Bou > > The following exception message is shown when a mandatory field is not > entered (trace shown generated from a JUnit viewer test): > org.apache.isis.progmodel.wrapper.applib.InvalidException: Mandatory > at > org.apache.isis.progmodel.wrapper.metamodel.internal.DomainObjectInvocationHandler.toException(DomainObjectInvocationHandler.java:561) > at > org.apache.isis.progmodel.wrapper.metamodel.internal.DomainObjectInvocationHandler.notifyListenersAndVetoIfRequired(DomainObjectInvocationHandler.java:533) > at > org.apache.isis.progmodel.wrapper.metamodel.internal.DomainObjectInvocationHandler.handleActionMethod(DomainObjectInvocationHandler.java:483) > at > org.apache.isis.progmodel.wrapper.metamodel.internal.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:225) > at > org.apache.isis.progmodel.wrapper.metamodel.internal.InvocationHandlerMethodInterceptor.intercept(InvocationHandlerMethodInterceptor.java:37) > at > com.xms.framework.architecture.domain.model.technology.NodeFactory$$EnhancerByCGLIB$$a0559340.createNode() > at > com.xms.framework.architecture.domain.model.technology.tests.NodeTest.testDomainEntity_CreateWithEmptyString(NodeTest.java:295) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68) > at > org.apache.isis.viewer.junit.IsisTestRunner$1.invoke(IsisTestRunner.java:160) > at > org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:107) > at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:88) > at > org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96) > at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86) > at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49) > at > org.apache.isis.viewer.junit.IsisTestRunner.invokeTestMethod(IsisTestRunner.java:124) > at > org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:61) > at > org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:54) > at > org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:33) > at > org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:45) > at > org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:52) > at > org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) > at > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) > It will be a commonly found exception while testing and debugging. > This exception will be raised , for example, if a programmer forget to > annotate a field, or if he's migrating its source code from another framework > (so by default none of the Domain class properties will be annotated as > @Optional). > Same will happen for non-mandatory parameters on actions placed on Entities > or Services. > A clearer message for Domain Object property validations could be something > similar to this : > "A Mandatory field (%s) has not been entered for an instance of Class: %s." > And for action parameters something similar to: > "A mandatory parameter (%s) has not been entered while executing action '%s' > on an instance
[jira] [Resolved] (ISIS-492) Improve the mandatory validation message for an action parameter
[ https://issues.apache.org/jira/browse/ISIS-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-492. -- Resolution: Won't Fix Actually, I suspect that this fix was applied through some other ticket. Anyway, closing this one. > Improve the mandatory validation message for an action parameter > > > Key: ISIS-492 > URL: https://issues.apache.org/jira/browse/ISIS-492 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: core-1.2.0 >Reporter: Oscar Bou >Assignee: Oscar Bou > > org.apache.isis.applib.services.wrapper.InvalidException: Source: > com.xms.framework.risk.domain.model.RiskAssessment@4ae59431. Reason: > Mandatory. Identifier: > com.xms.framework.risk.domain.model.RiskAssessment#valuateAnEnterpriseArchitectureEntity_Qualitative(com.xms.framework.architecture.domain.model.Entity,com.xms.framework.risk.domain.model.RiskObjective,com.xms.framework.risk.domain.model.ImpactCriterion,com.xms.framework.risk.domain.model.ValuationLevel,java.lang.String). > Position: 3. Proposed: null > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.toException(DomainObjectInvocationHandler.java:584) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.notifyListenersAndVetoIfRequired(DomainObjectInvocationHandler.java:556) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.handleActionMethod(DomainObjectInvocationHandler.java:506) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:236) > at > org.apache.isis.core.wrapper.internal.InvocationHandlerMethodInterceptor.intercept(InvocationHandlerMethodInterceptor.java:37) > at > ... > To > org.apache.isis.applib.services.wrapper.InvalidException: Source: > com.xms.framework.risk.domain.model.RiskAssessment@4ae59431. Reason: > Mandatory. Position: 3. Proposed: null. Identifier: > com.xms.framework.risk.domain.model.RiskAssessment#valuateAnEnterpriseArchitectureEntity_Qualitative(com.xms.framework.architecture.domain.model.Entity,com.xms.framework.risk.domain.model.RiskObjective,com.xms.framework.risk.domain.model.ImpactCriterion,com.xms.framework.risk.domain.model.ValuationLevel,java.lang.String) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-492) Improve the mandatory validation message for an action parameter
[ https://issues.apache.org/jira/browse/ISIS-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-492: - Fix Version/s: (was: core-1.7.0) > Improve the mandatory validation message for an action parameter > > > Key: ISIS-492 > URL: https://issues.apache.org/jira/browse/ISIS-492 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: core-1.2.0 >Reporter: Oscar Bou >Assignee: Oscar Bou > > org.apache.isis.applib.services.wrapper.InvalidException: Source: > com.xms.framework.risk.domain.model.RiskAssessment@4ae59431. Reason: > Mandatory. Identifier: > com.xms.framework.risk.domain.model.RiskAssessment#valuateAnEnterpriseArchitectureEntity_Qualitative(com.xms.framework.architecture.domain.model.Entity,com.xms.framework.risk.domain.model.RiskObjective,com.xms.framework.risk.domain.model.ImpactCriterion,com.xms.framework.risk.domain.model.ValuationLevel,java.lang.String). > Position: 3. Proposed: null > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.toException(DomainObjectInvocationHandler.java:584) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.notifyListenersAndVetoIfRequired(DomainObjectInvocationHandler.java:556) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.handleActionMethod(DomainObjectInvocationHandler.java:506) > at > org.apache.isis.core.wrapper.internal.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:236) > at > org.apache.isis.core.wrapper.internal.InvocationHandlerMethodInterceptor.intercept(InvocationHandlerMethodInterceptor.java:37) > at > ... > To > org.apache.isis.applib.services.wrapper.InvalidException: Source: > com.xms.framework.risk.domain.model.RiskAssessment@4ae59431. Reason: > Mandatory. Position: 3. Proposed: null. Identifier: > com.xms.framework.risk.domain.model.RiskAssessment#valuateAnEnterpriseArchitectureEntity_Qualitative(com.xms.framework.architecture.domain.model.Entity,com.xms.framework.risk.domain.model.RiskObjective,com.xms.framework.risk.domain.model.ImpactCriterion,com.xms.framework.risk.domain.model.ValuationLevel,java.lang.String) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-561) Now we have support for view models, we could simplify matters elsewhere by removing support for transient objects.
[ https://issues.apache.org/jira/browse/ISIS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-561: - Fix Version/s: (was: core-1.7.0) > Now we have support for view models, we could simplify matters elsewhere by > removing support for transient objects. > --- > > Key: ISIS-561 > URL: https://issues.apache.org/jira/browse/ISIS-561 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, > core-1.2.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: viewer-wicket-2.0.0, core-2.0.0 > > > Some discussion is required before going ahead with this. But it'd be nice > to delete a bunch of code... :-) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-515) Pinnable (and persistable) bookmarks
[ https://issues.apache.org/jira/browse/ISIS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-515: - Fix Version/s: (was: viewer-wicket-1.7.0) (was: core-1.7.0) core-2.0.0 > Pinnable (and persistable) bookmarks > > > Key: ISIS-515 > URL: https://issues.apache.org/jira/browse/ISIS-515 > Project: Isis > Issue Type: New Feature > Components: Core, Viewer: Wicket >Affects Versions: viewer-wicket-1.2.0, core-1.2.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: core-2.0.0 > > > This builds on ISIS-471 (pinnable bookmarks for a session). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-563) Implement generic Spec Transformers for BDD tests
[
https://issues.apache.org/jira/browse/ISIS-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-563:
-
Fix Version/s: (was: core-1.7.0)
core-2.0.0
> Implement generic Spec Transformers for BDD tests
> -
>
> Key: ISIS-563
> URL: https://issues.apache.org/jira/browse/ISIS-563
> Project: Isis
> Issue Type: New Feature
> Components: Core
>Reporter: Oscar Bou
>Assignee: Oscar Bou
> Fix For: core-2.0.0
>
>
> If the user follows simple conventions when writing BDD tests, some inference
> can be done from them and a generic Spec Transformer can be used for deriving
> the Entity from the Gherkin's sentence.
> For example, on the following Glue, instead of capturing only the name of the
> employee, we can capture (employee with name \"[^\"]*\"):
> @When("The company's (employee with name \"[^\"]*\") has a role assigned")
> From there we know that:
> - The Domain Entity singular name is "employee", and Isis has the ability to
> derive the singular name form the Entity's class name, or specify it through
> the Isis "@Named" annotation.
> - We must search an Entity of the previous type by name.
> - The name must be equal to PETER.
> As the Domain Entity singular name must be explicitely used, it also
> reinforces the "Ubiquitous Language" on those BDD tests.
> We can admit some variants of the previous case, such as:
> - the employee with name "PETER"
> - the employee named "PETER"
> - the property with reference "REF-001"
> - the property referenced "REF-001"
> - the product with id "PR-001"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-571) To (hopefully) improve performance, use Render.EAGERLY as a hint to instruct JDO to eagerly load the collection (using a dynamic fetch group).
[ https://issues.apache.org/jira/browse/ISIS-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-571: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > To (hopefully) improve performance, use Render.EAGERLY as a hint to instruct > JDO to eagerly load the collection (using a dynamic fetch group). > -- > > Key: ISIS-571 > URL: https://issues.apache.org/jira/browse/ISIS-571 > Project: Isis > Issue Type: New Feature > Components: Core, Core: Objectstore: JDO >Affects Versions: objectstore-jdo-1.1.0, core-1.2.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: core-2.0.0 > > > Information on JDO dynamic fetch groups at > [http://www.datanucleus.org/products/datanucleus/jdo/fetchgroup.html#dynamic] > My thought is that Isis would spin through each of the classes, and look for > those that have any collections annotated EAGERLY. It would then > programmatically define a JDO fetch group for each. > When the object is displayed, Isis would select ONE of these fetch groups and > use it to avoid some of the N+1 issues. > NB: it probably would need to select just one of them, otherwise the > resulting query submitted by DataNucleus would be of the form > SELECT > FROM entity > JOIN child_entity1 ON ... > JOIN child_entity2 ON ... > ie, a rather large amount of data... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-572) To improve performance, support the use of data pinned to caches for entities that are intended to be reference data. For these, infer the ImmutableFacet.
[ https://issues.apache.org/jira/browse/ISIS-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-572: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > To improve performance, support the use of data pinned to caches for entities > that are intended to be reference data. For these, infer the ImmutableFacet. > --- > > Key: ISIS-572 > URL: https://issues.apache.org/jira/browse/ISIS-572 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: objectstore-jdo-1.3.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: core-2.0.0 > > > That is, allow the developer to add the DN extension: > @Extension(vendorName="datanucleus", key="cache-pin", value="true") > as a way to pin any reference data into memory. > If present, we should infer that the entity is immutable (ImmutableFacet). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-724) Support HTML file format as a way of specifying dynamic layout facets (similar to .layout.json files currently)
[ https://issues.apache.org/jira/browse/ISIS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-724: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Support HTML file format as a way of specifying dynamic layout facets > (similar to .layout.json files currently) > --- > > Key: ISIS-724 > URL: https://issues.apache.org/jira/browse/ISIS-724 > Project: Isis > Issue Type: New Feature > Components: Core >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: core-2.0.0 > > > The HTML could have some supporting CSS so that the layout file when viewed > in a browser, would also provide some sort of indication as to the rendered > UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-573) To improve performance, set up caching of query results against any entities that are immutable (ie ref data, ie have ImmutableFacet on them).
[
https://issues.apache.org/jira/browse/ISIS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-573:
-
Fix Version/s: (was: core-1.7.0)
core-2.0.0
> To improve performance, set up caching of query results against any entities
> that are immutable (ie ref data, ie have ImmutableFacet on them).
> --
>
> Key: ISIS-573
> URL: https://issues.apache.org/jira/browse/ISIS-573
> Project: Isis
> Issue Type: New Feature
> Components: Core, Core: Objectstore: JDO
>Affects Versions: objectstore-jdo-1.1.0, core-1.2.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: core-2.0.0
>
>
> In DN, this is done using:
> query.addExtension("datanucleus.query.results.cached", "true");
> query.addExtension("datanucleus.query.resultCache.validateObjects", "false");
> So, need to figure out how to set up these properties on queries by
> repositories of immutable facets. But this could probably be done
> transparently.
> NB: for these cache results to hang around and not get garbage collected,
> would also need to set the global config parm:
> datanucleus.cache.queryResult.type=strong
> ... its default value is weak.
> Further info at:
> http://www.datanucleus.org/products/datanucleus/jdo/query_cache.html#datastoreCompilation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-763) it would be good if service/factory actions (eg Charges#newCharge()) could somehow be rendered alongside the bulk actions for the list of the entity (eg Charges).
[ https://issues.apache.org/jira/browse/ISIS-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-763: - Fix Version/s: (was: viewer-wicket-1.7.0) (was: core-1.7.0) > it would be good if service/factory actions (eg Charges#newCharge()) could > somehow be rendered alongside the bulk actions for the list of the entity (eg > Charges). > --- > > Key: ISIS-763 > URL: https://issues.apache.org/jira/browse/ISIS-763 > Project: Isis > Issue Type: Improvement > Components: Core, Viewer: Wicket >Affects Versions: viewer-wicket-1.4.1, core-1.4.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-763) it would be good if service/factory actions (eg Charges#newCharge()) could somehow be rendered alongside the bulk actions for the list of the entity (eg Charges).
[ https://issues.apache.org/jira/browse/ISIS-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-763. -- Resolution: Won't Fix My enthusiasm for this has waned... > it would be good if service/factory actions (eg Charges#newCharge()) could > somehow be rendered alongside the bulk actions for the list of the entity (eg > Charges). > --- > > Key: ISIS-763 > URL: https://issues.apache.org/jira/browse/ISIS-763 > Project: Isis > Issue Type: Improvement > Components: Core, Viewer: Wicket >Affects Versions: viewer-wicket-1.4.1, core-1.4.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-767) Enable integration and BDD tests to do a lightweight teardown (eg zap contents of tables) rather than tear down entire system.
[ https://issues.apache.org/jira/browse/ISIS-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-767. -- Resolution: Not a Problem Fix Version/s: (was: core-2.0.0) I think this is resolved by fixture scripts etc... see comments on ticket. > Enable integration and BDD tests to do a lightweight teardown (eg zap > contents of tables) rather than tear down entire system. > -- > > Key: ISIS-767 > URL: https://issues.apache.org/jira/browse/ISIS-767 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: core-1.4.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > > Background to this is email from Oscar to dev list: > We have implemented some BDD tests as Scenario Outlines [1]. > But just for one execution, is spending aprox. 15 min in completing a > Scenario Outline with aprox. 20 scenarios. > The problem is that they become really slow, as the whole Isis system is > recreated for each example. > Following best practices, Scenarios should be independent, but I think there > should be ways to guarantee it without sacrificing speed. > - Isis System does not need to be recreated (introspected) for each Scenario, > as the source code has not changed. > - Database can be recreated, or perhaps there's an "abstraction" on > DataNucleus or JDBC to empty a DataStore without re-creating the table > structure from the JDO annotations. > Perhaps are other alternatives to improve their speed that does not require > refactoring the Isis BDD integrations tests implementation? > Regards, > Oscar > [1] > http://jnye.co/Posts/11/repeating-bdd-tests-using-scenario-outlines-and-an-examples-table-with-specflow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-809) Provide implementation of ViewModelFacet that doesn't require explicit implementation of the IViewModel interface.
[ https://issues.apache.org/jira/browse/ISIS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-809: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Provide implementation of ViewModelFacet that doesn't require explicit > implementation of the IViewModel interface. > -- > > Key: ISIS-809 > URL: https://issues.apache.org/jira/browse/ISIS-809 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: core-1.5.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-2.0.0 > > > It ought to be possible just to do this automatically (at least for simple > scalars). That way any non @Persistable pojo will be a view model by default. > (Oscar takes credit for suggesting this). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-767) Enable integration and BDD tests to do a lightweight teardown (eg zap contents of tables) rather than tear down entire system.
[ https://issues.apache.org/jira/browse/ISIS-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-767: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Enable integration and BDD tests to do a lightweight teardown (eg zap > contents of tables) rather than tear down entire system. > -- > > Key: ISIS-767 > URL: https://issues.apache.org/jira/browse/ISIS-767 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: core-1.4.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: core-2.0.0 > > > Background to this is email from Oscar to dev list: > We have implemented some BDD tests as Scenario Outlines [1]. > But just for one execution, is spending aprox. 15 min in completing a > Scenario Outline with aprox. 20 scenarios. > The problem is that they become really slow, as the whole Isis system is > recreated for each example. > Following best practices, Scenarios should be independent, but I think there > should be ways to guarantee it without sacrificing speed. > - Isis System does not need to be recreated (introspected) for each Scenario, > as the source code has not changed. > - Database can be recreated, or perhaps there's an "abstraction" on > DataNucleus or JDBC to empty a DataStore without re-creating the table > structure from the JDO annotations. > Perhaps are other alternatives to improve their speed that does not require > refactoring the Isis BDD integrations tests implementation? > Regards, > Oscar > [1] > http://jnye.co/Posts/11/repeating-bdd-tests-using-scenario-outlines-and-an-examples-table-with-specflow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-814) Provide a better way to handle polymorphic relationships, eg implement a "PolymorphicNavigator service"
[ https://issues.apache.org/jira/browse/ISIS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-814: - Fix Version/s: (was: core-1.7.0) core-2.0.0 > Provide a better way to handle polymorphic relationships, eg implement a > "PolymorphicNavigator service" > --- > > Key: ISIS-814 > URL: https://issues.apache.org/jira/browse/ISIS-814 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: core-1.5.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-2.0.0 > > > We'd like to be able to decouple modules (eg from Estatio or wherever) and > make them reusable for others. > For example, Estatio has "CommunicationChannel", where its owner is of type > CommunicationChannelOwner. We currently use DataNucleus' support for > interface mappings, but (because we use annotations) this requires us to list > the fully qualified class names of the implementations in the > CommunicationChannel; hardly reusable code. > Naked Objects MVC has a service called the PolymorphicNavigator [1], a > mechanism to handle relationships between different Entity Framework > contexts, typically via an interface. > The PolymorphicNavigator requires that all implementations use an int (or > long) as their primary key. It then stores the relationship in a separate > table, qualified by the object type. This is a bit like DataNucleus' > "identity" strategy for mapping interfaces [2], except that: > - two columns are used, not one (for object type, and object PK > - the link is held separately from the rest of the object's data. > [1] > https://github.com/NakedObjectsGroup/NakedObjectsFramework/blob/4e860789ad115a38cd3348ceb5c0b141fb0e0d7b/Programming%20Model/NakedObjects.Helpers/Services/PolymorphicNavigator.cs > [2] http://www.datanucleus.org/products/datanucleus/jdo/orm/interfaces.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-848) Use a single consolidated mechanism for auto-discovery of services, entities and fixture scripts.
[ https://issues.apache.org/jira/browse/ISIS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-848: - Fix Version/s: (was: core-1.7.0) core-1.8.0 > Use a single consolidated mechanism for auto-discovery of services, entities > and fixture scripts. > - > > Key: ISIS-848 > URL: https://issues.apache.org/jira/browse/ISIS-848 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > > Isis core now supports auto-discovery (behind the scenes using > org.reflections.Reflections) of entities, of services and of fixture scripts. > But the configuration of these is all over the place: > - entities are discovered: > - in the app using WEB-INF/persistor_datanucleus.properties > - in the integtests in the XxxSystemBuilder#testConfiguration() > - services are discovered: >- in the app using WEB-INF/isis.properties >- in the integtests in the XxxSystemBuilder#(constructor) > - fixture scripts are discovered: > - in the app in the constructor of the subclass of FixtureScripts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-847) RegisterEntities isn't called prior to the metamodel validation, thus we currently rely on priming the metamodel through the services... not good.
[ https://issues.apache.org/jira/browse/ISIS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-847: - Fix Version/s: (was: core-1.7.0) core-1.8.0 > RegisterEntities isn't called prior to the metamodel validation, thus we > currently rely on priming the metamodel through the services... not good. > -- > > Key: ISIS-847 > URL: https://issues.apache.org/jira/browse/ISIS-847 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-867) Domain service (probably in isisaddons) to automatically maintain lastUpdatedAt and lastUpdatedBy on any entity.
[
https://issues.apache.org/jira/browse/ISIS-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-867:
-
Fix Version/s: (was: core-1.7.0)
core-2.0.0
> Domain service (probably in isisaddons) to automatically maintain
> lastUpdatedAt and lastUpdatedBy on any entity.
>
>
> Key: ISIS-867
> URL: https://issues.apache.org/jira/browse/ISIS-867
> Project: Isis
> Issue Type: New Feature
> Components: Add-ons
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: core-2.0.0
>
>
> using ISIS-865.
> Define:
> interface Updateable {
> @Programmatic
> public void updatedBy(String userName);
> @Programmatic
> publc void updatedAt(DateTime dt);
> }
> Install a JDO StoreLifecycleListener on the PersistenceManager when request
> starts, call in preStore.
> Should double-check plays well with auditing service. (Should be ok, since
> even if this listener and Isis' global listener are called in indeterminate
> order, even then we only hit the auditing service just prior to committing
> the transaction. Until that point we are just capturing the fact that
> entities have been enlisted in the xactn).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-867) Domain service (probably in isisaddons) to automatically maintain lastUpdatedAt and lastUpdatedBy on any entity.
[
https://issues.apache.org/jira/browse/ISIS-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-867:
-
Component/s: (was: Core)
Add-ons
> Domain service (probably in isisaddons) to automatically maintain
> lastUpdatedAt and lastUpdatedBy on any entity.
>
>
> Key: ISIS-867
> URL: https://issues.apache.org/jira/browse/ISIS-867
> Project: Isis
> Issue Type: New Feature
> Components: Add-ons
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: core-2.0.0
>
>
> using ISIS-865.
> Define:
> interface Updateable {
> @Programmatic
> public void updatedBy(String userName);
> @Programmatic
> publc void updatedAt(DateTime dt);
> }
> Install a JDO StoreLifecycleListener on the PersistenceManager when request
> starts, call in preStore.
> Should double-check plays well with auditing service. (Should be ok, since
> even if this listener and Isis' global listener are called in indeterminate
> order, even then we only hit the auditing service just prior to committing
> the transaction. Until that point we are just capturing the fact that
> entities have been enlisted in the xactn).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-868) Domain service (probably isisaddons) to provide a toggle service (wrap togglz)
[ https://issues.apache.org/jira/browse/ISIS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-868: - Component/s: (was: Core) Add-ons > Domain service (probably isisaddons) to provide a toggle service (wrap togglz) > -- > > Key: ISIS-868 > URL: https://issues.apache.org/jira/browse/ISIS-868 > Project: Isis > Issue Type: New Feature > Components: Add-ons >Affects Versions: core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > > http://www.togglz.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-869) Domain service (probably isisaddons) to wrap HttpSession.
[ https://issues.apache.org/jira/browse/ISIS-869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-869: - Component/s: (was: Core) Add-ons > Domain service (probably isisaddons) to wrap HttpSession. > - > > Key: ISIS-869 > URL: https://issues.apache.org/jira/browse/ISIS-869 > Project: Isis > Issue Type: New Feature > Components: Add-ons >Affects Versions: core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.7.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-868) Domain service (probably isisaddons) to provide a toggle service (wrap togglz)
[ https://issues.apache.org/jira/browse/ISIS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-868: - Fix Version/s: (was: core-1.7.0) core-1.8.0 > Domain service (probably isisaddons) to provide a toggle service (wrap togglz) > -- > > Key: ISIS-868 > URL: https://issues.apache.org/jira/browse/ISIS-868 > Project: Isis > Issue Type: New Feature > Components: Add-ons >Affects Versions: core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > > http://www.togglz.org/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-870) Settings service (isisaddons) should support obfuscate passwords.
[ https://issues.apache.org/jira/browse/ISIS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-870: - Summary: Settings service (isisaddons) should support obfuscate passwords. (was: Settings service (isisaddons) should support obfuscate passwords. This will require some support from Core.) > Settings service (isisaddons) should support obfuscate passwords. > - > > Key: ISIS-870 > URL: https://issues.apache.org/jira/browse/ISIS-870 > Project: Isis > Issue Type: New Feature > Components: Add-ons: Module: Settings >Affects Versions: viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-870) Settings service (isisaddons) should support obfuscate passwords.
[ https://issues.apache.org/jira/browse/ISIS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-870: - Fix Version/s: (was: viewer-wicket-1.7.0) (was: core-1.7.0) core-1.8.0 > Settings service (isisaddons) should support obfuscate passwords. > - > > Key: ISIS-870 > URL: https://issues.apache.org/jira/browse/ISIS-870 > Project: Isis > Issue Type: New Feature > Components: Add-ons: Module: Settings >Affects Versions: viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: core-1.8.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-870) Settings service (isisaddons) should support obfuscare passwords. This will require some support from Core.
[ https://issues.apache.org/jira/browse/ISIS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-870: - Component/s: (was: Core) (was: Viewer: Wicket) Add-ons: Module: Settings > Settings service (isisaddons) should support obfuscare passwords. This will > require some support from Core. > > > Key: ISIS-870 > URL: https://issues.apache.org/jira/browse/ISIS-870 > Project: Isis > Issue Type: New Feature > Components: Add-ons: Module: Settings >Affects Versions: viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0, core-1.7.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-870) Settings service (isisaddons) should support obfuscate passwords. This will require some support from Core.
[ https://issues.apache.org/jira/browse/ISIS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-870: - Summary: Settings service (isisaddons) should support obfuscate passwords. This will require some support from Core. (was: Settings service (isisaddons) should support obfuscare passwords. This will require some support from Core.) > Settings service (isisaddons) should support obfuscate passwords. This will > require some support from Core. > > > Key: ISIS-870 > URL: https://issues.apache.org/jira/browse/ISIS-870 > Project: Isis > Issue Type: New Feature > Components: Add-ons: Module: Settings >Affects Versions: viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0, core-1.7.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-879) ObjectMemberAbstract#isAlwaysHidden() does not honour where=Where.EVERYWHERE.
[
https://issues.apache.org/jira/browse/ISIS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-879.
--
Resolution: Fixed
> ObjectMemberAbstract#isAlwaysHidden() does not honour where=Where.EVERYWHERE.
> -
>
> Key: ISIS-879
> URL: https://issues.apache.org/jira/browse/ISIS-879
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: core-1.7.0
>
>
> in ApplicationFeatures
> protected boolean isHidden(ObjectSpecification spec) {
> final HiddenFacet facet = spec.getFacet(HiddenFacet.class);
> return facet != null &&
> !facet.isNoop() &&
> (facet.where() == Where.EVERYWHERE || facet.where() ==
> Where.ANYWHERE) &&
> facet.when() == When.ALWAYS;
> }
>
> in ObjectMemberAbstract
> @Override
> public boolean isAlwaysHidden() {
> final HiddenFacet hiddenFacet = getFacet(HiddenFacet.class);
> return hiddenFacet != null && hiddenFacet.when() == When.ALWAYS &&
> hiddenFacet.where() == Where.ANYWHERE;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-879) ObjectMemberAbstract#isAlwaysHidden() does not honour where=Where.EVERYWHERE.
[
https://issues.apache.org/jira/browse/ISIS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131483#comment-14131483
]
ASF subversion and git services commented on ISIS-879:
--
Commit ad8f8a82c93fe877d5b01aedd27d3ce42bd0 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ad8f8a8 ]
ISIS-879: fix for ObjectMemberAbstract#isAlwaysHidden
... wasn't handling no-op facets nor dealing with fact that Where.ANYWHERE and
Where.EVERYWHERE are meant to be synonyms.
> ObjectMemberAbstract#isAlwaysHidden() does not honour where=Where.EVERYWHERE.
> -
>
> Key: ISIS-879
> URL: https://issues.apache.org/jira/browse/ISIS-879
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: core-1.7.0
>
>
> in ApplicationFeatures
> protected boolean isHidden(ObjectSpecification spec) {
> final HiddenFacet facet = spec.getFacet(HiddenFacet.class);
> return facet != null &&
> !facet.isNoop() &&
> (facet.where() == Where.EVERYWHERE || facet.where() ==
> Where.ANYWHERE) &&
> facet.when() == When.ALWAYS;
> }
>
> in ObjectMemberAbstract
> @Override
> public boolean isAlwaysHidden() {
> final HiddenFacet hiddenFacet = getFacet(HiddenFacet.class);
> return hiddenFacet != null && hiddenFacet.when() == When.ALWAYS &&
> hiddenFacet.where() == Where.ANYWHERE;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-815) Internationalization of Wicket UI elements (edit, ok, cancel, logout, about)
[ https://issues.apache.org/jira/browse/ISIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131482#comment-14131482 ] Dan Haywood commented on ISIS-815: -- Thanks for doing this investigation. Given we have all this on logged here, for now I've chosen to leave the code as it is. > Internationalization of Wicket UI elements (edit, ok, cancel, logout, about) > > > Key: ISIS-815 > URL: https://issues.apache.org/jira/browse/ISIS-815 > Project: Isis > Issue Type: Improvement > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.5.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.6.0 > > > Using Wicket's built-in i18n capabilities, but tweaked so that > application-scoped properties override page-scope properties (rather than > other way around) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-794) Upgrade to Wicket 6.16.0, remove CharSequenceResource
[ https://issues.apache.org/jira/browse/ISIS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-794. -- Resolution: Fixed > Upgrade to Wicket 6.16.0, remove CharSequenceResource > - > > Key: ISIS-794 > URL: https://issues.apache.org/jira/browse/ISIS-794 > Project: Isis > Issue Type: Dependency upgrade > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.4.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > > Per ISIS-788 and WICKET-5600. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-889) Action prompt dialog seems to be not quite big enough in Chrome (is ok in Firefox and IEv11)
[ https://issues.apache.org/jira/browse/ISIS-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-889. -- Resolution: Fixed > Action prompt dialog seems to be not quite big enough in Chrome (is ok in > Firefox and IEv11) > > > Key: ISIS-889 > URL: https://issues.apache.org/jira/browse/ISIS-889 > Project: Isis > Issue Type: Improvement > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > Attachments: isis-todo-raise.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-872) 1.7.0 release activities
[ https://issues.apache.org/jira/browse/ISIS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131469#comment-14131469 ] ASF subversion and git services commented on ISIS-872: -- Commit c1c0d534b95d9d1dbe3b2aa87d59ffbf9bb61df4 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c1c0d53 ] ISIS-872: Merge remote-tracking branch 'michalbcz/master' * michalbcz/master: fixed broken link Conflicts: README.md > 1.7.0 release activities > > > Key: ISIS-872 > URL: https://issues.apache.org/jira/browse/ISIS-872 > Project: Isis > Issue Type: Task > Components: Archetype: Simple WRJ, Archetype: ToDoApp WRJ, Core, > Viewer: Wicket >Affects Versions: archetype-simpleapp-1.6.0, archetype-todoapp-1.6.0, > viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: archetype-todoapp-1.7.0, archetype-simpleapp-1.7.0, > viewer-wicket-1.7.0, core-1.7.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-794) Upgrade to Wicket 6.16.0, remove CharSequenceResource
[ https://issues.apache.org/jira/browse/ISIS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131470#comment-14131470 ] ASF subversion and git services commented on ISIS-794: -- Commit fb62c47fe775ce7a7c152c3e85cbe97912297757 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fb62c47 ] ISIS-794: upgraded to Wicket 6.17.0, removed CharSequenceResource and using Wicket's equivalent instead. > Upgrade to Wicket 6.16.0, remove CharSequenceResource > - > > Key: ISIS-794 > URL: https://issues.apache.org/jira/browse/ISIS-794 > Project: Isis > Issue Type: Dependency upgrade > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.4.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > > Per ISIS-788 and WICKET-5600. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-889) Action prompt dialog seems to be not quite big enough in Chrome (is ok in Firefox and IEv11)
[ https://issues.apache.org/jira/browse/ISIS-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131468#comment-14131468 ] ASF subversion and git services commented on ISIS-889: -- Commit df841459e777927ea0676429e6896f7bbb55089e in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=df84145 ] ISIS-889: tweaked the javascript to adjust margin. The action prompt dialog is *meant to* be sized through our call to Wicket.Window.get().autoSizeWindow(). However, it seems not to size correctly on Chrome. I noticed though that manually adjusting the margin on one of the aciton panel's container element down by a pixel sorted out the issue. So this is pretty hacky, but I've added in a patch to the javascript that calls ww.autoSizeWindow(), to manually change the CSS by 1 pixel. Seems to do the job, and unnoticeable on Firefox. > Action prompt dialog seems to be not quite big enough in Chrome (is ok in > Firefox and IEv11) > > > Key: ISIS-889 > URL: https://issues.apache.org/jira/browse/ISIS-889 > Project: Isis > Issue Type: Improvement > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > Attachments: isis-todo-raise.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-794) Upgrade to Wicket 6.16.0, remove CharSequenceResource
[ https://issues.apache.org/jira/browse/ISIS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-794: - Summary: Upgrade to Wicket 6.16.0, remove CharSequenceResource (was: Upgrade to Wicket 6.16.0, remove CharArrayResourceStream.) > Upgrade to Wicket 6.16.0, remove CharSequenceResource > - > > Key: ISIS-794 > URL: https://issues.apache.org/jira/browse/ISIS-794 > Project: Isis > Issue Type: Dependency upgrade > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.4.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > > Per ISIS-788 and WICKET-5600. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-889) Action prompt dialog seems to be not quite big enough in Chrome (is ok in Firefox and IEv11)
[ https://issues.apache.org/jira/browse/ISIS-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-889: - Component/s: Viewer: Wicket > Action prompt dialog seems to be not quite big enough in Chrome (is ok in > Firefox and IEv11) > > > Key: ISIS-889 > URL: https://issues.apache.org/jira/browse/ISIS-889 > Project: Isis > Issue Type: Improvement > Components: Viewer: Wicket >Affects Versions: viewer-wicket-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: viewer-wicket-1.7.0 > > Attachments: isis-todo-raise.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-872) 1.7.0 release activities
[ https://issues.apache.org/jira/browse/ISIS-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131342#comment-14131342 ] ASF subversion and git services commented on ISIS-872: -- Commit 0b52e7ae631d03e37c18cd5290347790a7a35478 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0b52e7a ] ISIS-872: Merge remote-tracking branch 'martin-g/minor-improvements' * martin-g/minor-improvements: Minor non-functional fixes: > 1.7.0 release activities > > > Key: ISIS-872 > URL: https://issues.apache.org/jira/browse/ISIS-872 > Project: Isis > Issue Type: Task > Components: Archetype: Simple WRJ, Archetype: ToDoApp WRJ, Core, > Viewer: Wicket >Affects Versions: archetype-simpleapp-1.6.0, archetype-todoapp-1.6.0, > viewer-wicket-1.6.0, core-1.6.0 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: archetype-todoapp-1.7.0, archetype-simpleapp-1.7.0, > viewer-wicket-1.7.0, core-1.7.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-880) Appearance of Password field (in action dialogs) requires tweaking.
[
https://issues.apache.org/jira/browse/ISIS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131320#comment-14131320
]
Dan Haywood commented on ISIS-880:
--
see also this documentation:
http://isis.apache.org/more-advanced-topics/how-to-04-015-Password-properties-and-params.html
> Appearance of Password field (in action dialogs) requires tweaking.
> ---
>
> Key: ISIS-880
> URL: https://issues.apache.org/jira/browse/ISIS-880
> Project: Isis
> Issue Type: Bug
> Components: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: viewer-wicket-1.7.0
>
>
> .isisPasswordPanel input[type=password] {
> border-radius:4px;
> -moz-border-radius:4px;
> -webkit-border-radius:4px;
> padding:6px;
> border:1px solid #F0EFEA;
> border-top:1px solid #CCCBC7;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ISIS-880) Appearance of Password field (in action dialogs) requires tweaking.
[
https://issues.apache.org/jira/browse/ISIS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-880.
--
Resolution: Fixed
> Appearance of Password field (in action dialogs) requires tweaking.
> ---
>
> Key: ISIS-880
> URL: https://issues.apache.org/jira/browse/ISIS-880
> Project: Isis
> Issue Type: Bug
> Components: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: viewer-wicket-1.7.0
>
>
> .isisPasswordPanel input[type=password] {
> border-radius:4px;
> -moz-border-radius:4px;
> -webkit-border-radius:4px;
> padding:6px;
> border:1px solid #F0EFEA;
> border-top:1px solid #CCCBC7;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-880) Appearance of Password field (in action dialogs) requires tweaking.
[
https://issues.apache.org/jira/browse/ISIS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131257#comment-14131257
]
ASF subversion and git services commented on ISIS-880:
--
Commit 3702236b1f5cc9a39ca6a9d943851a69f3f26bab in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3702236 ]
ISIS-880: fix appearance (and minor behavioural fix) for password fields.
> Appearance of Password field (in action dialogs) requires tweaking.
> ---
>
> Key: ISIS-880
> URL: https://issues.apache.org/jira/browse/ISIS-880
> Project: Isis
> Issue Type: Bug
> Components: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: viewer-wicket-1.7.0
>
>
> .isisPasswordPanel input[type=password] {
> border-radius:4px;
> -moz-border-radius:4px;
> -webkit-border-radius:4px;
> padding:6px;
> border:1px solid #F0EFEA;
> border-top:1px solid #CCCBC7;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ISIS-871) NPE - ActionInvocationFacetForInteractionAbstract passes Null to "ObjectSpecification.isViewModelCloneable"
[ https://issues.apache.org/jira/browse/ISIS-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-871. -- Resolution: Fixed Fix Version/s: core-1.7.0 > NPE - ActionInvocationFacetForInteractionAbstract passes Null to > "ObjectSpecification.isViewModelCloneable" > --- > > Key: ISIS-871 > URL: https://issues.apache.org/jira/browse/ISIS-871 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: core-1.6.0 >Reporter: Oscar Bou >Assignee: Dan Haywood > Fix For: core-1.7.0 > > Attachments: patch_ISIS-871.diff > > > As it passes a null value, a NPE is thrown afterwards (the ObjectAdapter is > null). > See attached patch file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-808) To reduce security permissioning setup, assume read-only access to all properties and collections if user's role have read-only permissions at the class level.
[ https://issues.apache.org/jira/browse/ISIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-808. -- Resolution: Won't Fix Fix Version/s: (was: core-1.7.0) We now have the isis-module-security module in isisaddons [1], which provides much more sophisticated and elegant permissioning setup. [1] http://github.com/isisaddons/isis-module-security > To reduce security permissioning setup, assume read-only access to all > properties and collections if user's role have read-only permissions at the > class level. > --- > > Key: ISIS-808 > URL: https://issues.apache.org/jira/browse/ISIS-808 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: security-shiro-1.5.0, core-1.5.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > > Not exactly sure what this implies, possibly a refactoring in either core or > the shiro security integration in terms of inferring permissions for > properties. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-893) (Cosmetics): If attempt to invoke non-existent action, get nasty error message
Dan Haywood created ISIS-893: Summary: (Cosmetics): If attempt to invoke non-existent action, get nasty error message Key: ISIS-893 URL: https://issues.apache.org/jira/browse/ISIS-893 Project: Isis Issue Type: Improvement Components: Core, Viewer: Wicket Affects Versions: core-1.6.0, viewer-wicket-1.6.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.7.0, core-1.7.0 see the actionId="fooBar" diverted to error page with following stack trace: 15:59:41,112 [RequestCycleExtra577739874@qtp-1148559558-0 WARN ] Handling the following exception org.apache.wicket.WicketRuntimeException: Can't instantiate page using constructor 'public org.apache.isis.viewer.wicket.ui.pages.actionprompt.ActionPromptPage(org.apache.wicket.request.mapper.parameter.PageParameters)' and argument 'actionArgs=[abc], actionArgs=[Professional], actionArgs=[$nullArg$], actionArgs=[20140925], actionArgs=[$nullArg$], objectOid=[dom.todo.ToDoItems:1], actionOwningSpec=[dom.todo.ToDoItems], actionId=[fooBar(java.lang.String,dom.todo.ToDoItem$Category,dom.todo.ToDoItem$Subcategory,org.joda.time.LocalDate,java.math.BigDecimal)], actionType=[USER]'. An exception has been thrown during construction! at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:194) at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:99) at org.apache.wicket.DefaultMapperContext.newPageInstance(DefaultMapperContext.java:137) at org.apache.wicket.core.request.handler.PageProvider.resolvePageInstance(PageProvider.java:268) at org.apache.wicket.core.request.handler.PageProvider.getPageInstance(PageProvider.java:166) at org.apache.wicket.request.handler.render.PageRenderer.getPage(PageRenderer.java:78) at org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:100) at org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:221) at org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:175) at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:862) at org.apache.wicket.request.RequestHandlerStack.execute(RequestHandlerStack.java:64) at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:261) at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:218) at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:289) at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:259) at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:201) at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:282) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.isis.core.webapp.diagnostics.IsisLogOnExceptionFilter.doFilter(IsisLogOnExceptionFilter.java:52) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.shiro.web.servlet.AbstractShiroFilter.executeChain(AbstractShiroFilter.java:449) at org.apache.shiro.web.servlet.AbstractShiroFilter$1.call(AbstractShiroFilter.java:365) at org.apache.shiro.subject.support.SubjectCallable.doCall(SubjectCallable.java:90) at org.apache.shiro.subject.support.SubjectCallable.call(SubjectCallable.java:83) at org.apache.shiro.subject.support.DelegatingSubject.execute(DelegatingSubject.java:383) at org.apache.shiro.web.servlet.AbstractShiroFilter.doFilterInternal(AbstractShiroFilter.java:362) at org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928) at org.mortbay.jetty.HttpParser.par
