[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438228#comment-16438228
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 6f90a9bb41841fb868f66091ca45341ce7b6648a in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6f90a9b ]

ISIS-1742 polishing java-doc

also renaming Memento.set() to Memento.put() to emphasize similarity
with Maps

> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437900#comment-16437900
 ] 

Andi Huber commented on ISIS-1909:
--

Deprecated +MementoService+ was removed.

Mementos are Internal API now:
{noformat}
org.apache.isis.applib.internal.memento._Mementos{noformat}
Deprecated +DomainObjectContainer+ was removed.

 

> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437889#comment-16437889
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 66b4e3ef4b62f6da6f0ef176e046c6105bd49395 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=66b4e3e ]

ISIS-1742 fixes naive memento re-implementation in Internal API

Extends BookmarkServiceInternalDefault to also support the new
SerializingAdapter interface required for proper ViewModel
serialization.

> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437888#comment-16437888
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit df3691253eca0c64bec67840958a8c599c326a34 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=df36912 ]

ISIS-1742 removing temporary addition to FactoryService

> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437161#comment-16437161
 ] 

Andi Huber commented on ISIS-1909:
--

UrlEncodingServiceWithCompression is the new default, it replaces 
UrlEncodingServiceUsingBaseEncoding.

> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437158#comment-16437158
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit ce7ddb7ee9b8545a2361c83948b386273854c646 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ce7ddb7 ]

ISIS-1742 make UrlEncodingServiceWithCompression the new default

> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437145#comment-16437145
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit 93a8c63590415167efbf963773b3f4adb21b9517 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=93a8c63 ]

ISIS-1841 replace Util with Java language idioms

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437143#comment-16437143
 ] 

Andi Huber commented on ISIS-1909:
--

UrlEncodingService changed interface

+BEFORE+
{code:java}
public interface UrlEncodingService {

public String encode(final String str);

public String decode(String str);

}
{code}

+AFTER+
{code:java}
public interface UrlEncodingService {

public String encode(final byte[] bytes);

public byte[] decode(String str);

// same as encode in the old version
public default String encodeString(final String str) {
return encode(_Strings.toBytes(str, StandardCharsets.UTF_8));
}

// same as decode in the old version
public default String decodeToString(final String str) {
return _Strings.ofBytes(decode(str), StandardCharsets.UTF_8);
}

}
{code}


> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1742) Remove deprecated annotations, methods etc.

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437148#comment-16437148
 ] 

ASF subversion and git services commented on ISIS-1742:
---

Commit 22732dbd1c67b025665862047f3e342517d06321 in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=22732db ]

ISIS-1742 moving deprecated MementoService to -legacy

Introduces _Mementos for Internal API.

> Remove deprecated annotations, methods etc.
> ---
>
> Key: ISIS-1742
> URL: https://issues.apache.org/jira/browse/ISIS-1742
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437147#comment-16437147
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit 6db340966420fa09c7cbb627f42c9d6bf0b2a20f in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6db3409 ]

ISIS-1841 further cleanup compiler warnings

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1841) API cleanup + refactoring for version 2

2018-04-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437146#comment-16437146
 ] 

ASF subversion and git services commented on ISIS-1841:
---

Commit af45ccd2707dfaf73e453fb92723e9c50204ee6c in isis's branch 
refs/heads/master from [~hobrom]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=af45ccd ]

ISIS-1841 provide serialVersionUIDs

> API cleanup + refactoring for version 2
> ---
>
> Key: ISIS-1841
> URL: https://issues.apache.org/jira/browse/ISIS-1841
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> add generic type arguments where missing
> reduce number of compiler warnings (enums with missing cases, unchecked 
> casts, vararg type safety, ...)
> reduce duplicate code occurrences (e.g. DeweyOrder Utils, ...)
> reduce occurrences of guava's (Predicate, Function, ...)  interfaces, that 
> have direct Java 8 replacements (at least where easily possible)
> reduce occurrences of deprecated uses



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436922#comment-16436922
 ] 

Andi Huber edited comment on ISIS-1909 at 4/13/18 7:02 AM:
---

MementoService is deprecated, how to migrate:

+BEFORE:+
{code:java}
@javax.inject.Inject
MementoService mementoService;

String mementoFor(final FixtureScript fs) {
   return mementoService.create()
   .set("path", fs.getParentPath())
   .asString();
}

void initOf(final String mementoStr, final FixtureScript fs) {
final Memento memento = mementoService.parse(mementoStr);
fs.setParentPath(memento.get("path", String.class));
}
{code}
+AFTER:+
{code:java}
@javax.inject.Inject
JaxbService jaxbService;

@XmlRootElement(name = "fixtureScript")
public static class FixtureScriptMemento {
private String path;
public String getPath() { return path; }
public void setPath(String path) { this.path = path; }
}

String mementoFor(final FixtureScript fs) {
final FixtureScriptMemento memento = new FixtureScriptMemento();
memento.setPath(fs.getParentPath());
return jaxbService.toXml(memento);
}

void initOf(final String xml, final FixtureScript fs) {
final FixtureScriptMemento memento = 
jaxbService.fromXml(FixtureScriptMemento.class, xml);
fs.setParentPath(memento.getPath());
}
{code}


was (Author: hobrom):
MementoService is deprecated, how to migrate:

+BEFORE:+
{code:java}
@javax.inject.Inject
MementoService mementoService;

String mementoFor(final FixtureScript fs) {
   return mementoService.create()
   .set("path", fs.getParentPath())
   .asString();
}

void initOf(final String mementoStr, final FixtureScript fs) {
final Memento memento = mementoService.parse(mementoStr);
fs.setParentPath(memento.get("path", String.class));
}
{code}
+AFTER:+
{code:java}
@javax.inject.Inject
JaxbService jaxbService;

@XmlRootElement(name = "fixtureScript")
public static class FixtureScriptMemento {
private String path;
public String getPath() { return path; }
public void setPath(String path) { this.path = path; }
}

String mementoFor(final FixtureScript fs) {
final FixtureScriptMemento memento = new FixtureScriptMemento();
memento.setPath(fs.getParentPath());
return jaxbService.toXml(memento);
}
void initOf(final String xml, final FixtureScript fs) {
final FixtureScriptMemento memento = 
jaxbService.fromXml(FixtureScriptMemento.class, xml);
fs.setParentPath(memento.getPath());
}
{code}

> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436922#comment-16436922
 ] 

Andi Huber edited comment on ISIS-1909 at 4/13/18 7:01 AM:
---

MementoService is deprecated, how to migrate:

+BEFORE:+
{code:java}
@javax.inject.Inject
MementoService mementoService;

String mementoFor(final FixtureScript fs) {
   return mementoService.create()
   .set("path", fs.getParentPath())
   .asString();
}

void initOf(final String mementoStr, final FixtureScript fs) {
final Memento memento = mementoService.parse(mementoStr);
fs.setParentPath(memento.get("path", String.class));
}
{code}
+AFTER:+
{code:java}
@javax.inject.Inject
JaxbService jaxbService;

@XmlRootElement(name = "fixtureScript")
public static class FixtureScriptMemento {
private String path;
public String getPath() { return path; }
public void setPath(String path) { this.path = path; }
}

String mementoFor(final FixtureScript fs) {
final FixtureScriptMemento memento = new FixtureScriptMemento();
memento.setPath(fs.getParentPath());
return jaxbService.toXml(memento);
}
void initOf(final String xml, final FixtureScript fs) {
final FixtureScriptMemento memento = 
jaxbService.fromXml(FixtureScriptMemento.class, xml);
fs.setParentPath(memento.getPath());
}
{code}


was (Author: hobrom):
MementoService is deprecated, how to migrate:

+BEFORE:+
{code:java}
@javax.inject.Inject
MementoService mementoService;

String mementoFor(final FixtureScript fs) {
   return mementoService.create()
   .set("path", fs.getParentPath())
   .asString();
}

void initOf(final String mementoStr, final FixtureScript fs) {
final Memento memento = mementoService.parse(mementoStr);
fs.setParentPath(memento.get("path", String.class));
}
{code}
+AFTER:+
{code:java}
@XmlRootElement(name = "fixtureScript")
public static class FixtureScriptMemento {
private String path;
public String getPath() { return path; }
public void setPath(String path) { this.path = path; }
}

String mementoFor(final FixtureScript fs) {
final FixtureScriptMemento memento = new FixtureScriptMemento();
memento.setPath(fs.getParentPath());
return jaxbService.toXml(memento);
}
void initOf(final String xml, final FixtureScript fs) {
final FixtureScriptMemento memento = 
jaxbService.fromXml(FixtureScriptMemento.class, xml);
fs.setParentPath(memento.getPath());
}
{code}

> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1909) Migration Notes: Moved and Deprecated Classes

2018-04-13 Thread Andi Huber (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436922#comment-16436922
 ] 

Andi Huber commented on ISIS-1909:
--

MementoService is deprecated, how to migrate:

+BEFORE:+
{code:java}
@javax.inject.Inject
MementoService mementoService;

String mementoFor(final FixtureScript fs) {
   return mementoService.create()
   .set("path", fs.getParentPath())
   .asString();
}

void initOf(final String mementoStr, final FixtureScript fs) {
final Memento memento = mementoService.parse(mementoStr);
fs.setParentPath(memento.get("path", String.class));
}
{code}
+AFTER:+
{code:java}
@XmlRootElement(name = "fixtureScript")
public static class FixtureScriptMemento {
private String path;
public String getPath() { return path; }
public void setPath(String path) { this.path = path; }
}

String mementoFor(final FixtureScript fs) {
final FixtureScriptMemento memento = new FixtureScriptMemento();
memento.setPath(fs.getParentPath());
return jaxbService.toXml(memento);
}
void initOf(final String xml, final FixtureScript fs) {
final FixtureScriptMemento memento = 
jaxbService.fromXml(FixtureScriptMemento.class, xml);
fs.setParentPath(memento.getPath());
}
{code}

> Migration Notes: Moved and Deprecated Classes
> -
>
> Key: ISIS-1909
> URL: https://issues.apache.org/jira/browse/ISIS-1909
> Project: Isis
>  Issue Type: Sub-task
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> +Removed+
>  * IsisJdoSupport (replaced by API specific variants)
>  * Annotation Parseable removed
>  * Annotation Encodable removed
>  * ...
> +Moved+
> FROM
>  org/apache/isis/applib/services/eventbus/*
> TO
>  org/apache/isis/applib/events/domain/AbstractDomainEvent
>  org/apache/isis/applib/events/domain/ActionDomainEvent
>  org/apache/isis/applib/events/domain/CollectionDomainEvent
>  org/apache/isis/applib/events/domain/PropertyDomainEvent
>  org/apache/isis/applib/events/lifecycle/AbstractLifecycleEvent
>  org/apache/isis/applib/events/lifecycle/ObjectCreatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectLoadedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectPersistingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectRemovingEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatedEvent
>  org/apache/isis/applib/events/lifecycle/ObjectUpdatingEvent
>  org/apache/isis/applib/events/ui/AbstractUiEvent
>  org/apache/isis/applib/events/ui/CssClassUiEvent
>  org/apache/isis/applib/events/ui/IconUiEvent
>  org/apache/isis/applib/events/ui/TitleUiEvent
> +ISIS-1599+
> Meta-Data validation will now fail if a collection action parameter is found 
> that is not exactly one of the following supported types: List, Set, 
> SortedSet, Collection or Array.
> +In case we ship the legacy build (unlikely) ...+
> to ease transition from 1.x to 2.0 we introduced legacy variants as drop-in 
> replacements
> - RepositoryService -> RepositoryServiceLegacy
> - ExceptionRecognizerAbstract -> ExceptionRecognizerAbstractLegacy
> - ExceptionRecognizerForType -> ExceptionRecognizerForTypeLegacy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)