[jira] [Created] (ISIS-2313) Do not depend on 2 versions of javax.jdo simultaneously

2020-03-19 Thread Andi Huber (Jira)
Andi Huber created ISIS-2313:


 Summary: Do not depend on 2 versions of javax.jdo simultaneously
 Key: ISIS-2313
 URL: https://issues.apache.org/jira/browse/ISIS-2313
 Project: Isis
  Issue Type: Bug
  Components: Isis Persistence JDO
Affects Versions: 2.0.0-M3
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M4


Remove all references to API version 3.1,
otherwise DN enhancer will see versions 3.1 and 3.2-m? on the class path.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Apache Isis release 2.0.0-M3 RC2

2020-03-19 Thread Andi Huber

~$ mvn -v
Apache Maven 3.6.0
Maven home: /usr/share/maven
Java version: 11.0.6, vendor: Debian, runtime: 
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-18362-microsoft", arch: "amd64", family: 
"unix"

For the build we recommend using JDK-8 or JDK-11 with maven 3.6.x.

+1

Cheers, Andi

On 19.03.2020 19:54, Dan Haywood wrote:

Following on from our previous attempt [1], I've just cut RC2 for the
v2.0.0-M3
release of the Apache Isis Framework.

The source code zip artifact has been uploaded to a staging repository on
https://repository.apache.org, along with its corresponding .asc signature.

In the source code repo the code has been tagged as isis-2.0.0-M3-RC2;
see https://github.com/apache/isis/tags

To verify the source code itself, you can use the following commands
(in an empty directory):

--
VERSION=2.0.0-M3
RC=RC2
NEXUSREPONUM=1104

curl https://downloads.apache.org/isis/KEYS > /tmp/KEYS
gpg --import /tmp/KEYS

rm -rf isis-$VERSION*

curl -O -L
https://raw.githubusercontent.com/apache/isis/release-$VERSION-$RC/scripts/verify-isis-release.sh

chmod +x ./verify-isis-release.sh
./verify-isis-release.sh $NEXUSREPONUM $VERSION $RC
--

You can then test the helloworld or simpleapp starter apps, see:
https://isis.staged.apache.org/comguide/latest/verifying-releases.html.

You can also inspect the website in general, available at:
https://isis.staged.apache.org.

Please verify the release and cast your vote.
The vote will be open for a minimum of 72 hours.

[ ] +1
[ ]  0
[ ] -1


[1]
https://lists.apache.org/thread.html/r276f64a4d1edc02418eb53f6800561ca487f5f34a5a73eecaaa81dcb%40%3Cdev.isis.apache.org%3E



[VOTE] Apache Isis release 2.0.0-M3 RC2

2020-03-19 Thread Dan Haywood
Following on from our previous attempt [1], I've just cut RC2 for the
v2.0.0-M3
release of the Apache Isis Framework.

The source code zip artifact has been uploaded to a staging repository on
https://repository.apache.org, along with its corresponding .asc signature.

In the source code repo the code has been tagged as isis-2.0.0-M3-RC2;
see https://github.com/apache/isis/tags

To verify the source code itself, you can use the following commands
(in an empty directory):

--
VERSION=2.0.0-M3
RC=RC2
NEXUSREPONUM=1104

curl https://downloads.apache.org/isis/KEYS > /tmp/KEYS
gpg --import /tmp/KEYS

rm -rf isis-$VERSION*

curl -O -L
https://raw.githubusercontent.com/apache/isis/release-$VERSION-$RC/scripts/verify-isis-release.sh

chmod +x ./verify-isis-release.sh
./verify-isis-release.sh $NEXUSREPONUM $VERSION $RC
--

You can then test the helloworld or simpleapp starter apps, see:
https://isis.staged.apache.org/comguide/latest/verifying-releases.html.

You can also inspect the website in general, available at:
https://isis.staged.apache.org.

Please verify the release and cast your vote.
The vote will be open for a minimum of 72 hours.

[ ] +1
[ ]  0
[ ] -1


[1]
https://lists.apache.org/thread.html/r276f64a4d1edc02418eb53f6800561ca487f5f34a5a73eecaaa81dcb%40%3Cdev.isis.apache.org%3E


[jira] [Updated] (ISIS-1735) Bind action with property/collection by naming convention.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1735:
--
Priority: Minor  (was: Major)

> Bind action with property/collection by naming convention.
> --
>
> Key: ISIS-1735
> URL: https://issues.apache.org/jira/browse/ISIS-1735
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model), Isis Core
>Affects Versions: 1.15.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1388) Introduce @PropertyLayout(columnOrder=...) to make order of properties (when shown in tables) more predictable.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1388:
--
Priority: Minor  (was: Major)

> Introduce @PropertyLayout(columnOrder=...) to make order of properties (when 
> shown in tables) more predictable.  
> -
>
> Key: ISIS-1388
> URL: https://issues.apache.org/jira/browse/ISIS-1388
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.12.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> At the moment it can be hard to predict, because the BS3Grid is traversed by 
> type, eg:
> {code}
> private void traverseCols(final Grid.Visitor visitor, final BS3Row 
> bs3Row) {
> final BS3Grid.Visitor bs3Visitor = asBs3Visitor(visitor);
> final List cols = bs3Row.getCols();
> for (BS3RowContent rowContent : Lists.newArrayList(cols)) {
> rowContent.setOwner(bs3Row);
> if(rowContent instanceof BS3Col) {
> final BS3Col bs3Col = (BS3Col) rowContent;
> bs3Visitor.preVisit(bs3Col);
> bs3Visitor.visit(bs3Col);
> traverseDomainObject(bs3Col, visitor);
> traverseTabGroups(bs3Col, visitor);
> traverseActions(bs3Col, visitor);
> traverseFieldSets(bs3Col, visitor);
> traverseCollections(bs3Col, visitor);
> traverseRows(bs3Col, visitor);
> bs3Visitor.postVisit(bs3Col);
> } else if (rowContent instanceof BS3ClearFix) {
> final BS3ClearFix bs3ClearFix = (BS3ClearFix) rowContent;
> bs3Visitor.visit(bs3ClearFix);
> } else {
> throw new IllegalStateException(
> "Unrecognized implementation of BS3RowContent, " + 
> rowContent);
> }
> }
> }
> {code}
> Instead, if it were traversed by element order, then the ordering of 
> properties would be more predictable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1286) Extend the RoutingService to provide more information, eg a context

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1286:
--
Priority: Minor  (was: Major)

> Extend the RoutingService to provide more information, eg a context
> ---
>
> Key: ISIS-1286
> URL: https://issues.apache.org/jira/browse/ISIS-1286
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model)
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> so is passed a Context object, containing:
> - the object that was invoked on
> - whether this object is now deleted
> - breadcrumb trail of previously visited objects.
> - the home page, if any



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2253) Derive ChoicesFacet from AssociatedWithFacet, remove special-case logic.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2253:
--
Priority: Minor  (was: Major)

> Derive ChoicesFacet from AssociatedWithFacet, remove special-case logic.
> 
>
> Key: ISIS-2253
> URL: https://issues.apache.org/jira/browse/ISIS-2253
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Priority: Minor
>
> In fact, this is a case of two wrongs not quite making a right. There's a 
> nasty hack in that it is the Wicket viewer that knows how to populate the 
> choices for the parameter, and it does this without looking for an 
> autoComplete or choices facet ; it just picks up the checked items of the 
> associated collection.
>  The short term solution to fix DemoApp is just to update that metamodel 
> validator to also take into account any AssociatedWithFacet.
>  The long term "correct" solution is a new facet factory that will derive a 
> ChoicesFacet from the AssociatedWithFacet, and then to remove the special 
> case logic from the Wicket viewer.
> That would then make the validator correct as it is now written.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1316) Using autocomplete more as proposal, and override it with the manually entered one

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1316:
--
Priority: Minor  (was: Major)

> Using autocomplete more as proposal, and override it with the manually 
> entered one
> --
>
> Key: ISIS-1316
> URL: https://issues.apache.org/jira/browse/ISIS-1316
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Reporter: Vladimir Nisevic
>Priority: Minor
>
> Sometimes it would be helpful to use autocomplete more as proposal for final 
> value, so that we still can override the proposal and set the value which is 
> not proposed thru autocomplete.
> Given an e.g. String action paramter A with e.g. MinLength 3
> When user types into field A the value ''
> And the autocomplete on parameter A could show two possible values e.g. 
> 1' and '2'
> And when user decides to use the value he typed '' and not the proposed 
> one
> Then the action parameter A has value ''



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1665) inline prompt for panel action should replace entire panel

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1665:
--
Priority: Minor  (was: Major)

> inline prompt for panel action should replace entire panel
> --
>
> Key: ISIS-1665
> URL: https://issues.apache.org/jira/browse/ISIS-1665
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2000) Display an optional help page in a sidebar, eg on the right.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2000:
--
Fix Version/s: (was: 2.0.5)
 Priority: Minor  (was: Major)

> Display an optional help page in a sidebar, eg on the right.
> 
>
> Key: ISIS-2000
> URL: https://issues.apache.org/jira/browse/ISIS-2000
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> overlap with ISIS-1307



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2016) Slow initial loading - webjars for bootswatch themes?

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2016:
--
Fix Version/s: (was: 2.0.5)

> Slow initial loading - webjars for bootswatch themes?
> -
>
> Key: ISIS-2016
> URL: https://issues.apache.org/jira/browse/ISIS-2016
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Daniel Keir Haywood
>Priority: Major
>
> I thinik we used to use webjars as a cache for bootswatch themes; have we 
> removed them accidentally?  
> https://www.webjars.org/documentation#wicket
> and commented out stuff in web.xml
> {code:xml}
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1973) "republish" mixin - action button is rendered but attempting to invoke throws an exception

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1973:
--
Priority: Minor  (was: Major)

> "republish" mixin - action button is rendered but attempting to invoke throws 
> an exception
> --
>
> Key: ISIS-1973
> URL: https://issues.apache.org/jira/browse/ISIS-1973
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> h2. To reproduce:
>  * login with estatio-user-it, ensure has "estatio-user" role but doesn't 
> have "estatio-superuser" role. 
> - navigate to 
> http://estatiotest.int.prd.ecpnv.com/wicket/entity/org.estatio.dom.invoice.Invoice:106874
> - the "republish" action (contributed from 
> - when invoke, get an exception in the UI, with stack trace below:
>  
> message shown to user:
> Reason: Not authorized to view. Identifier: 
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
> stack trace:
> {code}
> Caused by: org.apache.isis.core.commons.exceptions.IsisApplicationException: 
> org.apache.isis.applib.services.wrapper.HiddenException: Reason: Not 
> authorized to view. Identifier: 
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
>  at 
> org.apache.isis.core.commons.lang.ThrowableExtensions.throwWithinIsisException(ThrowableExtensions.java:55)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:303)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:222)
>  at 
> org.apache.isis.applib.services.iactn.Interaction.executeInternal(Interaction.java:173)
>  at 
> org.apache.isis.applib.services.iactn.Interaction.execute(Interaction.java:143)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.doInvoke(ActionInvocationFacetForDomainEventAbstract.java:310)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$1.execute(ActionInvocationFacetForDomainEventAbstract.java:164)
>  at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:142)
>  at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:132)
>  at 
> org.apache.isis.core.runtime.services.persistsession.PersistenceSessionServiceInternalDefault.executeWithinTransaction(PersistenceSessionServiceInternalDefault.java:192)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.invoke(ActionInvocationFacetForDomainEventAbstract.java:160)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeInternal(ObjectActionDefault.java:400)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionMixedIn.execute(ObjectActionMixedIn.java:230)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeWithRuleChecking(ObjectActionDefault.java:370)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.executeAction(ActionModel.java:460)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:439)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:76)
>  at 
> org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:135)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.execute(ActionModel.java:569)
>  at 
> org.apache.isis.viewer.wicket.ui.components.actions.ActionFormExecutorStrategy.obtainResultAdapter(ActionFormExecutorStrategy.java:71)
>  at 
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.obtainResultAdapter(FormExecutorDefault.java:514)
>  at 
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.executeAndProcessResults(FormExecutorDefault.java:147)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.onClick(ActionLinkFactoryAbstract.java:214)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.access$100(ActionLinkFactoryAbstract.java:71)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract$1.performOnClick(ActionLinkFactoryAbstract.java:147)
>  at 
> 

[jira] [Updated] (ISIS-1990) Buttons (action-links) don't honor disabled state if providing a confirmation dialog

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1990:
--
Priority: Minor  (was: Major)

> Buttons (action-links) don't honor disabled state if providing a confirmation 
> dialog
> 
>
> Key: ISIS-1990
> URL: https://issues.apache.org/jira/browse/ISIS-1990
> Project: Isis
>  Issue Type: Sub-task
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Priority: Minor
> Fix For: 2.0.5
>
> Attachments: confirm_not_auth.png
>
>
> Disabled buttons (action-links) with confirmation dialog do open the dialog 
> on click, but should not. Should instead show a 'no access' tooltip.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1936) FK exception on delete action not rendered to user correctly.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1936:
--
Priority: Minor  (was: Major)

> FK exception on delete action not rendered to user correctly.
> -
>
> Key: ISIS-1936
> URL: https://issues.apache.org/jira/browse/ISIS-1936
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> To reproduce:
>  * for simpleapp, introduce a child entity (not cascade)
>  * delete parent entity to force an FK exception (due to child entities still 
> present)
> this results in a 500 html exception (RestartResponseException).  the FK 
> exception messages are queued and only rendered subsequently.
> (Also, see two exceptions queued, one warning - orange - and one error - red).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1937) NPE when render domain entity for first time that has contributed action on contributed collection.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1937:
--
Priority: Minor  (was: Major)

> NPE when render domain entity for first time that has contributed action on 
> contributed collection.
> ---
>
> Key: ISIS-1937
> URL: https://issues.apache.org/jira/browse/ISIS-1937
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> for example
> [https://github.com/danhaywood/busydevtutorial]
> in Pets.layout.xml, remove the "visits" collection to reproduce.  The 
> contributed Pet_bookVisit action causes the issue because its "owner" is not 
> declared and so returns null.
>  
> {code:java}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.addActionTo(GridSystemServiceBS3.java:661)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:529)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:170)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1968) @Title on a field can result in "Untitled Simple Object" - because DN hasn't always retrieved object

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1968:
--
Priority: Minor  (was: Major)

> @Title on a field can result in "Untitled Simple Object" - because DN hasn't 
> always retrieved object
> 
>
> Key: ISIS-1968
> URL: https://issues.apache.org/jira/browse/ISIS-1968
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> To reproduce, use the simpleapp and remove SimpleObject#title and instead add:
>  
> {code:java}
> @Title(prepend="Object: ")
> private String name;
> {code}
> When edit the name, will see "Untitled Simple Object" on re-rendering



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1989) Disabled buttons (action-links) won't show the styled tooltip

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1989:
--
Priority: Minor  (was: Major)

> Disabled buttons (action-links) won't show the styled tooltip
> -
>
> Key: ISIS-1989
> URL: https://issues.apache.org/jira/browse/ISIS-1989
> Project: Isis
>  Issue Type: Sub-task
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.5
>
> Attachments: no-tooltip.png
>
>
> Disabled buttons (action-links) won't show the styled tooltip, only the 
> browser's built in one.
> jquery select for tooltip() does ignore disabled dom elements



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1922) Session Timeout Indication

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1922:
--
Fix Version/s: (was: 2.0.5)
   2.0.0-M4
 Priority: Major  (was: Minor)

> Session Timeout Indication
> --
>
> Key: ISIS-1922
> URL: https://issues.apache.org/jira/browse/ISIS-1922
> Project: Isis
>  Issue Type: Sub-task
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Eg when a user clicks on a Menu Item, while the session has already timed 
> out, the session silently refreshes and no action is executed.
> From a user's perspective, she/he experiences an application that sometimes 
> is ignoring clicks.
> We should a least show a fade-in/out message to give a user friendly 
> notification, that her/his session was timed out and hence needed to be 
> refreshed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1693) e

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1693:
--
Priority: Minor  (was: Major)
 Summary: e  (was: Possible exception when attempt to render error page 
itself ?)

> e
> -
>
> Key: ISIS-1693
> URL: https://issues.apache.org/jira/browse/ISIS-1693
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
>
> exception when attempt to render ErrorPage itself
> - to reproduce:
>   - open Estatio's home page
>   - copy-n-paste the URL to render in a new tabGroups
>   - on the first page, attempt to invoke the PaymentBatchManager using the 
> button
>   
> {code}
> 07:02:22,506 [RequestCycleExtra ] Handling the following exception
> org.apache.wicket.behavior.InvalidBehaviorIdException: Cannot find behavior 
> with id '0' on component 
> 'org.isisaddons.wicket.pdfjs.cpt.ui.PdfJsViewerPanel:theme:entityPageContainer:entity:rows:1:rowContents:2:col:tabGroups:1:1:rowContents:1:col:fieldSets:1:memberGroup:properties:1:property'
>  in page '[Page class = 
> org.apache.isis.viewer.wicket.ui.pages.entity.EntityPage, id = 20, render 
> count = 0]'. Perhaps the behavior did not properly implement 
> getStatelessHint() and returned 'true' to indicate that it is stateless 
> instead of returning 'false' to indicate that it is stateful.
>   at org.apache.wicket.Behaviors.getBehaviorById(Behaviors.java:316)
>   at org.apache.wicket.Component.getBehaviorById(Component.java:4596)
>   at 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.invokeListener(ListenerInterfaceRequestHandler.java:247)
>   at 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(ListenerInterfaceRequestHandler
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1788) Reduce the number of calls on a dependent choices field

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1788:
--
Priority: Minor  (was: Major)

> Reduce the number of calls on a dependent choices field
> ---
>
> Key: ISIS-1788
> URL: https://issues.apache.org/jira/browse/ISIS-1788
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: 1.15.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> , should only be called when the preceding param changes.
> ref: ECP-396 (editSeller on IncomingDocAsViewModel), in-line prompt.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1864) Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar model properties after action invocation.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1864:
--
Priority: Minor  (was: Major)

> Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar 
> model properties after action invocation.
> ---
>
> Key: ISIS-1864
> URL: https://issues.apache.org/jira/browse/ISIS-1864
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> as per 
> [https://lists.apache.org/thread.html/9924509e3d3e0398e230467d80370e2f9d6dc94641aaa402db56c24e@%3Cusers.isis.apache.org%3E]
>  
> I think that the parent EntityModel shouldnt' really have this responsibility 
> of telling each of its child ScalarModel's to reset themselves. Rather, 
> perhaps it should simply instruct the ScalarModels that they are now dirty, 
> so that if and when the ScalarModels are next asked for their state (for 
> re-rendering) they then will query the underlying domain object ... but not 
> before.
>  
> Also, ScalarModel inherits from EntityModel, but I think that's not correct; 
> should factor out a common supertype for both.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1693) exception when attempt to render ErrorPage itself

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1693:
--
Summary: exception when attempt to render ErrorPage itself  (was: e)

> exception when attempt to render ErrorPage itself
> -
>
> Key: ISIS-1693
> URL: https://issues.apache.org/jira/browse/ISIS-1693
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
>
> exception when attempt to render ErrorPage itself
> - to reproduce:
>   - open Estatio's home page
>   - copy-n-paste the URL to render in a new tabGroups
>   - on the first page, attempt to invoke the PaymentBatchManager using the 
> button
>   
> {code}
> 07:02:22,506 [RequestCycleExtra ] Handling the following exception
> org.apache.wicket.behavior.InvalidBehaviorIdException: Cannot find behavior 
> with id '0' on component 
> 'org.isisaddons.wicket.pdfjs.cpt.ui.PdfJsViewerPanel:theme:entityPageContainer:entity:rows:1:rowContents:2:col:tabGroups:1:1:rowContents:1:col:fieldSets:1:memberGroup:properties:1:property'
>  in page '[Page class = 
> org.apache.isis.viewer.wicket.ui.pages.entity.EntityPage, id = 20, render 
> count = 0]'. Perhaps the behavior did not properly implement 
> getStatelessHint() and returned 'true' to indicate that it is stateless 
> instead of returning 'false' to indicate that it is stateful.
>   at org.apache.wicket.Behaviors.getBehaviorById(Behaviors.java:316)
>   at org.apache.wicket.Component.getBehaviorById(Component.java:4596)
>   at 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.invokeListener(ListenerInterfaceRequestHandler.java:247)
>   at 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler.respond(ListenerInterfaceRequestHandler
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2058) Pre-render home page to avoid wait when first hit webapp after bootstrapping

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2058:
--
Fix Version/s: (was: 2.1.4)

> Pre-render home page to avoid wait when first hit webapp after bootstrapping
> 
>
> Key: ISIS-2058
> URL: https://issues.apache.org/jira/browse/ISIS-2058
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> You can try by rendering the home page in a separate thread during the 
> bootstraping
> You need to use ComponentRenderer#renderPage(app.getHomePage())
> you can do this for any of Isis' pages. You just need to provide their input 
> if they require such
>  
> It is a static method and it creates an artificial RequestCycle for its needs 
> (so it doesn't need an HTTP thread)
> [this is an cool idea for a small WicketStuff project that uses Wicket 
> IInitializer to render the home page in the background as soon as the app is 
> started]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2063) Entering a string such as "10:45" for a joda LocalTime causes stack trace.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2063:
--
Priority: Minor  (was: Major)

> Entering a string such as "10:45" for a joda LocalTime causes stack trace.
> --
>
> Key: ISIS-2063
> URL: https://issues.apache.org/jira/browse/ISIS-2063
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> stack trace:
>  
>  * org.apache.wicket.WicketRuntimeException
>  * Method onRequest of interface org.apache.wicket.behavior.IBehaviorListener 
> targeted at 
> org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract2$ScalarUpdatingBehavior@292c9c2f
>  on component [TextField [Component id = scalarValue]] threw an exception
>  * 
> org.apache.wicket.RequestListenerInterface#internalInvoke(RequestListenerInterface.java:268)
>  * 
> org.apache.wicket.RequestListenerInterface#invoke(RequestListenerInterface.java:241)
>  * 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler#invokeListener(ListenerInterfaceRequestHandler.java:248)
>  * 
> org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler#respond(ListenerInterfaceRequestHandler.java:234)
>  * 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:895)
>  * 
> org.apache.wicket.request.RequestHandlerStack#execute(RequestHandlerStack.java:64)
>  * org.apache.wicket.request.cycle.RequestCycle#execute(RequestCycle.java:265)
>  * 
> org.apache.wicket.request.cycle.RequestCycle#processRequest(RequestCycle.java:222)
>  * 
> org.apache.wicket.request.cycle.RequestCycle#processRequestAndDetach(RequestCycle.java:293)
>  * 
> org.apache.wicket.protocol.http.WicketFilter#processRequestCycle(WicketFilter.java:261)
>  * 
> org.apache.wicket.protocol.http.WicketFilter#processRequest(WicketFilter.java:203)
>  * 
> org.apache.wicket.protocol.http.WicketFilter#doFilter(WicketFilter.java:284)
>  * 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1621)
>  * 
> org.apache.isis.core.webapp.diagnostics.IsisLogOnExceptionFilter#doFilter(IsisLogOnExceptionFilter.java:52)
>  * 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1621)
>  * 
> org.apache.shiro.web.servlet.AbstractShiroFilter#executeChain(AbstractShiroFilter.java:449)
>  * 
> org.apache.shiro.web.servlet.AbstractShiroFilter$1#call(AbstractShiroFilter.java:365)
>  * 
> org.apache.shiro.subject.support.SubjectCallable#doCall(SubjectCallable.java:90)
>  * 
> org.apache.shiro.subject.support.SubjectCallable#call(SubjectCallable.java:83)
>  * 
> org.apache.shiro.subject.support.DelegatingSubject#execute(DelegatingSubject.java:383)
>  * 
> org.apache.shiro.web.servlet.AbstractShiroFilter#doFilterInternal(AbstractShiroFilter.java:362)
>  * 
> org.apache.shiro.web.servlet.OncePerRequestFilter#doFilter(OncePerRequestFilter.java:125)
>  * 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1613)
>  * org.eclipse.jetty.servlet.ServletHandler#doHandle(ServletHandler.java:541)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#handle(ScopedHandler.java:143)
>  * org.eclipse.jetty.security.SecurityHandler#handle(SecurityHandler.java:548)
>  * 
> org.eclipse.jetty.server.handler.HandlerWrapper#handle(HandlerWrapper.java:132)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#nextHandle(ScopedHandler.java:190)
>  * 
> org.eclipse.jetty.server.session.SessionHandler#doHandle(SessionHandler.java:1593)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#nextHandle(ScopedHandler.java:188)
>  * 
> org.eclipse.jetty.server.handler.ContextHandler#doHandle(ContextHandler.java:1239)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#nextScope(ScopedHandler.java:168)
>  * org.eclipse.jetty.servlet.ServletHandler#doScope(ServletHandler.java:481)
>  * 
> org.eclipse.jetty.server.session.SessionHandler#doScope(SessionHandler.java:1562)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#nextScope(ScopedHandler.java:166)
>  * 
> org.eclipse.jetty.server.handler.ContextHandler#doScope(ContextHandler.java:1141)
>  * 
> org.eclipse.jetty.server.handler.ScopedHandler#handle(ScopedHandler.java:141)
>  * 
> org.eclipse.jetty.server.handler.HandlerWrapper#handle(HandlerWrapper.java:132)
>  * org.eclipse.jetty.server.Server#handle(Server.java:564)
>  * org.eclipse.jetty.server.HttpChannel#handle(HttpChannel.java:320)
>  * org.eclipse.jetty.server.HttpConnection#onFillable(HttpConnection.java:251)
>  * 
> org.eclipse.jetty.io.AbstractConnection$ReadCallback#succeeded(AbstractConnection.java:279)
>  * 

[jira] [Updated] (ISIS-1053) [WON'T FIX] Unable to render java.lang.Number in UI

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1053:
--
Fix Version/s: (was: 2.11.0)
  Summary: [WON'T FIX] Unable to render java.lang.Number in UI  (was: 
Unable to render java.lang.Number in UI)

> [WON'T FIX] Unable to render java.lang.Number in UI
> ---
>
> Key: ISIS-1053
> URL: https://issues.apache.org/jira/browse/ISIS-1053
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: core-1.8.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1053) [WON'T FIX] Unable to render java.lang.Number in UI

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1053.
-
Fix Version/s: 2.0.0-M3
   Resolution: Won't Fix

> [WON'T FIX] Unable to render java.lang.Number in UI
> ---
>
> Key: ISIS-1053
> URL: https://issues.apache.org/jira/browse/ISIS-1053
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: core-1.8.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1021) suppress/disable the link in the first column of a table (CollectionProperty)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1021:
--
Priority: Minor  (was: Major)

> suppress/disable the link in the first column of a table (CollectionProperty)
> -
>
> Key: ISIS-1021
> URL: https://issues.apache.org/jira/browse/ISIS-1021
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: ARI
>Priority: Minor
>
> Goal:
> Suppress/disable the link in the first column of a table (CollectionProperty) 
> for marked DomainObjects.
> Proposal:
> - Add a new field to the @DomainObjectLayout like openable/viewable.
> - Special handling of title columns in CollectionContentsAsAjaxTablePanel / 
> ObjectAdapterTitleColumn / EntityIconAndTitlePanel
> Background:
> I have a complex entity which is displayed in tables in different places.
> In one place I want to show a subset of properties only. For this
> projection I made a special in-memory object, which wraps the complex
> entity and has getters for the subset of properties only. How can I mark
> this inmemory object to be not openable, or with other words how do i 
> suppress/disable the link in the first column.
> Dan/Martins "QuickFix" was:
> The column is added at
> https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
> and I see no way how to suppress the addition in current master branch.
> The column is marked with "title-column" CSS class so it is easy to hide
> with: visibility:hidden;, but I'm not sure how easy is to detect on which
> page to apply this CSS rule.
> If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
> #cssClass() special method that may be used to set a custom CSS class. See
> http://issues.apache.org/jira/browse/ISIS-1000
> Am 26.01.2015 um 23:11 schrieb Dan Haywood :
> +1 to Martin's answer, there is no configuration setting but it is possible
> to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
> For example, the todo app uses #cssClass() so that completed todo items are
> shown in a table with a strikethrough.  This comes from the "done" CSS
> class:
>   public String cssClass() { return !isComplete() ? "todo" : "done"; }
> In webapp/css/application.css, if we add:
>   tr.done a {
>   pointer-events: none;
>   cursor: default;
>   }
> and in webapp/scripts/application.js, if we add:
>   $(document).ready(function() {
>   $('tr.done a').click(function() { return false; });
>   });
> then the icon for each completed item cannot be clicked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2000) Display an optional help page in a sidebar, eg on the right.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2000:
--
Description: overlap with ISIS-1307

> Display an optional help page in a sidebar, eg on the right.
> 
>
> Key: ISIS-2000
> URL: https://issues.apache.org/jira/browse/ISIS-2000
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.5
>
>
> overlap with ISIS-1307



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1473) Inline edit for mutable collections with filtering

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1473:
--
Fix Version/s: (was: 2.1.4)

> Inline edit for mutable collections with filtering
> --
>
> Key: ISIS-1473
> URL: https://issues.apache.org/jira/browse/ISIS-1473
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: 1.13.0
>Reporter: Cesar Lugo
>Priority: Major
>
> Ability to allow inline mutable collections allowing filters.  This would 
> allow the users to edit collections in the same grid shown in the Viewer, and 
> also filter data using multiple types of filters.
> Mutable collections might include:
> - Row selection to identify which row to edit.
> - Move around the properties within a collection either using the TAB key or 
> using the mouse to position in a specific property.
> - Properties with multiple allowed values or with foreign lookup shown as a 
> drop down selection list. Ideally, if multiple values are allowed (1:N), 
> multi-selection might be allowed.
> - Existing values in a cell should be auto selected when the user reaches the 
> cell, to facilitate replacing the existing value by just keying in the new 
> value.
> - Allow creation of new elements in the collection by adding a row. Multiple 
> rows could be added by reaching the end of a row and keying in the TAB key, 
> and also by selecting a blank space by the end of the collection grid.
> - Ability to define in the meta data of the collection which properties are 
> editable in this grid.
> - Ability to define in the meta data if the user is allowed to add rows in 
> this collection.
> Filters:
> - Associate default filters to domain entities of the domain model.
> - Associate default filters to collections, ideally by inheriting filters 
> from the domain entities they are composed of.
> - Ability to define the type of filter (GUI widget), like drop down list, 
> type ahead lists, combo box, radio button, range slider, date pick, date 
> range slider.
> So default filters would be shown automatically in the UI, either in a stand 
> alone displayed entity, or on top of the collection.
> Ability to override filters for specific views.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1306) Enable graph visualisation in Wicket Viewer

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1306:
--
Fix Version/s: (was: 3.0.0)

> Enable graph visualisation in Wicket Viewer
> ---
>
> Key: ISIS-1306
> URL: https://issues.apache.org/jira/browse/ISIS-1306
> Project: Isis
>  Issue Type: Wish
>  Components: Isis Viewer Wicket
>Reporter: Vladimir Nisevic
>Priority: Minor
>
> Would be nice to have possibility to visualize graphs with. e.g 
> http://graphviz.org/ or maybe with http://visjs.org/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1306) Enable graph visualisation in Wicket Viewer

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1306:
--
Component/s: Isis ValueTypes

> Enable graph visualisation in Wicket Viewer
> ---
>
> Key: ISIS-1306
> URL: https://issues.apache.org/jira/browse/ISIS-1306
> Project: Isis
>  Issue Type: Wish
>  Components: Isis ValueTypes, Isis Viewer Wicket
>Reporter: Vladimir Nisevic
>Priority: Minor
>
> Would be nice to have possibility to visualize graphs with. e.g 
> http://graphviz.org/ or maybe with http://visjs.org/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-996) Define component factories as Spring @Components

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-996:
-
Fix Version/s: 2.0.0-M4

> Define component factories as Spring @Components
> 
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use 
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
>  - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends 
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList 
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
>  ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type 
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace 
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at 
> beginning of list) rather than "replace".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-996) Define component factories as Spring @Components

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-996:
-
Fix Version/s: (was: 2.1.4)
  Description: 
was previously:

Not possible to "replace" components in Wicket viewer (workaround is to use 
"add")

~

As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]

To recreate:
 - copy ReferencePanelFactory to ReferencePanelFactory2

in (subclass of) IsisWicketApplication, add:
{code:java}
@com.google.inject.Singleton
public static class MyComponentFactoryRegistrar extends 
ComponentFactoryRegistrarDefault {

@Override
public void addComponentFactories(ComponentFactoryList 
componentFactories) {
super.addComponentFactories(componentFactories);
componentFactories.replace(new ReferencePanelFactory2());
}
}
{code}
and
{code:java}
final Module overrides = new AbstractModule() {
@Override
protected void configure() {
 ...
bind(ComponentFactoryRegistrar.class).
to(MyComponentFactoryRegistrar.class);
}
};
{code}
the issue is that "replace" ends up replacing all component factories of type 
ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace the 
one for ReferencePanelFactory.

The workaround is easy enough: call "add" (which puts new factory at beginning 
of list) rather than "replace".

  was:
As per http://isis.markmail.org/thread/x3k2www3m2wfsgtv

To recreate:
- copy ReferencePanelFactory to ReferencePanelFactory2

in (subclass of) IsisWicketApplication, add:

{code}
@com.google.inject.Singleton
public static class MyComponentFactoryRegistrar extends 
ComponentFactoryRegistrarDefault {

@Override
public void addComponentFactories(ComponentFactoryList 
componentFactories) {
super.addComponentFactories(componentFactories);
componentFactories.replace(new ReferencePanelFactory2());
}
}
{code}

and

{code}
final Module overrides = new AbstractModule() {
@Override
protected void configure() {
 ...
bind(ComponentFactoryRegistrar.class).
to(MyComponentFactoryRegistrar.class);
}
};
{code}

the issue is that "replace" ends up replacing all component factories of type 
ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace the 
one for ReferencePanelFactory.

The workaround is easy enough: call "add" (which puts new factory at beginning 
of list) rather than "replace".


   Issue Type: Improvement  (was: Bug)
 Priority: Major  (was: Minor)
  Summary: Define component factories as Spring @Components  (was: Not 
possible to "replace" components in Wicket viewer (workaround is to use "add"))

> Define component factories as Spring @Components
> 
>
> Key: ISIS-996
> URL: https://issues.apache.org/jira/browse/ISIS-996
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Priority: Major
>
> was previously:
> Not possible to "replace" components in Wicket viewer (workaround is to use 
> "add")
> ~
> As per [http://isis.markmail.org/thread/x3k2www3m2wfsgtv]
> To recreate:
>  - copy ReferencePanelFactory to ReferencePanelFactory2
> in (subclass of) IsisWicketApplication, add:
> {code:java}
> @com.google.inject.Singleton
> public static class MyComponentFactoryRegistrar extends 
> ComponentFactoryRegistrarDefault {
> @Override
> public void addComponentFactories(ComponentFactoryList 
> componentFactories) {
> super.addComponentFactories(componentFactories);
> componentFactories.replace(new ReferencePanelFactory2());
> }
> }
> {code}
> and
> {code:java}
> final Module overrides = new AbstractModule() {
> @Override
> protected void configure() {
>  ...
> bind(ComponentFactoryRegistrar.class).
> to(MyComponentFactoryRegistrar.class);
> }
> };
> {code}
> the issue is that "replace" ends up replacing all component factories of type 
> ComponentType.SCALAR_NAME_AND_VALUE, whereas it should instead just replace 
> the one for ReferencePanelFactory.
> The workaround is easy enough: call "add" (which puts new factory at 
> beginning of list) rather than "replace".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-994) Actions that act as contributed properties and which return a URL should display that URL inline within an iframe.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-994:
-
Fix Version/s: (was: 2.11.0)

> Actions that act as contributed properties and which return a URL should 
> display that URL inline within an iframe.
> --
>
> Key: ISIS-994
> URL: https://issues.apache.org/jira/browse/ISIS-994
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> As per [1] mailing list thread, in particular its screenshot [5],
> if a contributed property (= action) returns a URL, then it should be 
> rendered within an iframe.   It may not actually be necessary to require any 
> other metadata.
> eg
> @Action(semantics=SemanticsOf.SAFE)
> @ActionLayout
> public URL editor(Asset asset) { ... }
> [1] http://markmail.org/message/merftvqoiy6ht3kq
> [5] http://postimg.org/image/k83i6b70x/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-978) Idea: allow bookmarking of app menus as submenus

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-978:
-
Fix Version/s: (was: 3.0.0)
 Priority: Minor  (was: Major)

> Idea: allow bookmarking of app menus as submenus
> 
>
> Key: ISIS-978
> URL: https://issues.apache.org/jira/browse/ISIS-978
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> Jeroen showed me a 3rd-party app once that did this (SugarCRM); I think we're 
> now in striking distance of being able to implement it within Isis.
> Basically, the idea is that, if there are a bunch of "finder"/query actions 
> in the application menu bar, then whenever invoked these should capture that 
> invocation as a bookmark (we already can do this) but render that bookmark 
> *not* in our bookmark panel but instead as a submenu of the application menu.
> In other words, when the user selects a menu item from a top-level menu, they 
> can also easily see (in the submenu) previous invocations of that query.
> These could even be pinnable or retained across sessions.
> ~~~
> Raising this now not because necessarily want to implement it, but just to 
> reserve the idea that submenus of menu items are not for further actions, but 
> instead might hold these bookmarks.
> ~~~
> Jeroen: can you dig out and attach a screenshot of SugarCRM?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-791) Actions returning collection annotated to indicate which properties as columns

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-791:
-
Fix Version/s: (was: 2.1.4)
  Summary: Actions returning collection annotated to indicate which 
properties as columns  (was: Annotation on actions that return collections so 
that the resultant list shows only specific properties as columns.)

> Actions returning collection annotated to indicate which properties as columns
> --
>
> Key: ISIS-791
> URL: https://issues.apache.org/jira/browse/ISIS-791
> Project: Isis
>  Issue Type: Wish
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.4.1, core-1.4.0
>Reporter: Erik de Hair
>Priority: Minor
>
> It would be nice to have a way of hiding (result) fields per
> finder/repo action to be more flexible in the user interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1031) Make it possible to filter on tables

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1031:
--
Priority: Major  (was: Minor)

> Make it possible to filter on tables
> 
>
> Key: ISIS-1031
> URL: https://issues.apache.org/jira/browse/ISIS-1031
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: viewer-wicket-1.7.0, core-1.7.0
>Reporter: Joshua Kamau
>Priority: Major
>  Labels: filter, grid, pagination
>
> It should be possible to show pagination in the tables possibly with 
> configurable page size. It should also be nice to have ability to filter 
> entities in a table.
> The DataTable,js (https://www.datatables.net/), which looks like it has a 
> Wicket integration already 
> (https://github.com/wicketstuff/core/wiki/DataTables) could be a good way to 
> go (we've used it in Naked Objects.NET application).
> To enable it, suggest an extension to @CollectionLayout(filterable=...) and 
> corresponding enhancement to layout.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1285) [WON'T FIX] Provide the capability to disable the browser's back button/

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1285:
--
Fix Version/s: 2.0.0-M3

> [WON'T FIX] Provide the capability to disable the browser's back button/
> 
>
> Key: ISIS-1285
> URL: https://issues.apache.org/jira/browse/ISIS-1285
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> In the Estatio app (and presumably many others, too), when the user deletes 
> an object then they are shown the "no results" page.
> What we have observed the user then do is to press the back button.  This 
> navigates them to the object just deleted; because it has been deleted, the 
> Wicket viewer shows them an error page. 
> With the RoutingService (introduced in 1.11.0) we have the opportunity to 
> route the user to some other "more useful" object, eg the parent of the 
> deleted object, or some other object recently visited, or the home page.
> Even so, if the user does press the back button, they would still see the 
> same message.
> This ticket is therefore to provide an optional capability to have the back 
> button disabled.  Think it should be optional because not everyone (every 
> programmer) will agree that back buttons should be disabled and in any case 
> for some use cases, eg in read-only app, a back button is probably a good 
> thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (ISIS-1285) [WON'T FIX] Provide the capability to disable the browser's back button/

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood reopened ISIS-1285:
---

> [WON'T FIX] Provide the capability to disable the browser's back button/
> 
>
> Key: ISIS-1285
> URL: https://issues.apache.org/jira/browse/ISIS-1285
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> In the Estatio app (and presumably many others, too), when the user deletes 
> an object then they are shown the "no results" page.
> What we have observed the user then do is to press the back button.  This 
> navigates them to the object just deleted; because it has been deleted, the 
> Wicket viewer shows them an error page. 
> With the RoutingService (introduced in 1.11.0) we have the opportunity to 
> route the user to some other "more useful" object, eg the parent of the 
> deleted object, or some other object recently visited, or the home page.
> Even so, if the user does press the back button, they would still see the 
> same message.
> This ticket is therefore to provide an optional capability to have the back 
> button disabled.  Think it should be optional because not everyone (every 
> programmer) will agree that back buttons should be disabled and in any case 
> for some use cases, eg in read-only app, a back button is probably a good 
> thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1285) [WON'T FIX] Provide the capability to disable the browser's back button/

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1285.
-
Resolution: Fixed

> [WON'T FIX] Provide the capability to disable the browser's back button/
> 
>
> Key: ISIS-1285
> URL: https://issues.apache.org/jira/browse/ISIS-1285
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> In the Estatio app (and presumably many others, too), when the user deletes 
> an object then they are shown the "no results" page.
> What we have observed the user then do is to press the back button.  This 
> navigates them to the object just deleted; because it has been deleted, the 
> Wicket viewer shows them an error page. 
> With the RoutingService (introduced in 1.11.0) we have the opportunity to 
> route the user to some other "more useful" object, eg the parent of the 
> deleted object, or some other object recently visited, or the home page.
> Even so, if the user does press the back button, they would still see the 
> same message.
> This ticket is therefore to provide an optional capability to have the back 
> button disabled.  Think it should be optional because not everyone (every 
> programmer) will agree that back buttons should be disabled and in any case 
> for some use cases, eg in read-only app, a back button is probably a good 
> thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2269) Exception when calling collection on integration test ('more than one ImperativeFacet for method getReferencedObjects , with inconsistent intents')

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2269:
--
Component/s: (was: Isis Core)
 Isis Testing

This will disappear as an issue if we make collections non-modifiable / 
read-only

> Exception when calling collection on integration test ('more than one 
> ImperativeFacet for method getReferencedObjects , with inconsistent intents')
> ---
>
> Key: ISIS-2269
> URL: https://issues.apache.org/jira/browse/ISIS-2269
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Testing
>Affects Versions: 1.17.0
>Reporter: Erik de Hair
>Priority: Major
>
> When 'consuming' a collection of a domain class in integration tests using 
> the wrapper factory an exception is thrown.
> java.lang.IllegalArgumentException: 
> domainapp.modules.simple.dom.impl.SimpleObject#referencedObjects: more than 
> one ImperativeFacet for method getReferencedObjects , with inconsistent 
> intents: 
> [CollectionAccessorFacetViaAccessor[type=PropertyOrCollectionAccessorFacet,method=public
>  java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionClearFacetViaAccessor[type=CollectionClearFacet,method=public 
> java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionAddToFacetViaAccessor[type=CollectionAddToFacet,method=public 
> java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionRemoveFromFacetViaAccessor[type=CollectionRemoveFromFacet,method=public
>  java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()]]java.lang.IllegalArgumentException:
>  domainapp.modules.simple.dom.impl.SimpleObject#referencedObjects: more than 
> one ImperativeFacet for method getReferencedObjects , with inconsistent 
> intents: 
> [CollectionAccessorFacetViaAccessor[type=PropertyOrCollectionAccessorFacet,method=public
>  java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionClearFacetViaAccessor[type=CollectionClearFacet,method=public 
> java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionAddToFacetViaAccessor[type=CollectionAddToFacet,method=public 
> java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()], 
> CollectionRemoveFromFacetViaAccessor[type=CollectionRemoveFromFacet,method=public
>  java.util.List 
> domainapp.modules.simple.dom.impl.SimpleObject.getReferencedObjects()]]
>  at 
> org.apache.isis.core.metamodel.facets.ImperativeFacet$Util.getIntent(ImperativeFacet.java:169)
>  at 
> org.apache.isis.core.wrapper.handlers.DomainObjectInvocationHandler.invoke(DomainObjectInvocationHandler.java:212)
>  at 
> org.apache.isis.core.wrapper.proxy.ProxyCreator$1.invoke(ProxyCreator.java:72)
>  at 
> domainapp.modules.simple.dom.impl.SimpleObject_$$_jvstf5f_b.getReferencedObjects(SimpleObject_$$_jvstf5f_b.java)
>  at 
> domainapp.modules.simple.integtests.tests.SimpleReferencedObjectCollection_IntegTest.testCollectionOfReferencedSimpleObjects(SimpleReferencedObjectCollection_IntegTest.java:27)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498) at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2253) Derive ChoicesFacet from AssociatedWithFacet, remove special-case logic.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2253:
--
Summary: Derive ChoicesFacet from AssociatedWithFacet, remove special-case 
logic.  (was: Actions fail MM Validation when associated)

> Derive ChoicesFacet from AssociatedWithFacet, remove special-case logic.
> 
>
> Key: ISIS-2253
> URL: https://issues.apache.org/jira/browse/ISIS-2253
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Priority: Major
>
> In fact, this is a case of two wrongs not quite making a right. There's a 
> nasty hack in that it is the Wicket viewer that knows how to populate the 
> choices for the parameter, and it does this without looking for an 
> autoComplete or choices facet ; it just picks up the checked items of the 
> associated collection.
>  The short term solution to fix DemoApp is just to update that metamodel 
> validator to also take into account any AssociatedWithFacet.
>  The long term "correct" solution is a new facet factory that will derive a 
> ChoicesFacet from the AssociatedWithFacet, and then to remove the special 
> case logic from the Wicket viewer.
> That would then make the validator correct as it is now written.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2253) Actions fail MM Validation when associated

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2253:
--
  Component/s: (was: Isis Core)
Fix Version/s: (was: 2.0.5)

> Actions fail MM Validation when associated
> --
>
> Key: ISIS-2253
> URL: https://issues.apache.org/jira/browse/ISIS-2253
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Priority: Major
>
> In fact, this is a case of two wrongs not quite making a right. There's a 
> nasty hack in that it is the Wicket viewer that knows how to populate the 
> choices for the parameter, and it does this without looking for an 
> autoComplete or choices facet ; it just picks up the checked items of the 
> associated collection.
>  The short term solution to fix DemoApp is just to update that metamodel 
> validator to also take into account any AssociatedWithFacet.
>  The long term "correct" solution is a new facet factory that will derive a 
> ChoicesFacet from the AssociatedWithFacet, and then to remove the special 
> case logic from the Wicket viewer.
> That would then make the validator correct as it is now written.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2044) UI: IsisConfiguration download for offline editing (like layouts)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2044:
--
Fix Version/s: (was: 2.4.0)

> UI: IsisConfiguration download for offline editing (like layouts)
> -
>
> Key: ISIS-2044
> URL: https://issues.apache.org/jira/browse/ISIS-2044
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Core
>Reporter: Andi Huber
>Priority: Minor
>
> When PROTOTYPING, allow for download of then IsisConfiguration in serialized 
> form (text-file), which can be edited offline and reused, same as we do with 
> layouts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2234) During the render phase, don't populate the execution call graphs with results of mixins being invoked.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2234:
--
Component/s: (was: Isis Core)
 Isis Viewer Wicket

> During the render phase, don't populate the execution call graphs with 
> results of mixins being invoked.
> ---
>
> Key: ISIS-2234
> URL: https://issues.apache.org/jira/browse/ISIS-2234
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Attachments: screenshot-1.png
>
>
> This is somewhat similar to ISIS-1656, which is to flush audit/publishing etc 
> at the end of the ACTION phase, rather than the RENDER phase.
> More broadly stated: RENDERing shouldn't have any side-effects.
> ~~~
> Looking at the code today, we can see that in OneToOneAssociationMixedIn 
> there's a hack:
> {code:java}
> @Override
> public ManagedObject get(
> final ManagedObject mixedInAdapter,
> final InteractionInitiatedBy interactionInitiatedBy) {
> val mixinAdapter = mixinAdapterFor(mixinType, mixedInAdapter);
> return getPublishingServiceInternal().withPublishingSuppressed(
> () -> mixinAction.executeInternal(
> mixinAdapter, mixedInAdapter, Can.empty(), 
> interactionInitiatedBy)
> );
> }
>  {code}
> which prevents the action invocation in the render phase from publishing 
> anything.  
> However, inspection of the internal data structures does currently show that 
> the Interaction executionGraph (push, pop) gets populated, there is no 
> corresponding hack... see attached screenshot, that shows a number of 
> executions for all of the contributed properties of a SimpleObject.  This 
> isn't harmful per se, but it is odd that we spend all this effort to create 
> the execution graph for it to be consumed by no-one at all.
> The bottom line is that actions don't know which phase they are being 
> executed in, and so they do all this extra work.
> Perhaps the solution might be to include the phase in the InteractionContext, 
> so we can therefore avoid this unnecessary work populating the executionGraph.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1219) [DUPLICATE?] Extend events to allow subscribers to provide defaults, choices, autoComplete on action parameters.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1219:
--
  Component/s: (was: Isis Core)
   Isis Applib (programming model)
Fix Version/s: (was: 2.1.2)
  Summary: [DUPLICATE?] Extend events to allow subscribers to provide 
defaults, choices, autoComplete on action parameters.  (was: Extend events to 
allow subscribers to provide defaults, choices, autoComplete on action 
parameters.)

> [DUPLICATE?] Extend events to allow subscribers to provide defaults, choices, 
> autoComplete on action parameters.
> 
>
> Key: ISIS-1219
> URL: https://issues.apache.org/jira/browse/ISIS-1219
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.9.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2029) Using Application Identity (e.g. settings module) with .orm file leads to Webui exception

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2029:
--
  Component/s: (was: Isis Viewer Wicket)
   (was: Isis Core)
   Isis Persistence JDO
Fix Version/s: (was: 2.1.2)

> Using Application Identity (e.g. settings module) with .orm file leads to 
> Webui exception
> -
>
> Key: ISIS-2029
> URL: https://issues.apache.org/jira/browse/ISIS-2029
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Persistence JDO
>Affects Versions: 1.16.2
>Reporter: Vladimir Nisevic
>Priority: Major
> Attachments: stacktrace.txt
>
>
> h2.Problem description
> I want to use settings module (incode or previous isis-addons) so that the 
> tables are persisted in custom database schema (different than isissettings).
> In order to achieve this I have created a custom .orm file e.g.
>  
> package-custom.orm 
> {code:java}
> 
> http://xmlns.jcp.org/xml/ns/jdo/orm;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/jdo/orm 
> http://xmlns.jcp.org/xml/ns/jdo/orm_3_0.xsd;>
> 
>  table="IsisAppSetting"/>
> 
> 
> 
> {code}
> and refer the file in persistor_datanucleus.properties
> {code:java}
> # schema name override
> isis.persistor.datanucleus.impl.datanucleus.Mapping=custom{code}
>  
> I can create single ApplicationSetting thru WebUI but if I have more than one 
> persisted, here the WebUI exception I get in WebUI
> {code:java}
> Caused by:
> org.datanucleus.exceptions.NucleusUserException
> Identity 
> "interface.MQTT.activated[OID]org.incode.example.settings.dom.jdo.ApplicationSettingJdo"
>  is assigned to class 
> "org.incode.example.settings.dom.jdo.ApplicationSettingJdo", but its not the 
> correct object-id type for this class.
> org.datanucleus.store.AbstractStoreManager#manageClassForIdentity(AbstractStoreManager.java:937)
> org.datanucleus.ExecutionContextImpl#getClassDetailsForId(ExecutionContextImpl.java:3385)
> org.datanucleus.ExecutionContextImpl#findObjects(ExecutionContextImpl.java:3251){code}
>  
> I believe the root cause is that Datanucleus thinks somehow that the 
> ApplicationSetting has not Application Identity which it has since field key 
> is primary key - but only in the case when retreiving more then one entity 
> from database.
>  
> All works fine when creating new instance ApplicationSetting or reading it 
> from database by key. The command "Settings --> listAll" fails.
>  
> I tried also to adapt the .orm file e.g. but it didn't helped.
> {code:java}
> 
>  schema="myschema" table="IsisAppSetting">
> 
> 
>  table="IsisUserSetting"/>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2004) Concurrent Modification Exception in grid service

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2004:
--
Fix Version/s: (was: 2.1.4)

> Concurrent Modification Exception in grid service
> -
>
> Key: ISIS-2004
> URL: https://issues.apache.org/jira/browse/ISIS-2004
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Trivial
>
> This occurred when invoking "latestFastnetImportLog" within Estatio (having 
> just restarted, in estatio-test - prototype mode)
> {code}
> 11:20:44,677 [RequestCycleExtra ] Handling the following exception
> org.apache.wicket.WicketRuntimeException: Error attaching this container for 
> rendering: [RepeatingViewWithDynamicallyVisibleContent [Component id = 
> tabGroups]]
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1837)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Page.onBeforeRender(Page.java:801)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.Component.internalPrepareForRender(Component.java:2236)
>   at org.apache.wicket.Page.internalPrepareForRender(Page.java:242)
>   at org.apache.wicket.Component.render(Component.java:2325)
>   at org.apache.wicket.Page.renderPage(Page.java:1018)
>   at 
> 

[jira] [Updated] (ISIS-1980) Unexpected error when accessing collection through wrapper.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1980:
--
Fix Version/s: (was: 2.1.4)

This disappears as an issue if we remove the concept of mutable collections.

> Unexpected error when accessing collection through wrapper.
> ---
>
> Key: ISIS-1980
> URL: https://issues.apache.org/jira/browse/ISIS-1980
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.16.2
>Reporter: Andi Huber
>Priority: Major
>
> As reported by Gabriel Terwesten  [1]
> Inside of integration tests i can’t seem to access collections through the 
> getter if the object is wrapped. From the documentation I got the impression 
> that that should be possible. 
> This is the offending line:
> assertThat(wrap(food).getCustomUnits()).hasSize(1);
> {noformat}
> IllegalArgumentException: d.m.c.d.i.Food#customUnits: more than one 
> ImperativeFacet for method getCustomUnits , with inconsistent intents: ...
> at o.a.i.c.m.facets.ImperativeFacet$Util.getIntent(ImperativeFacet.java:167)
> {noformat}
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2060) Allow safe actions to be invoked if only have read-only access.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-2060:
--
Component/s: (was: Isis Applib (programming model))
 Isis Core

> Allow safe actions to be invoked if only have read-only access.
> ---
>
> Key: ISIS-2060
> URL: https://issues.apache.org/jira/browse/ISIS-2060
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.16.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> Use a config property to enable this feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1807) Wrap Domain Entities by default

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1807:
--
Fix Version/s: (was: 2.1.2)

> Wrap Domain Entities by default
> ---
>
> Key: ISIS-1807
> URL: https://issues.apache.org/jira/browse/ISIS-1807
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.15.1
>Reporter: Óscar Bou
>Priority: Major
>
> Maybe this should be controlled by a new nature on domain services?  Whether 
> to wrap should be "inherited", ie if invoke a wrapped domain service then any 
> entities returned would also be wrapped.
> ~~
>  
> This way, all hide/disable/validate constraints, and other 
> constraints/invariants forced through actions, are always ensured by default.
> This will require to wrap by default:
>  * New Domain Entity instances / objects (ie, changes on FactoryService).
>  * Domain Entities returned by queries (ie, changes on RepositoryService).
> Users might disable this new default behaviour through configuration, as some 
> projects can prioritize performance (avoiding wrapping invocations) vs Domain 
> constraints/invariants enforcement.
> 
>  Dan's notes:
> I'd like to refine the concept of wrapping while implementing this ticket.
> The idea of wrapping was originally to allow the UI to be simulated within 
> integration tests. The intent of this ticket is to formalize the idea of the 
> same set of validations being done automatically between programmatic 
> interactions from one service/entity to another service/entity.
> So, the more general concept (common to both UI/domain interactions and 
> domain-to-domain programmatic interactions) is one of _trust boundaries_. If 
> there is no trust from the calling client to the supplying service/entity, 
> then that interaction should be wrapped.
> However, the wrapping model as it currently stands is a little bit too 
> UI/domain oriented, in that it has both hidden AND disabled as well as 
> validate phases. From the perspective of a programmatic domain-to-domain 
> interaction there's no meaningful distinction between the hidden and disabled 
> constraints: they both mean: "that object isn't in a state to be called". In 
> other words its a pre constraint that is not satisfied.
> The other aspect here is that I can imagine that there are actions that we 
> would like to allow to be made programmatically (ie through a wrapper) but 
> which shouldn't be part of the UI. In other words these actions form part of 
> the programmatic API of a module, just not part of its UI.
> Putting all this together, I propose that we slightly change the meaning of 
> wrapping (though we'll keep the current implementation too for backwards 
> compatibility), namely that by default wrapped object will check the disable 
> and validate phases only, ie it will _not_ check the hidden phase. This 
> allows such actions to be indicated as hidden (probably using @ActionLayout 
> or .layout.xml or security) but still able to be called programmatically. The 
> disable phase = pre check.
> We could define the following terminology:
>  - "default" wrapping : as described above, checks only disable and validate, 
> not hidden
>  - "strict" wrapping - for backward compatibility, also checks hidden first
> We could define a configuration property:
> isis.runtime.wrapping=default | strict | none
> with "default" wrapping being the default if not specified.
> In terms of the programming API, the WrapperFactory#wrap(...) will obviously 
> be less important than it was, because by default objects will be wrapped. 
> For backward compatibilty, I think this should continue to create strict 
> wrappers
> The wrap(...) method is also overloaded, with wrap(ExecutionMode). We can 
> extend this enum:
>  - EXECUTE - (existing) returns a strict wrapper
>  - SKIP_RULES - (existing) skips applying the hidden/disable/validate rules
>  - NO_EXECUTE - (existing) applies hidden/disabled/validate, but does not 
> execute
>  - DEFAULT - (new) returns a "default" wrapper, applies only disable/validate 
> but not hidden
> (new:) if the object passed in is already wrapped, then it should be replaced 
> with a wrapper with the specified mode. Prevoiusly this was a no-op, I think.
> The unwrap(...) method is unchanged.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1863) Code generate page object classes to allow smoke tests using Selenium to be developed more easily

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1863:
--
  Component/s: (was: Isis Core)
   Isis Testing
Fix Version/s: (was: 2.1.4)
 Priority: Minor  (was: Major)

> Code generate page object classes to allow smoke tests using Selenium to be 
> developed more easily
> -
>
> Key: ISIS-1863
> URL: https://issues.apache.org/jira/browse/ISIS-1863
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Testing
>Affects Versions: 1.16.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1805) PersistenceQueryFindUsingApplibQueryProcessor#getResultsPk looks to be unused.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1805:
--
  Component/s: (was: Isis Core)
   Isis Persistence JDO
Fix Version/s: (was: 2.4.0)

> PersistenceQueryFindUsingApplibQueryProcessor#getResultsPk looks to be unused.
> --
>
> Key: ISIS-1805
> URL: https://issues.apache.org/jira/browse/ISIS-1805
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Persistence JDO
>Affects Versions: 1.15.1
>Reporter: Daniel Keir Haywood
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1735) Bind action with property/collection by naming convention.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1735:
--
  Component/s: Isis Applib (programming model)
Fix Version/s: (was: 2.1.4)
  Summary: Bind action with property/collection by naming convention.  
(was: [DUPLICATE] Bind action with property/collection by naming convention.)

> Bind action with property/collection by naming convention.
> --
>
> Key: ISIS-1735
> URL: https://issues.apache.org/jira/browse/ISIS-1735
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model), Isis Core
>Affects Versions: 1.15.0
>Reporter: Daniel Keir Haywood
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1670) ScalarPanelAbstract2 in edit mode (or with INLINE_AS_IF_EDIT action) does not dynamically update enablement/disability based on other state.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1670:
--
Component/s: (was: Isis Core)
 Isis Viewer Wicket

> ScalarPanelAbstract2 in edit mode (or with INLINE_AS_IF_EDIT action) does not 
> dynamically update enablement/disability based on other state.
> 
>
> Key: ISIS-1670
> URL: https://issues.apache.org/jira/browse/ISIS-1670
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.7.0
>
>
> ... because the gui is built during onInitialize callback, and this is called 
> when re-rendered
> Funnily enough, ScalarPanelAbstract (which ScalarPanelAbstract2 replaces) 
> uses onBeforeRender.
> Am guessing there was probably a reason to move the gui building to 
> onInitialize...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1639) Extend semantics of RO spec and RO viewer for 202 (Accepted).

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1639:
--
  Component/s: (was: Isis Core)
   Isis Viewer RO
Fix Version/s: (was: 2.8.0)

> Extend semantics of RO spec and RO viewer for 202 (Accepted).
> -
>
> Key: ISIS-1639
> URL: https://issues.apache.org/jira/browse/ISIS-1639
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer RO
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> as per 
> https://stackoverflow.com/questions/44386779/apache-isis-set-http-response



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1695) Support value types (simple ones at least) as a first-class citizen

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1695:
--
Component/s: (was: Isis Viewer Wicket)
 (was: Isis ValueTypes)
 (was: Isis Core)
 Isis Incubator

> Support value types (simple ones at least) as a first-class citizen
> ---
>
> Key: ISIS-1695
> URL: https://issues.apache.org/jira/browse/ISIS-1695
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Incubator
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> I would like to reintroduce value types as a first-class citizen, but without 
> requiring the developer to have to write lots of code to teach DataNucleus, 
> Wicket and the RO viewer about these.
> I don't have a general solution in mind on how to do this.
> However, for very simple value types that are just a type-safe wrapper around 
> a single field (eg Password, or Money, or Temperature, or Email say), then 
> perhaps there might be a way to support this, eg :
> public class Temperature implements 
> org.apache.isis.valuetypes.Value {
>     public Temperature(BigDecimal value) \{ ... }
>     BigDecimal getValue() \{ ... }
> }
>  
>  or
>  
>  @Value(underlying=BigDecimal.class)
>  public class Temperature \{ ... }
> The idea here is that the framework would treat any instance of this custom 
> value type as if it were the underlying type (BigDecimal in the case above). 
> It would also be possible to apply validations to the value type that would 
> apply everywhere it is used as a property/parameter.
>  
> We would expect these value types to be immutable, and (although this can't 
> be expressed in an interface), would expect there to be a public 1-arg 
> constructor of the appropriate type, and a package-local "getValue()" method. 
>  These allow the framework to marshal values in and out of the value type.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1672) Simplify handling of autoComplete facet, by copying autoComplete from parameter type's spec down to the parameter itself

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1672:
--
Fix Version/s: (was: 2.1.0)

> Simplify handling of autoComplete facet, by copying autoComplete from 
> parameter type's spec down to the parameter itself
> 
>
> Key: ISIS-1672
> URL: https://issues.apache.org/jira/browse/ISIS-1672
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> Currently ReferencePanel and (as of ISIS-1600) the  
> ActionChoicesForCollectionParameterFacetFactory both check for 
> autoComplete/choices of a parameter in two places:
> a) on the parameter itself (as per a choicesNXxx() or an autoCompleteNXxx())
> b) on the parameter's type (as per @DomainObject(autoCompleteRepository=...)
> To simplify and make more consistent, should derive a parameter-level 
> ActionParameterAutoCompleteFacet from the objectspec's AutoCompletefacet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1628) MixinFacet doesn't properly create domain events if abstract and invoke via the wrapper (ie during integ tests)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1628:
--
Fix Version/s: (was: 2.3.0)
 Priority: Minor  (was: Major)

> MixinFacet doesn't properly create domain events if abstract and invoke via 
> the wrapper (ie during integ tests)
> ---
>
> Key: ISIS-1628
> URL: https://issues.apache.org/jira/browse/ISIS-1628
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> fix, don't use getDeclaredFields, instead getFields (I think... to test)
> ~~~
> because of 
> https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/mixin/MixinFacetAbstract.java#L97
> getDeclaredFields() rather than getFields()
> to reproduce, eg HasDocumentAbstract_categoriseAbstract subclasses.
> 
> Also, necessary to override the method itself in the subclass, else
> https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/wrapper/src/main/java/org/apache/isis/core/wrapper/handlers/DomainObjectInvocationHandler.java#L297
> does not find the actual ObjectActionMixedIn (the mixin's ObjectActionDefault 
> does not match)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1638) Better error message diagnostic to explain why cannot invoke an action that returns a Blob (downloadable) in the background.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1638:
--
Fix Version/s: (was: 2.7.0)

> Better error message diagnostic to explain why cannot invoke an action that 
> returns a Blob (downloadable) in the background.
> 
>
> Key: ISIS-1638
> URL: https://issues.apache.org/jira/browse/ISIS-1638
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> https://stackoverflow.com/questions/44425554/commandexecutein-background-throws-a-not-an-encodable-value-error



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1623) Enhance @MustSatisfy Specification API, pass in the current object as context

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1623:
--
  Component/s: (was: Isis Core)
   Isis Applib (programming model)
Fix Version/s: (was: 2.1.4)

> Enhance @MustSatisfy Specification API, pass in the current object as context
> -
>
> Key: ISIS-1623
> URL: https://issues.apache.org/jira/browse/ISIS-1623
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1620) [DUPLICATE?] validator if choices specified incorrectly

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1620:
--
Component/s: (was: Isis Core)
 Isis Applib (programming model)
Summary: [DUPLICATE?] validator if choices specified incorrectly  (was: 
use normal mechanism of indicating metamodel invalid if choices specified 
incorrectly)

> [DUPLICATE?] validator if choices specified incorrectly
> ---
>
> Key: ISIS-1620
> URL: https://issues.apache.org/jira/browse/ISIS-1620
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model)
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Trivial
> Fix For: 2.1.4
>
>
> currently the framework just fails "too fast" and throws an exception as soon 
> as the issue is detected.  instead it should collate the problem and report 
> along with others (as for other metamodel invalid exceptions).
> To reproduce in kitchensink app:
> {code}
> @Action(semantics=SemanticsOf.IDEMPOTENT, publishing = Publishing.ENABLED)
> public TextObject updateSomeStringOptionalWithMultiChoices(
> // @Nullable
> @ParameterLayout(named = "Choose some string(s)")
> final List strings) {
> final String asStr = SeparatorUtil.asStr(strings);
> setSomeStringOptionalWithMultiChoices(asStr);
> return this;
> }
> public List choices0UpdateSomeStringOptionalWithMultiChoices() {
> return choicesUpdateSomeStringOptionalWithMultiChoices();
> }
> public List choicesUpdateSomeStringOptionalWithMultiChoices() {
> return Lists.newArrayList("a", "ab", "abcd", "abcdefgh", 
> "abcdefghijklmnop", "abcdefghijklmnopqrstuvwxyz");
> }
> {code}
> will throw an exception when encountered
> {code}
>   at org.apache.wicket.Application.initApplication(Application.java:953)
>   at 
> org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:429)
>   ... 20 more
> Caused by: org.apache.isis.core.metamodel.exceptions.MetaModelException: 
> class org.isisaddons.app.kitchensink.dom.text.TextObject uses both old and 
> new choices syntax - must use one or other
>   at 
> org.apache.isis.core.metamodel.facets.param.choices.methodnum.ActionParameterChoicesFacetViaMethodFactory.attachChoicesFacetForParametersIfChoicesNumMethodIsFound(ActionParameterChoicesFacetViaMethodFactory.java:92)
>   at 
> org.apache.isis.core.metamodel.facets.param.choices.methodnum.ActionParameterChoicesFacetViaMethodFactory.process(ActionParameterChoicesFacetViaMethodFactory.java:65)
>   at 
> org.apache.isis.core.metamodel.specloader.facetprocessor.FacetProcessor.process(FacetProcessor.java:315)
>   at 
> org.apache.isis.core.metamodel.specloader.specimpl.FacetedMethodsBuilder.createActionFacetedMethod(FacetedMethodsBuilder.java:489)
>   at 
> org.apache.isis.core.metamodel.specloader.specimpl.FacetedMethodsBuilder.findActionFacetedMethod(FacetedMethodsBuilder.java:475)
>   at 
> org.apache.isis.core.metamodel.specloader.specimpl.FacetedMethodsBuilder.findActionFacetedMethods(FacetedMethodsBuilder.java:454)
>   at 
> org.apache.isis.core.metamodel.specloader.specimpl.FacetedMethodsBuilder.findActionFacetedMethods(FacetedMethodsBuilder.java:433)
>   at 
> org.apache.isis.core.metamodel.specloader.specimpl.FacetedMethodsBuilder.getActionFacetedMethods(FacetedMethodsBuilder.java:409)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1568) [WON'T FIX] Automated testing tool to act as a webcrawler, clicking on all links and assert that the page is rendered correctly.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1568.
-
Resolution: Won't Fix

> [WON'T FIX] Automated testing tool to act as a webcrawler, clicking on all 
> links and assert that the page is rendered correctly.
> 
>
> Key: ISIS-1568
> URL: https://issues.apache.org/jira/browse/ISIS-1568
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Testing
>Affects Versions: 1.13.2.1
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> This is probably an Isis addon.
> My idea is that it would use Selenium in some way or another, leveraging 
> docker as a means to deploy the webapp and phantomjs.
> https://hub.docker.com/r/wernight/phantomjs/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1591) [WON'T FIX] isis-maven-plugin validate goal is not thread-safe

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1591.
-
Resolution: Won't Fix

> [WON'T FIX] isis-maven-plugin validate goal is not thread-safe
> --
>
> Key: ISIS-1591
> URL: https://issues.apache.org/jira/browse/ISIS-1591
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Running validate on two modules concurrently (eg mvn clean install -T1C...) 
> causes an exception
> workaround is to run in serial mode.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1568) [WON'T FIX] Automated testing tool to act as a webcrawler, clicking on all links and assert that the page is rendered correctly.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1568:
--
  Component/s: (was: Isis Core)
   Isis Testing
Fix Version/s: (was: 3.0.0)
   2.0.0-M3
  Summary: [WON'T FIX] Automated testing tool to act as a webcrawler, 
clicking on all links and assert that the page is rendered correctly.  (was: 
Automated testing tool to act as a webcrawler, clicking on all links and assert 
that the page is rendered correctly.)

> [WON'T FIX] Automated testing tool to act as a webcrawler, clicking on all 
> links and assert that the page is rendered correctly.
> 
>
> Key: ISIS-1568
> URL: https://issues.apache.org/jira/browse/ISIS-1568
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Testing
>Affects Versions: 1.13.2.1
>Reporter: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>
> This is probably an Isis addon.
> My idea is that it would use Selenium in some way or another, leveraging 
> docker as a means to deploy the webapp and phantomjs.
> https://hub.docker.com/r/wernight/phantomjs/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1591) [WON'T FIX] isis-maven-plugin validate goal is not thread-safe

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1591:
--
Fix Version/s: (was: 2.8.0)
   2.0.0-M3
  Summary: [WON'T FIX] isis-maven-plugin validate goal is not 
thread-safe  (was: isis-maven-plugin validate goal is not thread-safe)

mvn plugin has been removed

> [WON'T FIX] isis-maven-plugin validate goal is not thread-safe
> --
>
> Key: ISIS-1591
> URL: https://issues.apache.org/jira/browse/ISIS-1591
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.14.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Running validate on two modules concurrently (eg mvn clean install -T1C...) 
> causes an exception
> workaround is to run in serial mode.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1563) Remove support in Memento (internal class) for transient (JDO) entities

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1563:
--
Fix Version/s: (was: 2.0.5)
   2.0.0-M3

> Remove support in Memento (internal class) for transient (JDO) entities
> ---
>
> Key: ISIS-1563
> URL: https://issues.apache.org/jira/browse/ISIS-1563
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> This is a legacy from days gone by, but there is no longer any needed to 
> handle this.  Instead, just fail-fast if attempt to create a Memento for a 
> domain entity that is not yet persistent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1563) Remove support in Memento (internal class) for transient (JDO) entities

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1563.
-
Resolution: Fixed

> Remove support in Memento (internal class) for transient (JDO) entities
> ---
>
> Key: ISIS-1563
> URL: https://issues.apache.org/jira/browse/ISIS-1563
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> This is a legacy from days gone by, but there is no longer any needed to 
> handle this.  Instead, just fail-fast if attempt to create a Memento for a 
> domain entity that is not yet persistent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1537) Wrapper factory doesn't seem to handle disable$$ (and perhaps hide$$) in subtype of $$ for a mixin.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1537:
--
Fix Version/s: (was: 2.8.0)

> Wrapper factory doesn't seem to handle disable$$ (and perhaps hide$$) in 
> subtype of $$ for a mixin.
> ---
>
> Key: ISIS-1537
> URL: https://issues.apache.org/jira/browse/ISIS-1537
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> eg
> incode document module, integration testing of 
> T_createAndAttachDocumentAndScheduleRender
> It also seems to be necessary to pass in a non-null arg, even though 
> validation checks are done after disablement checks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1530) Introduce @CollectionLayout(title=SHOW|HIDE, ...) similarly for @ActionLayout and @DomainObjectLayout

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1530:
--
  Component/s: Isis Viewer Wicket
   Isis Applib (programming model)
Fix Version/s: (was: 2.1.4)

> Introduce @CollectionLayout(title=SHOW|HIDE, ...) similarly for @ActionLayout 
> and @DomainObjectLayout
> -
>
> Key: ISIS-1530
> URL: https://issues.apache.org/jira/browse/ISIS-1530
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model), Isis Core, Isis Viewer 
> Wicket
>Affects Versions: 1.13.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> Introduce @CollectionLayout(title=SHOW|HIDE, ...) for parented collections, 
> and @ActionLayout(titleInCollection=SHOW|HIDE, ...) for actions returning 
> collections (ignored otherwise).  Could also have 
> @DomainObjectLayout(titleInCollection=SHOW|HIDE, ...) as a fallback



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1511) [WON'T FIX] bootlint error when attempting to view an object with no perms

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1511:
--
Fix Version/s: (was: 2.8.0)
   2.0.0-M3
  Summary: [WON'T FIX] bootlint error when attempting to view an object 
with no perms  (was: bootlint error when attempting to view an object with no 
perms)

> [WON'T FIX] bootlint error when attempting to view an object with no perms
> --
>
> Key: ISIS-1511
> URL: https://issues.apache.org/jira/browse/ISIS-1511
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Attachments: Screen Shot 2016-10-04 at 17.10.49.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1511) [WON'T FIX] bootlint error when attempting to view an object with no perms

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1511.
-
Resolution: Won't Fix

> [WON'T FIX] bootlint error when attempting to view an object with no perms
> --
>
> Key: ISIS-1511
> URL: https://issues.apache.org/jira/browse/ISIS-1511
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Attachments: Screen Shot 2016-10-04 at 17.10.49.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1489) Rename @Property(notPersisted=...) to @Property(mementoSerialization=...)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1489.
-
Resolution: Fixed

> Rename @Property(notPersisted=...) to @Property(mementoSerialization=...)
> -
>
> Key: ISIS-1489
> URL: https://issues.apache.org/jira/browse/ISIS-1489
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> In which case, the attribute should be deprecated, and a new 
> @Property(notAudited=true) be introduced to replace it.
> It's used by:
> - ChangedObjectServiceInternal to determine if a property has changed; 
> marking it as notPersisted means this functionality is skipped.
> - Memento (which you almost certainly don't use, I think is only used in 
> anger by the Wicket viewer).
> It used to be used by the object persistor for persistence-by-reachability 
> (if notPersisted then don't follow the graph), but I *think* that 
> responsibility is now entirely that of JDO/DN.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1489) Rename @Property(notPersisted=...) to @Property(mementoSerialization=...)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1489:
--
Fix Version/s: (was: 2.0.5)
   2.0.0-M3
  Summary: Rename @Property(notPersisted=...) to 
@Property(mementoSerialization=...)  (was: Rename @Property(notPersisted=...) 
to @Property(notAudited=...))

> Rename @Property(notPersisted=...) to @Property(mementoSerialization=...)
> -
>
> Key: ISIS-1489
> URL: https://issues.apache.org/jira/browse/ISIS-1489
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> In which case, the attribute should be deprecated, and a new 
> @Property(notAudited=true) be introduced to replace it.
> It's used by:
> - ChangedObjectServiceInternal to determine if a property has changed; 
> marking it as notPersisted means this functionality is skipped.
> - Memento (which you almost certainly don't use, I think is only used in 
> anger by the Wicket viewer).
> It used to be used by the object persistor for persistence-by-reachability 
> (if notPersisted then don't follow the graph), but I *think* that 
> responsibility is now entirely that of JDO/DN.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1484) Extend @Parameter, specify a class to obtain the default

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1484:
--
  Component/s: (was: Isis Core)
   Isis Applib (programming model)
Fix Version/s: (was: 2.8.0)
  Summary: Extend @Parameter, specify a class to obtain the default  
(was: Extend @Parameter annotation to provide a class to obtain the default for 
a parameter)

This might overlap with value types?

> Extend @Parameter, specify a class to obtain the default
> 
>
> Key: ISIS-1484
> URL: https://issues.apache.org/jira/browse/ISIS-1484
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> {code}
> public void updateName(
> @Parameter(defaultOf="Foo")  // if can specify an Object???
> @ParameterLayout(named = "New name")
> final String name) {
> setName(newName);
> }
> {code}
> or a more elaborate (over-complicated?) design:
> eg:
> {code}
> public void updateName(
> @Parameter(defaultFrom=ParameterDefaultFromProperty.class
> @ParameterLayout(named = "New name")
> final String name) {
> setName(newName);
> }
> {code}
> where (part of the applib):
> {code}
> public interface ParameterDefaulter {
> Object defaultFor(Object domainObject, String actionName, String 
> parameterName);
> } 
> {code}
> and the applib also provides a default implementation:
> {code}
> public class ParameterDefaultFromProperty implements ParametedDefaulter { ... 
> }
> {code}
> that uses an injected service (from core.runtime) to look up the parameter 
> value from the corresponding property of the object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1488) Blobs and Clobs should be automatically ignored for auditing (also ISIS-1489)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1488:
--
Fix Version/s: (was: 2.1.4)

> Blobs and Clobs should be automatically ignored for auditing (also ISIS-1489)
> -
>
> Key: ISIS-1488
> URL: https://issues.apache.org/jira/browse/ISIS-1488
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> At the moment the work-around is to annotate with 
> @Property(notPersisted=true).
> See also ISIS-1489 re: the naming of this attribute.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1484) Extend @Parameter, specify a class to obtain the default

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1484:
--
Component/s: Isis Core

> Extend @Parameter, specify a class to obtain the default
> 
>
> Key: ISIS-1484
> URL: https://issues.apache.org/jira/browse/ISIS-1484
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model), Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> {code}
> public void updateName(
> @Parameter(defaultOf="Foo")  // if can specify an Object???
> @ParameterLayout(named = "New name")
> final String name) {
> setName(newName);
> }
> {code}
> or a more elaborate (over-complicated?) design:
> eg:
> {code}
> public void updateName(
> @Parameter(defaultFrom=ParameterDefaultFromProperty.class
> @ParameterLayout(named = "New name")
> final String name) {
> setName(newName);
> }
> {code}
> where (part of the applib):
> {code}
> public interface ParameterDefaulter {
> Object defaultFor(Object domainObject, String actionName, String 
> parameterName);
> } 
> {code}
> and the applib also provides a default implementation:
> {code}
> public class ParameterDefaultFromProperty implements ParametedDefaulter { ... 
> }
> {code}
> that uses an injected service (from core.runtime) to look up the parameter 
> value from the corresponding property of the object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1487) [WON'T FIX] Extend the framework's metamodel to be able to render List>

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1487:
--
Fix Version/s: (was: 2.9.0)
   2.0.0-M3
  Summary: [WON'T FIX] Extend the framework's metamodel to be able to 
render List>  (was: Extend the framework's metamodel to be 
able to render List>)

no business driver for this.

> [WON'T FIX] Extend the framework's metamodel to be able to render 
> List>
> --
>
> Key: ISIS-1487
> URL: https://issues.apache.org/jira/browse/ISIS-1487
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> To support this dynamic requirement, the framework (as currently architected) 
> would need to build an ObjectSpecification based on the Map instances being 
> rendered, whose structure is inferred from the members of that Map. 
> I could imagine it would be possible to do, but would require some work 
> within the SpecificationLoader.  For example, perhaps the special-case 
> handling here [2] could be extended to return a MapSpecification that handles 
> the dynamic stuff... the issue though is that it would need to be told about 
> a particular Map to look into.  It would be hacky, but maybe putting the Map 
> in question onto a ThreadLocal would suffice.  
> [2] 
> https://github.com/apache/isis/blob/master/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoader.java#L401



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1487) [WON'T FIX] Extend the framework's metamodel to be able to render List>

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1487.
-
Resolution: Won't Fix

> [WON'T FIX] Extend the framework's metamodel to be able to render 
> List>
> --
>
> Key: ISIS-1487
> URL: https://issues.apache.org/jira/browse/ISIS-1487
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Core
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> To support this dynamic requirement, the framework (as currently architected) 
> would need to build an ObjectSpecification based on the Map instances being 
> rendered, whose structure is inferred from the members of that Map. 
> I could imagine it would be possible to do, but would require some work 
> within the SpecificationLoader.  For example, perhaps the special-case 
> handling here [2] could be extended to return a MapSpecification that handles 
> the dynamic stuff... the issue though is that it would need to be told about 
> a particular Map to look into.  It would be hacky, but maybe putting the Map 
> in question onto a ThreadLocal would suffice.  
> [2] 
> https://github.com/apache/isis/blob/master/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoader.java#L401



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1479) DataNucleus data type mapping for streams (to support direct upload of large BLOBs)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1479:
--
  Component/s: (was: Isis Core)
   Isis Persistence JDO
Fix Version/s: (was: 2.5.0)

> DataNucleus data type mapping for streams (to support direct upload of large 
> BLOBs)
> ---
>
> Key: ISIS-1479
> URL: https://issues.apache.org/jira/browse/ISIS-1479
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Persistence JDO
>Affects Versions: 1.13.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> from http://markmail.org/message/64xcc7twcxdrhfqj
> > With respect to the storage of the BLOBs themselves, I don't think (at
> > least I couldn't find) any datatype mapping to be able to map from a stream
> > (obtained from ServletInputStream) into a JDO entity, ie to avoid the
> > creation of the BLOB in-memory.  If it *were* possible, then I don't think
> > Isis would care; just map the property as @Programmatic and Isis would
> > ignore it.  Perhaps Andy might be able to chip in on this?
> java.io.File is currently the only java field type with a mapping that is 
> streamable. See
> http://www.datanucleus.org/products/accessplatform_5_0/jdo/types.html#Other_Types
> Somebody could take existing code used for that type and contribute a mapping 
> for some other java type.
> https://github.com/datanucleus/datanucleus-rdbms/blob/master/src/main/java/org/datanucleus/store/rdbms/mapping/datastore/BinaryStreamRDBMSMapping.java



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1439) Handle default methods defined in interfaces (JDK8)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1439:
--
Fix Version/s: (was: 2.9.0)
   2.0.0-M3

I think this is handled ... ?

> Handle default methods defined in interfaces (JDK8)
> ---
>
> Key: ISIS-1439
> URL: https://issues.apache.org/jira/browse/ISIS-1439
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> For example, IsisConfigurationDefault service has spliterator() and 
> forEach(), by virtue of implementing Iterator interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1456) [WON'T FIX] Replace WithTransactionScope in applib to instead support @TransactionScoped

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1456:
--
Fix Version/s: (was: 2.3.0)
   2.0.0-M3
  Summary: [WON'T FIX] Replace WithTransactionScope in applib to 
instead support @TransactionScoped  (was: Replace WithTransactionScope in 
applib to instead support @TransactionScoped)

we don't seem to get this stuff for free just by being on Spring Boot, so 
there's nothing to be gained here.

> [WON'T FIX] Replace WithTransactionScope in applib to instead support 
> @TransactionScoped
> 
>
> Key: ISIS-1456
> URL: https://issues.apache.org/jira/browse/ISIS-1456
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1439) Handle default methods defined in interfaces (JDK8)

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1439.
-
Resolution: Fixed

> Handle default methods defined in interfaces (JDK8)
> ---
>
> Key: ISIS-1439
> URL: https://issues.apache.org/jira/browse/ISIS-1439
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> For example, IsisConfigurationDefault service has spliterator() and 
> forEach(), by virtue of implementing Iterator interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1431) Enhance deep linking to action prompts or action invocation results.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1431:
--
  Component/s: (was: Isis Core)
   Isis Viewer Wicket
Fix Version/s: (was: 2.9.0)

> Enhance deep linking to action prompts or action invocation results.
> 
>
> Key: ISIS-1431
> URL: https://issues.apache.org/jira/browse/ISIS-1431
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Viewer Wicket
>Affects Versions: 1.12.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> We can create deep links to domain objects, and we can bookmark action 
> invocations, but we can't do deep links to action invocations.
> It would also be nice to have deep links to action prompts. If parameter 
> arguments are supplied, then invoke the action, else render the prompt.  
> Perhaps also a "special" query parameter might be used to support partial 
> completion of arguments, letting the user see the prompt and hit OK for 
> themselves.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1451) SessionManagement#nextSession does not close off the current Interaction's execution graph.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1451:
--
Fix Version/s: (was: 2.10.0)
   2.0.0-M4

> SessionManagement#nextSession does not close off the current Interaction's 
> execution graph.
> ---
>
> Key: ISIS-1451
> URL: https://issues.apache.org/jira/browse/ISIS-1451
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.2
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> This is somewhat of a corner case, but if SessionManagementService's 
> nextSession() method is called -- within an action -- then this ought to 
> (somehow) gracefully close off the current interaction in order to set up a 
> new interaction.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1271) DataNucleus NamingProvider to remove some boilerplate.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1271:
--
  Component/s: (was: Isis Core)
   Isis Persistence JDO
Fix Version/s: (was: 2.2.0)
  Description: By default, adds "_OID" as a suffix, necessitating the 
specification of the explicit name, eg @Column(name="customer_id"), everywhere.
 Priority: Minor  (was: Major)
  Summary: DataNucleus NamingProvider to remove some boilerplate.  
(was: Implement a DataNucleus NamingProvider for Isis apps in order to remove 
some boilerplate.)

> DataNucleus NamingProvider to remove some boilerplate.
> --
>
> Key: ISIS-1271
> URL: https://issues.apache.org/jira/browse/ISIS-1271
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Persistence JDO
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> By default, adds "_OID" as a suffix, necessitating the specification of the 
> explicit name, eg @Column(name="customer_id"), everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1536) BackgroundService should fail-fast if there is no BackgroundCommandService implementation available to persist the command.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1536:
--
Fix Version/s: (was: 2.7.0)
   2.0.0-M4

> BackgroundService should fail-fast if there is no BackgroundCommandService 
> implementation available to persist the command.
> ---
>
> Key: ISIS-1536
> URL: https://issues.apache.org/jira/browse/ISIS-1536
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.13.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1403) [WON'T FIX] Suggest changed the web.xml to newer Servlet Deployment Descriptor - version 3.1 and added absolute-ordering element

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1403.
-
Resolution: Fixed

> [WON'T FIX] Suggest  changed the web.xml to newer Servlet Deployment 
> Descriptor - version 3.1 and added absolute-ordering element
> -
>
> Key: ISIS-1403
> URL: https://issues.apache.org/jira/browse/ISIS-1403
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> as raised in comment on ISIS-1358... 
> Hi Jörg, I tried out your proposal but stil without success. After googling 
> I've found next issue with similar problem 
> https://issues.apache.org/jira/browse/AMQ-6154
> Then I've changed the web.xml to newer Servlet Deployment Descriptor - 
> version 3.1 and added absolute-ordering element. After that, I've redeployed 
> war to Tomcat 8.0.33 and simpleapp works now fine!
> @Dan Haywood: maybe this should be adapted in simpleapp archetype as well?
> http://xmlns.jcp.org/xml/ns/javaee;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee 
> http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd;
>  version="3.1">
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1403) [WON'T FIX] Suggest changed the web.xml to newer Servlet Deployment Descriptor - version 3.1 and added absolute-ordering element

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1403:
--
Fix Version/s: (was: 2.4.0)
   2.0.0-M3
  Summary: [WON'T FIX] Suggest  changed the web.xml to newer Servlet 
Deployment Descriptor - version 3.1 and added absolute-ordering element  (was: 
[DUPLICATE] Suggest  changed the web.xml to newer Servlet Deployment Descriptor 
- version 3.1 and added absolute-ordering element)

This has been superceded by move to Spring Boot.  There is no web.xml anymore, 
instead we use SB's ServletRegistration and FilterRegistration mechanisms (we 
wrap them up with our own WebModule service/abstraction).

 

> [WON'T FIX] Suggest  changed the web.xml to newer Servlet Deployment 
> Descriptor - version 3.1 and added absolute-ordering element
> -
>
> Key: ISIS-1403
> URL: https://issues.apache.org/jira/browse/ISIS-1403
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.12.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> as raised in comment on ISIS-1358... 
> Hi Jörg, I tried out your proposal but stil without success. After googling 
> I've found next issue with similar problem 
> https://issues.apache.org/jira/browse/AMQ-6154
> Then I've changed the web.xml to newer Servlet Deployment Descriptor - 
> version 3.1 and added absolute-ordering element. After that, I've redeployed 
> war to Tomcat 8.0.33 and simpleapp works now fine!
> @Dan Haywood: maybe this should be adapted in simpleapp archetype as well?
> http://xmlns.jcp.org/xml/ns/javaee;
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee 
> http://xmlns.jcp.org/xml/ns/javaee/web-app_3_1.xsd;
>  version="3.1">
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1360) Declarative Invariants

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1360:
--
  Component/s: (was: Isis Persistence JDO)
   (was: Isis Core)
   Isis Incubator
Fix Version/s: (was: 3.0.0)

> Declarative Invariants
> --
>
> Key: ISIS-1360
> URL: https://issues.apache.org/jira/browse/ISIS-1360
> Project: Isis
>  Issue Type: Proposal
>  Components: Isis Incubator
>Affects Versions: 1.12.0
>Reporter: Cesar Lugo
>Priority: Minor
>
> I think that one aspect of the amplification concept Apache ISIS provides 
> might be to allow some degree of declarative business rules / invariants. 
> There is an interesting open source project (1) that allows a Java 
> application to define declarative business rules / invariant you might want 
> to fork.
>  
> The difference between some other business rules engines (say RETE compliant) 
> is that most business rules engines focus on conditional business rules or 
> decision business rules only, and work outside the application scope, as an 
> external API returning results that you must incorporate into your code with 
> even more code. This one´s focus (ABL) is transactional business rules, which 
> work through the persistence manager (Hibernate´s JPA in this case), so you 
> don´t need to call any rules to be triggered, rules are automatically 
> triggered when you persist data. Thus, it lets you use the previous values 
> before saving and after saving to trigger rules (update inventory with new 
> value of received quantity - old value of received quantity + old value of 
> inventory).
>  
> In summary, it provides:
> •Declarative rules, like: 
> o   InvoiceItem.amount = InvoiceItem.quantity * InvoiceItem.unitPrice * (1 + 
> VAT / 100)
> o   Invoice.amount = sum(InvoiceItem.amount) if InvoiceItem.status != 
> “deleted”
> o   account balance = sum(invoice.amount) if status = “due
> •Automatic sequencing of the rules. This is really great, because 
> instead of sequenced lines of code, you create independent rules, which you 
> can maintain and change completely separate from all other rules. You can 
> even have a rules manager and document each rule.
> •Automatic execution of the rules every time you do an insert, update 
> or delete to any of those entity objects. Any change executes the rules 
> properly. If a new rule implies altering the sequence of the execution of 
> rules, this happens automatically and seamlessly. 
> •Extensibility (create your own rules). Create a new weightedAverage 
> () rule. 
> •Documentation. You can document your rules, associate rules to topic 
> or groups, like use cases where they come from.
>  
>  
> (1)http://www.automatedbusinesslogic.com/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1388) Introduce @PropertyLayout(columnOrder=...) to make order of properties (when shown in tables) more predictable.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1388:
--
  Component/s: (was: Isis Core)
   Isis Applib (programming model)
Fix Version/s: (was: 2.1.4)

> Introduce @PropertyLayout(columnOrder=...) to make order of properties (when 
> shown in tables) more predictable.  
> -
>
> Key: ISIS-1388
> URL: https://issues.apache.org/jira/browse/ISIS-1388
> Project: Isis
>  Issue Type: New Feature
>  Components: Isis Applib (programming model)
>Affects Versions: 1.12.1
>Reporter: Daniel Keir Haywood
>Priority: Major
>
> At the moment it can be hard to predict, because the BS3Grid is traversed by 
> type, eg:
> {code}
> private void traverseCols(final Grid.Visitor visitor, final BS3Row 
> bs3Row) {
> final BS3Grid.Visitor bs3Visitor = asBs3Visitor(visitor);
> final List cols = bs3Row.getCols();
> for (BS3RowContent rowContent : Lists.newArrayList(cols)) {
> rowContent.setOwner(bs3Row);
> if(rowContent instanceof BS3Col) {
> final BS3Col bs3Col = (BS3Col) rowContent;
> bs3Visitor.preVisit(bs3Col);
> bs3Visitor.visit(bs3Col);
> traverseDomainObject(bs3Col, visitor);
> traverseTabGroups(bs3Col, visitor);
> traverseActions(bs3Col, visitor);
> traverseFieldSets(bs3Col, visitor);
> traverseCollections(bs3Col, visitor);
> traverseRows(bs3Col, visitor);
> bs3Visitor.postVisit(bs3Col);
> } else if (rowContent instanceof BS3ClearFix) {
> final BS3ClearFix bs3ClearFix = (BS3ClearFix) rowContent;
> bs3Visitor.visit(bs3ClearFix);
> } else {
> throw new IllegalStateException(
> "Unrecognized implementation of BS3RowContent, " + 
> rowContent);
> }
> }
> }
> {code}
> Instead, if it were traversed by element order, then the ordering of 
> properties would be more predictable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1339) Simplify/unify session and xactn management for Wicket viewer and RO viewer

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1339:
--
Fix Version/s: (was: 2.4.0)
   2.0.0-M3

I think this is more-or-less addressed.

> Simplify/unify session and xactn management for Wicket viewer and RO viewer
> ---
>
> Key: ISIS-1339
> URL: https://issues.apache.org/jira/browse/ISIS-1339
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core, Isis Viewer RO, Isis Viewer Wicket
>Affects Versions: 1.11.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Move the responsibility for session management / xactn mgmt out into a 
> filter, and remove corresponding functionality within Wicket viewer's 
> RequestCycle.
> ~~~
> in a little more detail:
> move bootstrapping out of IsisWicketApplication and into 
> IsisWebAppBootstrapper
> - by filters (pick up from ServletRequest)
>   - replace by binding IsisSessionFactory
>   - final IsisSystem system = (IsisSystem) 
> servletContext.getAttribute(WebAppConstants.ISIS_SYSTEM_KEY);
> - from RO viewer (pick up from ServletRequest)
> - from at least some of the Wicket viewer (top-level application stuff, 
> WebRequestCycle etc,... pick up from ServletRequest)
> ~~~
> also:
> remove 
> WebAppConstants.HTTP_SESSION_LOGGED_ON_PREVIOUSLY_USING_LOGON_FIXTURE_KEY and 
> LogonFixture, since not currently supported and no-one has missed it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1354) Wicket viewer should have a pluggable SPI service instead of AccountConfirmationMap

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1354:
--
  Component/s: (was: Isis Core)
   Isis Viewer Wicket
Fix Version/s: (was: 2.1.4)

> Wicket viewer should have a pluggable SPI service instead of 
> AccountConfirmationMap
> ---
>
> Key: ISIS-1354
> URL: https://issues.apache.org/jira/browse/ISIS-1354
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Affects Versions: 1.12.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1339) Simplify/unify session and xactn management for Wicket viewer and RO viewer

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1339.
-
Resolution: Fixed

> Simplify/unify session and xactn management for Wicket viewer and RO viewer
> ---
>
> Key: ISIS-1339
> URL: https://issues.apache.org/jira/browse/ISIS-1339
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core, Isis Viewer RO, Isis Viewer Wicket
>Affects Versions: 1.11.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> Move the responsibility for session management / xactn mgmt out into a 
> filter, and remove corresponding functionality within Wicket viewer's 
> RequestCycle.
> ~~~
> in a little more detail:
> move bootstrapping out of IsisWicketApplication and into 
> IsisWebAppBootstrapper
> - by filters (pick up from ServletRequest)
>   - replace by binding IsisSessionFactory
>   - final IsisSystem system = (IsisSystem) 
> servletContext.getAttribute(WebAppConstants.ISIS_SYSTEM_KEY);
> - from RO viewer (pick up from ServletRequest)
> - from at least some of the Wicket viewer (top-level application stuff, 
> WebRequestCycle etc,... pick up from ServletRequest)
> ~~~
> also:
> remove 
> WebAppConstants.HTTP_SESSION_LOGGED_ON_PREVIOUSLY_USING_LOGON_FIXTURE_KEY and 
> LogonFixture, since not currently supported and no-one has missed it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1349) ExceptionRecognizers not supported in RO, eg if create duplicate row then get a 500

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1349:
--
  Component/s: (was: Isis Core)
   Isis Viewer RO
Fix Version/s: (was: 2.9.0)

> ExceptionRecognizers not supported in RO, eg if create duplicate row then get 
> a 500
> ---
>
> Key: ISIS-1349
> URL: https://issues.apache.org/jira/browse/ISIS-1349
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer RO
>Affects Versions: 1.11.1
>Reporter: Daniel Keir Haywood
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1307) Integrating User Help Documentation

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1307:
--
  Component/s: (was: Isis Core)
   Isis Viewer Wicket
Fix Version/s: (was: 2.1.4)

> Integrating User Help Documentation
> ---
>
> Key: ISIS-1307
> URL: https://issues.apache.org/jira/browse/ISIS-1307
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Steve Cameron
>Priority: Minor
>
> At the moment there is the @PropertyLayout#describedAs() attribute for 
> providing help 'hints' to users. I am wondering if there could be added a 
> more detailed help information being provide to a user pressing F1 key?
> More specifically to design a mechanism for help documentation to be 
> navigated to (into) from the Isis Wicket viewer interface in a context 
> sensitive way.
> Broadening this further still, maybe there is a good way to keep user 
> documentation embedded within the Java domain object class files and to 
> generate formatted user help documents in a similar way that Javadoc is 
> generated? 
> I've done a little research on this approach but cannot find an example of 
> where this has been done, but to my mind it seems natural as a Naked Objects 
> way to do it. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1289) [WON'T FIX] for JAXB view models, implement member ordering from the @XmlType#propOrder attribute and other semantics.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood closed ISIS-1289.
-
Fix Version/s: 2.0.0-M3
   Resolution: Won't Fix

> [WON'T FIX] for JAXB view models, implement member ordering from the 
> @XmlType#propOrder attribute and other semantics.
> --
>
> Key: ISIS-1289
> URL: https://issues.apache.org/jira/browse/ISIS-1289
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.11.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M3
>
>
> also to support other constraints (e.g min or max length of xs:string types).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1289) [WON'T FIX] for JAXB view models, implement member ordering from the @XmlType#propOrder attribute and other semantics.

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1289:
--
Fix Version/s: (was: 2.11.0)
  Summary: [WON'T FIX] for JAXB view models, implement member ordering 
from the @XmlType#propOrder attribute and other semantics.  (was: for JAXB view 
models, implement member ordering from the @XmlType#propOrder attribute and 
other semantics.)

> [WON'T FIX] for JAXB view models, implement member ordering from the 
> @XmlType#propOrder attribute and other semantics.
> --
>
> Key: ISIS-1289
> URL: https://issues.apache.org/jira/browse/ISIS-1289
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.11.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> also to support other constraints (e.g min or max length of xs:string types).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1286) Extend the RoutingService to provide more information, eg a context

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1286:
--
  Component/s: (was: Isis Core)
   Isis Applib (programming model)
Fix Version/s: (was: 2.1.4)

> Extend the RoutingService to provide more information, eg a context
> ---
>
> Key: ISIS-1286
> URL: https://issues.apache.org/jira/browse/ISIS-1286
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model)
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Major
>
> so is passed a Context object, containing:
> - the object that was invoked on
> - whether this object is now deleted
> - breadcrumb trail of previously visited objects.
> - the home page, if any



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-1285) [WON'T FIX] Provide the capability to disable the browser's back button/

2020-03-19 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood updated ISIS-1285:
--
Fix Version/s: (was: 2.9.0)
  Summary: [WON'T FIX] Provide the capability to disable the browser's 
back button/  (was: Provide the capability to disable the browser's back 
button/)

The long-term "solution" for this will be the Vaadin viewer.

> [WON'T FIX] Provide the capability to disable the browser's back button/
> 
>
> Key: ISIS-1285
> URL: https://issues.apache.org/jira/browse/ISIS-1285
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 1.10.0
>Reporter: Daniel Keir Haywood
>Priority: Minor
>
> In the Estatio app (and presumably many others, too), when the user deletes 
> an object then they are shown the "no results" page.
> What we have observed the user then do is to press the back button.  This 
> navigates them to the object just deleted; because it has been deleted, the 
> Wicket viewer shows them an error page. 
> With the RoutingService (introduced in 1.11.0) we have the opportunity to 
> route the user to some other "more useful" object, eg the parent of the 
> deleted object, or some other object recently visited, or the home page.
> Even so, if the user does press the back button, they would still see the 
> same message.
> This ticket is therefore to provide an optional capability to have the back 
> button disabled.  Think it should be optional because not everyone (every 
> programmer) will agree that back buttons should be disabled and in any case 
> for some use cases, eg in read-only app, a back button is probably a good 
> thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   4   5   6   >