[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156203#comment-17156203
 ] 

ASF subversion and git services commented on ISIS-2401:
---

Commit 2528994e9466fa68897c5df262198f0d9eeea4e9 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2528994 ]

ISIS-2401: polishing new ObjectSerializer

> Memento creation/recreation roundtrip might get confused when processing 
> Value Types
> 
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object 
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
>  at 
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
>  ~[classes/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156123#comment-17156123
 ] 

ASF subversion and git services commented on ISIS-2401:
---

Commit 0ef5caae0fcc836b0ba855dcbe574586f6bf52d8 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0ef5caa ]

ISIS-2401: lombok build issue: don't use val in enum bodys

> Memento creation/recreation roundtrip might get confused when processing 
> Value Types
> 
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object 
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
>  at 
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
>  ~[classes/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156119#comment-17156119
 ] 

ASF subversion and git services commented on ISIS-2401:
---

Commit 564ba58a57675c35cee2da52e4b43646b15e3e45 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=564ba58 ]

ISIS-2401: wkt: properly select type marshalling strategy based on
object's spec

adds a plain old java serialization fallback strategy,
to be used if all the others fail

also fail early with some usable info, if strategy selection goes wrong


> Memento creation/recreation roundtrip might get confused when processing 
> Value Types
> 
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object 
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
>  at 
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
>  ~[classes/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types

2020-07-11 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber resolved ISIS-2401.
--
Resolution: Fixed

> Memento creation/recreation roundtrip might get confused when processing 
> Value Types
> 
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object 
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
>  at 
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
>  ~[classes/:?]
>  at 
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
>  ~[classes/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types

2020-07-11 Thread Andi Huber (Jira)
Andi Huber created ISIS-2401:


 Summary: Memento creation/recreation roundtrip might get confused 
when processing Value Types
 Key: ISIS-2401
 URL: https://issues.apache.org/jira/browse/ISIS-2401
 Project: Isis
  Issue Type: Bug
  Components: Isis Viewer Wicket
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M4


Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
{noformat}
Caused by: java.lang.IllegalArgumentException: need an id to lookup an object 
specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
 at 
org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
 ~[classes/:?]
 at 
org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
 ~[classes/:?]
 at 
org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
 ~[classes/:?]
 at 
org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
 ~[classes/:?]{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156037#comment-17156037
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit b20cd08ae5e2f41a4364dbc84bd7564b70dc17c9 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b20cd08 ]

ISIS-2340: vaa: adds homepage (as already in fx)

(on startup and when clicking the branding icon)

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2342) Client Kroviz: UI Polishing

2020-07-11 Thread Jira


 [ 
https://issues.apache.org/jira/browse/ISIS-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörg Rade resolved ISIS-2342.
-
Resolution: Fixed

Remainders to be traced via separate issues.

> Client Kroviz: UI Polishing
> ---
>
> Key: ISIS-2342
> URL: https://issues.apache.org/jira/browse/ISIS-2342
> Project: Isis
>  Issue Type: Task
>  Components: Isis Client Kroviz
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> * align Buttons in Dialogs with parent bottom (/)
>  * make multiline text boxes size with parent (/)
>  * avoid multiple scrollbars (/)
>  * add notifications to StatusBar (/)
>  * turn user icon into Button (/)
>  * add actions to StatusBar Buttons (/)
>  * in DiagramPanel:
>  ** use buttons to scale image (/)
>  ** make Dialogs transparent on move (/)
>  ** use available space after resize (enlarge/shrink) (/)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2342) Client Kroviz: UI Polishing

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155974#comment-17155974
 ] 

ASF subversion and git services commented on ISIS-2342:
---

Commit 502899c077bc7e2aa77d2588f0d28d31367cc60c in isis's branch 
refs/heads/master from Jörg Rade
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=502899c ]

ISIS-2342 createImage/Svg differentiated, sample for interactive SVG (not fully 
working though), better names, cleanup images


> Client Kroviz: UI Polishing
> ---
>
> Key: ISIS-2342
> URL: https://issues.apache.org/jira/browse/ISIS-2342
> Project: Isis
>  Issue Type: Task
>  Components: Isis Client Kroviz
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> * align Buttons in Dialogs with parent bottom (/)
>  * make multiline text boxes size with parent (/)
>  * avoid multiple scrollbars (/)
>  * add notifications to StatusBar (/)
>  * turn user icon into Button (/)
>  * add actions to StatusBar Buttons (/)
>  * in DiagramPanel:
>  ** use buttons to scale image (/)
>  ** make Dialogs transparent on move (/)
>  ** use available space after resize (enlarge/shrink) (/)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2342) Client Kroviz: UI Polishing

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155972#comment-17155972
 ] 

ASF subversion and git services commented on ISIS-2342:
---

Commit 3442d2b2df9537b1b4f80a33ee3a753e6c00578a in isis's branch 
refs/heads/master from Jörg Rade
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3442d2b ]

ISIS-2342 Use OSM/leafleft alongside handcoded scaling solution for displaying 
SVG's


> Client Kroviz: UI Polishing
> ---
>
> Key: ISIS-2342
> URL: https://issues.apache.org/jira/browse/ISIS-2342
> Project: Isis
>  Issue Type: Task
>  Components: Isis Client Kroviz
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> * align Buttons in Dialogs with parent bottom (/)
>  * make multiline text boxes size with parent (/)
>  * avoid multiple scrollbars (/)
>  * add notifications to StatusBar (/)
>  * turn user icon into Button (/)
>  * add actions to StatusBar Buttons (/)
>  * in DiagramPanel:
>  ** use buttons to scale image (/)
>  ** make Dialogs transparent on move (/)
>  ** use available space after resize (enlarge/shrink) (/)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2342) Client Kroviz: UI Polishing

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155973#comment-17155973
 ] 

ASF subversion and git services commented on ISIS-2342:
---

Commit 8df9019b2bf846eff3b85fbf11e3113a8449ef1a in isis's branch 
refs/heads/master from Jörg Rade
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8df9019 ]

ISIS-2342 extensions to createImage(Field), About, ASF(c)


> Client Kroviz: UI Polishing
> ---
>
> Key: ISIS-2342
> URL: https://issues.apache.org/jira/browse/ISIS-2342
> Project: Isis
>  Issue Type: Task
>  Components: Isis Client Kroviz
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> * align Buttons in Dialogs with parent bottom (/)
>  * make multiline text boxes size with parent (/)
>  * avoid multiple scrollbars (/)
>  * add notifications to StatusBar (/)
>  * turn user icon into Button (/)
>  * add actions to StatusBar Buttons (/)
>  * in DiagramPanel:
>  ** use buttons to scale image (/)
>  ** make Dialogs transparent on move (/)
>  ** use available space after resize (enlarge/shrink) (/)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155902#comment-17155902
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit f2fe9fb598106bbc3011d3fb835200c9639130f2 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f2fe9fb ]

ISIS-2340: fx: new menu section labels

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2340) New common UI Model Module

2020-07-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155899#comment-17155899
 ] 

ASF subversion and git services commented on ISIS-2340:
---

Commit 9a2bcfb2c21a3d67d5ff5a4a19d2a9bb360d9f77 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9a2bcfb ]

ISIS-2340: vaa: new menu section labels (also proper spacing CSS)

> New common UI Model Module
> --
>
> Key: ISIS-2340
> URL: https://issues.apache.org/jira/browse/ISIS-2340
> Project: Isis
>  Issue Type: New Feature
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Consolidate code that is common to all viewers into a new module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)