[jira] [Commented] (ISIS-2423) Persisted callback and PublisherService#changedObjects are not called, instead appear as updates.

2020-08-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181687#comment-17181687
 ] 

ASF subversion and git services commented on ISIS-2423:
---

Commit 4203e19bb208e7a90840b46a36a70f141522abef in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=4203e19 ]

ISIS-2423: fixes persisting callback (in preStore/postStore)


> Persisted callback and PublisherService#changedObjects are not called, 
> instead appear as updates.
> -
>
> Key: ISIS-2423
> URL: https://issues.apache.org/jira/browse/ISIS-2423
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Core
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Due to use of EntityUtil.isAttached(...) in the 
> PersistenceSession5#enlistCreated... method, rather than checking our own 
> Oid.  In this particular case they were not equivalent.
> Fix:
> - was able to simplify and remove some redundant code, using instead
> persistable.dnGetStateManager().isNew(persistable)
> as the mechanism to determine in preStore/postStore whether we are dealing 
> within an insert or an update.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2222) Flesh out demo app with extra examples.

2020-08-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181688#comment-17181688
 ] 

ASF subversion and git services commented on ISIS-:
---

Commit f16da7fe6714cdf516fb9e84b366932569ed0337 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f16da7f ]

ISIS-: wip for @DomainObject#publishing (demo now works, just docs to tidy 
up).


> Flesh out demo app with extra examples.
> ---
>
> Key: ISIS-
> URL: https://issues.apache.org/jira/browse/ISIS-
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Examples
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2423) Persisted callback and PublisherService#changedObjects are not called, instead appear as updates.

2020-08-21 Thread Daniel Keir Haywood (Jira)
Daniel Keir Haywood created ISIS-2423:
-

 Summary: Persisted callback and PublisherService#changedObjects 
are not called, instead appear as updates.
 Key: ISIS-2423
 URL: https://issues.apache.org/jira/browse/ISIS-2423
 Project: Isis
  Issue Type: Bug
  Components: Isis Core
Affects Versions: 2.0.0-M3
Reporter: Daniel Keir Haywood
Assignee: Daniel Keir Haywood
 Fix For: 2.0.0-M4


Due to use of EntityUtil.isAttached(...) in the 
PersistenceSession5#enlistCreated... method, rather than checking our own Oid.  
In this particular case they were not equivalent.

Fix:

- was able to simplify and remove some redundant code, using instead

persistable.dnGetStateManager().isNew(persistable)

as the mechanism to determine in preStore/postStore whether we are dealing 
within an insert or an update.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)