[ 
https://issues.apache.org/jira/browse/ISIS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-85.
---------------------------

    Assignee: Dan Haywood

prior to generating 1.0.0 release notes
                
> Convert HelpFacetDecorator into a HelpFacetFactory
> --------------------------------------------------
>
>                 Key: ISIS-85
>                 URL: https://issues.apache.org/jira/browse/ISIS-85
>             Project: Isis
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.1.2-incubating
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>
> Looking at the code, it seems that we never create HelpFacets through 
> FacetFactory.  So neither the HelpFacetDecorator nor the I18NFacetDecorator 
> looks like they will ever install help, because both require there to be an 
> underlying HelpFacet to decorate.
> Moreover, there is a duplication between the I18 facet decorator and the help 
> decorator, in that they both install help facets.  
> I think a good first step would be to make the HelpFacetDecorator into a 
> regular HelpFacetFactory.  At least then the role of i18nFacetDecorator will 
> be well-defined.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to