[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[ https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363995#comment-16363995 ] ASF subversion and git services commented on ISIS-1829: --- Commit b892b97f026a0f83c984b8a1fce8e8a434ea3ecd in isis's branch refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b892b97 ] ISIS-1829: extracts methods to make flow easier to follow > AppManifestAbstract#withFixtureScripts no longer works. > --- > > Key: ISIS-1829 > URL: https://issues.apache.org/jira/browse/ISIS-1829 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > workaround is to use overrideFixtureScripts > I also think that the inverse of using overrideConfigurationProperties is > broken in 1.16.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[ https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363993#comment-16363993 ] ASF subversion and git services commented on ISIS-1829: --- Commit 6eb767fd80500f9ef6157009d3022d81420b86bd in isis's branch refs/heads/ISIS-1852_parallel_stream_patch from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6eb767f ] ISIS-1829: adds condition for a builder that inherits from AppManifestAbstract2.Builder > AppManifestAbstract#withFixtureScripts no longer works. > --- > > Key: ISIS-1829 > URL: https://issues.apache.org/jira/browse/ISIS-1829 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > workaround is to use overrideFixtureScripts > I also think that the inverse of using overrideConfigurationProperties is > broken in 1.16.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[ https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363964#comment-16363964 ] ASF subversion and git services commented on ISIS-1829: --- Commit 6eb767fd80500f9ef6157009d3022d81420b86bd in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6eb767f ] ISIS-1829: adds condition for a builder that inherits from AppManifestAbstract2.Builder > AppManifestAbstract#withFixtureScripts no longer works. > --- > > Key: ISIS-1829 > URL: https://issues.apache.org/jira/browse/ISIS-1829 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > workaround is to use overrideFixtureScripts > I also think that the inverse of using overrideConfigurationProperties is > broken in 1.16.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[ https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362635#comment-16362635 ] ASF subversion and git services commented on ISIS-1829: --- Commit 6eb767fd80500f9ef6157009d3022d81420b86bd in isis's branch refs/heads/maint-1.16.1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6eb767f ] ISIS-1829: adds condition for a builder that inherits from AppManifestAbstract2.Builder > AppManifestAbstract#withFixtureScripts no longer works. > --- > > Key: ISIS-1829 > URL: https://issues.apache.org/jira/browse/ISIS-1829 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > workaround is to use overrideFixtureScripts > I also think that the inverse of using overrideConfigurationProperties is > broken in 1.16.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[ https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362636#comment-16362636 ] ASF subversion and git services commented on ISIS-1829: --- Commit b892b97f026a0f83c984b8a1fce8e8a434ea3ecd in isis's branch refs/heads/maint-1.16.1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b892b97 ] ISIS-1829: extracts methods to make flow easier to follow > AppManifestAbstract#withFixtureScripts no longer works. > --- > > Key: ISIS-1829 > URL: https://issues.apache.org/jira/browse/ISIS-1829 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > workaround is to use overrideFixtureScripts > I also think that the inverse of using overrideConfigurationProperties is > broken in 1.16.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1829) AppManifestAbstract#withFixtureScripts no longer works.
[
https://issues.apache.org/jira/browse/ISIS-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362600#comment-16362600
]
Dan Haywood commented on ISIS-1829:
---
With kitchensink, using the old AppManifestAbstract2 API, the following works:
{code:java}
public class KitchensinkAppManifestWithFixtures extends KitchensinkAppManifest {
@Override
protected void overrideFixtures(final List
fixtureScripts) {
fixtureScripts.add(KitchensinkSetupFixture.class);
}
}
{code}
but so does:
{code:java}
public class KitchensinkAppManifestWithFixtures extends AppManifestAbstract {
private final static AppManifestAbstract.Builder BUILDER =
KitchensinkAppManifest.BUILDER.withFixtureScripts(KitchensinkSetupFixture.class);
public KitchensinkAppManifestWithFixtures() {
super(BUILDER);
}
}{code}
this is where KitchensinkAppManifest itself uses the old AppManifestAbstract
API:
{code:java}
public class KitchensinkAppManifest extends AppManifestAbstract {
private final static Builder BUILDER =
Builder.forModules(
KitchensinkDomModule.class,
KitchensinkFixtureModule.class,
KitchensinkAppModule.class,
FakeDataModule.class
)
.withAuthMechanism("shiro")
.withConfigurationProperty("isis.foo", "other")
.withConfigurationPropertiesFile(KitchensinkAppManifest.class,
"git.properties");
public KitchensinkAppManifest() {
super(BUILDER);
}
}
{code}
So far so good.
HOWEVER, if refactor KitchensinkAppManifest to use the new AppManifestAbstract2
API:
{code:java}
public class KitchensinkAppManifest extends AppManifestAbstract2 {
final static AppManifestAbstract2.Builder BUILDER =
Builder.forModule(new KitchensinkAppModule()) // in turn
defines transitive dependencies...
.withAdditionalModules(FakeDataModule.class)
.withAuthMechanism("shiro")
.withConfigurationProperty("isis.foo", "other")
.withConfigurationPropertiesFile(KitchensinkAppManifest.class,
"git.properties");
public KitchensinkAppManifest() {
super(BUILDER);
}
}
{code}
and KitchensinkApManifestWithFixtures is basically unchanged:
{code:java}
public class KitchensinkAppManifestWithFixtures extends AppManifestAbstract2 {
private final static AppManifestAbstract2.Builder BUILDER =
KitchensinkAppManifest.BUILDER.withFixtureScripts(KitchensinkSetupFixture.class);
public KitchensinkAppManifestWithFixtures() {
super(BUILDER);
}
}{code}
then this DOES NOT work.
but the workaround:
{code:java}
public class KitchensinkAppManifestWithFixtures extends AppManifestAbstract2 {
public KitchensinkAppManifestWithFixtures() {
super(KitchensinkAppManifest.BUILDER);
}
@Override protected void overrideFixtures(final List fixtureScriptClasses) {
fixtureScriptClasses.add(KitchensinkSetupFixture.class);
}
}{code}
does still work.
> AppManifestAbstract#withFixtureScripts no longer works.
> ---
>
> Key: ISIS-1829
> URL: https://issues.apache.org/jira/browse/ISIS-1829
> Project: Isis
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> workaround is to use overrideFixtureScripts
> I also think that the inverse of using overrideConfigurationProperties is
> broken in 1.16.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
