[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364141#comment-16364141 ] ASF subversion and git services commented on ISIS-1846: --- Commit e989ad937057a074023042691a0b65df036740b1 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=e989ad9 ] Merge remote-tracking branch 'origin/ISIS-1846_internal_utils' # Conflicts: # core/applib/src/main/java/org/apache/isis/applib/services/eventbus/AbstractDomainEvent.java # core/applib/src/main/java/org/apache/isis/schema/utils/CommonDtoUtils.java # core/metamodel/src/main/java/org/apache/isis/core/metamodel/spec/feature/ObjectAction.java > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364142#comment-16364142 ] ASF subversion and git services commented on ISIS-1846: --- Commit c1d0732604857ebf0d9496914e737d824617e1e0 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c1d0732 ] ISIS-1846: fixes unit test (had accidentally changed contract) > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364143#comment-16364143 ] ASF subversion and git services commented on ISIS-1846: --- Commit e0cb0853671a803c5356ef5ea8e1a884ddfebe78 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=e0cb085 ] ISIS-1846: reinstates reflections as a non-optional compile-time dependency, since required for both compile and runtime. > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364135#comment-16364135 ] ASF subversion and git services commented on ISIS-1846: --- Commit 62725eb3dfd7cf5c995eb5d943781437bd37e274 in isis's branch refs/heads/master from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=62725eb ] ISIS-1846 added reviewer notes and questions > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364136#comment-16364136 ] ASF subversion and git services commented on ISIS-1846: --- Commit 8ebd31355b1ec18800819f915a41acf166c79d85 in isis's branch refs/heads/master from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ebd313 ] ISIS-1846 thread-safe (atomic) writes to _Context (singleton-store) > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337574#comment-16337574 ] ASF subversion and git services commented on ISIS-1846: --- Commit 8ebd31355b1ec18800819f915a41acf166c79d85 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ebd313 ] ISIS-1846 thread-safe (atomic) writes to _Context (singleton-store) > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337122#comment-16337122 ] ASF subversion and git services commented on ISIS-1846: --- Commit 62725eb3dfd7cf5c995eb5d943781437bd37e274 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=62725eb ] ISIS-1846 added reviewer notes and questions > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336262#comment-16336262 ] ASF subversion and git services commented on ISIS-1846: --- Commit 71101fca273d874c581bce05d3feb7d93ba44ce6 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=71101fc ] ISIS-1846 put empty string array also in _Constants for convenience > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336251#comment-16336251 ] ASF subversion and git services commented on ISIS-1846: --- Commit 5dd9f737062fd2466e39039deaf91db6aa1014f5 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=5dd9f73 ] ISIS-1846 improve java-doc > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335932#comment-16335932 ] ASF subversion and git services commented on ISIS-1846: --- Commit 7743f0b9587fe5c797d909e1988b3d4382ef8575 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7743f0b ] ISIS-1846 java-doc: simplify warnings for internal API use > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335632#comment-16335632 ] ASF subversion and git services commented on ISIS-1846: --- Commit 70a5f0df5029d7b937f19f38dbe922faf3f7e9a4 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=70a5f0d ] ISIS-1846 introduces _Constants (internal API) > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335631#comment-16335631 ] ASF subversion and git services commented on ISIS-1846: --- Commit a5931f6d1e991de0bfd5ff9c97cb54f0aaa3021d in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a5931f6 ] ISIS-1846 clarify corner cases for string splitting + tests > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335633#comment-16335633 ] ASF subversion and git services commented on ISIS-1846: --- Commit 286b2c595b8b993e401aa2b3f5630b7691a264bd in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=286b2c5 ] ISIS-1846 consolidate uses of constants 'emptyObjects' + 'emptyClasses' > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335636#comment-16335636 ] ASF subversion and git services commented on ISIS-1846: --- Commit fe219d009f9aea07cb054c3e0ae101a8df2ec738 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=fe219d0 ] ISIS-1846 add _Exceptions to internal API > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334976#comment-16334976 ] ASF subversion and git services commented on ISIS-1846: --- Commit 996cf2980e54a08b2bac23334954aee8c51f in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=996cf2980 ] ISIS-1846 another occurrence of capitalize consolidated > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334969#comment-16334969 ] ASF subversion and git services commented on ISIS-1846: --- Commit 7613ee7ce07bb465e2669d546646504572c5a33d in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7613ee7 ] ISIS-1846 consolidate uses of capitalize > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334901#comment-16334901 ] ASF subversion and git services commented on ISIS-1846: --- Commit 463947d2a996d55d3a371851ad2c93c049243f4c in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=463947d ] ISIS-1846 fix Enums copy paste error > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334897#comment-16334897 ] ASF subversion and git services commented on ISIS-1846: --- Commit 77b179bfd285934eabc8436ded943bccb7efd9ec in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=77b179b ] ISIS-1846 add capitalize to new _String utility + tests, cleanup Enums > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334694#comment-16334694 ] ASF subversion and git services commented on ISIS-1846: --- Commit 4a90358d4d4147b69a63d750e64a8769d18c9cc4 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=4a90358 ] ISIS-1846 test cases added for new utility classes > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334538#comment-16334538 ] ASF subversion and git services commented on ISIS-1846: --- Commit 25f8b31600325efba432d9423fd7edb182e663ff in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=25f8b31 ] ISIS-1846 underscore(_) instead of dollar($) prefix for internal classes > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334474#comment-16334474 ] Andi Huber commented on ISIS-1846: -- Unfortunately using this $ prefix with class names confuses my IDE and breaks code-assistance, so I'll try something else. > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334469#comment-16334469 ] ASF subversion and git services commented on ISIS-1846: --- Commit debea9f762335abe9dad24e183401314f8512037 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=debea9f ] ISIS-1846 consolidate comparator algorithms into $Comparators > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334468#comment-16334468 ] ASF subversion and git services commented on ISIS-1846: --- Commit b6f8293577347e0cb00a1735d97abaa84fc8c5b0 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b6f8293 ] ISIS-1846 StringOperator: improved name for composing method > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334467#comment-16334467 ] ASF subversion and git services commented on ISIS-1846: --- Commit bc59167676f6e49fc79422945ed229b428db35ff in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=bc59167 ] ISIS-1846 add missing license header > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334466#comment-16334466 ] ASF subversion and git services commented on ISIS-1846: --- Commit 06227805a6576daa315fa3c294d6834c4a6d69ad in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=0622780 ] ISIS-1846 use mixin naming convention for package private support classes > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334343#comment-16334343 ] ASF subversion and git services commented on ISIS-1846: --- Commit 44af17ed727c1c1f66a7328c4b26f9cec1171680 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=44af17e ] ISIS-1846 deprecate StringPredicates and StringFunctions, refactoring any references to use the new $String utility class > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334340#comment-16334340 ] ASF subversion and git services commented on ISIS-1846: --- Commit b958267192ad4f4538ab4b1050bd655365720264 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b958267 ] ISIS-1846 beginning with consolidation of internal utilities > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334342#comment-16334342 ] ASF subversion and git services commented on ISIS-1846: --- Commit c4077602032d5a77835b43165826cfc651c4de44 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c407760 ] ISIS-1846 consolidate utilities > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334084#comment-16334084 ] Andi Huber commented on ISIS-1846: -- One possible solution: We consolidate all internal utility classes in *isis-core-applib* under *org.apache.isis.applib.internal.xxx*, put some 'Please do not use, will be removed with Java9' warnings into each classes java-doc and ignore the fact, that some developers might accidentally use these classes. > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
