Re: Logging in Tests

2008-02-26 Thread Marcel Reutegger
Alexander Klimetschek wrote: I am wondering how to do proper logging in jackrabbit test cases. At first I used System.out.println() during test case debugging, but now I want to improve that and switch to log (o.a.j.test.LogPrintWriter) provided by the test base class o.a.j.test.JUnitTest.

[jira] Assigned: (JCR-1415) Clustering configuration documentation for syncDelay doesn't match

2008-02-26 Thread Dominique Pfister (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominique Pfister reassigned JCR-1415: -- Assignee: Dominique Pfister Clustering configuration documentation for syncDelay

Re: Logging in Tests

2008-02-26 Thread Marcel Reutegger
Jukka Zitting wrote: I don't really understand why the TCK code needs the LogPrintWriter construct, but I guess it's there as a bridge for older code or a pre-SLF4J attempt to avoid a fixed dependency to a specific logging framework. Perhaps we should just refactor LogPrintWriter away. it's

[jira] Resolved: (JCR-1415) Clustering configuration documentation for syncDelay doesn't match

2008-02-26 Thread Dominique Pfister (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominique Pfister resolved JCR-1415. Resolution: Fixed Fix Version/s: core 1.4.2 Good point! I fixed in both trunk and 1.4

Re: [jira] Commented: (JCR-1405) SPI: Introduce NodeInfo.getChildInfos()

2008-02-26 Thread Julian Reschke
Angela Schreiber wrote: Michael Dürig wrote: i.e. RepositoryService.getChildInfos() returns NodeInfos instead of ChildInfos. I'd favour such a solution. We might even want to further generalize it to RepositoryService.getNodeInfos(SessionInfo sessionInfo, NodeId[] nodeId) i don't see

Re: Logging in Tests

2008-02-26 Thread Alexander Klimetschek
Am 26.02.2008 um 09:52 schrieb Marcel Reutegger: there's an existing log4j.properties file that you can edit in jackrabbit-core/src/test/resources/log4j.properties log4j.logger.org.apache.jackrabbit.test=DEBUG, stdout Argh, I tried that, but in the wrong location. In the 1.3 branch the

[jira] Created: (JCR-1418) Redesign NodeInfo.getReferences()

2008-02-26 Thread Marcel Reutegger (JIRA)
Redesign NodeInfo.getReferences() - Key: JCR-1418 URL: https://issues.apache.org/jira/browse/JCR-1418 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-spi Affects Versions: 1.4

Re: [jira] Commented: (JCR-1405) SPI: Introduce NodeInfo.getChildInfos()

2008-02-26 Thread Marcel Reutegger
Angela Schreiber wrote: Marcel Reutegger wrote: hmmm, what's the exact reason we have ChildInfo? as i say before: the reason for the ChildInfo was to be able to build the hierarchy entry without having to build the complete Node that belongs to that entry. I'm sorry, I was being lazy.

Re: [jira] Commented: (JCR-1405) SPI: Introduce NodeInfo.getChildInfos()

2008-02-26 Thread Marcel Reutegger
Julian Reschke wrote: Also, let's change public PropertyInfo getPropertyInfo(SessionInfo sessionInfo, PropertyId propertyId) throws ItemNotFoundException, RepositoryException; to public IteratorPropertyInfo getPropertyInfo(SessionInfo sessionInfo, PropertyId[] propertyId) throws

[jira] Created: (JCR-1419) Add test for database auto-reconnection (1.3 branch, JCR-1400)

2008-02-26 Thread Alexander Klimetschek (JIRA)
Add test for database auto-reconnection (1.3 branch, JCR-1400) -- Key: JCR-1419 URL: https://issues.apache.org/jira/browse/JCR-1419 Project: Jackrabbit Issue Type: Test

[jira] Updated: (JCR-1419) Add test for database auto-reconnection (1.3 branch)

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1419: --- Summary: Add test for database auto-reconnection (1.3 branch) (was: Add test for

[jira] Updated: (JCR-1419) Add test for database auto-reconnection (1.3 branch, JCR-1400)

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1419: --- Attachment: jackrabbit-core.test-for-1400.patch Patch that tests with an external

[jira] Created: (JCR-1420) Add test for Node.restore() may throw InvalidStateException (1.3 branch)

2008-02-26 Thread Alexander Klimetschek (JIRA)
Add test for Node.restore() may throw InvalidStateException (1.3 branch) Key: JCR-1420 URL: https://issues.apache.org/jira/browse/JCR-1420 Project: Jackrabbit Issue

Re: [jira] Commented: (JCR-1405) SPI: Introduce NodeInfo.getChildInfos()

2008-02-26 Thread Marcel Reutegger
Julian Reschke wrote: Marcel Reutegger wrote: Julian Reschke wrote: Also, let's change public PropertyInfo getPropertyInfo(SessionInfo sessionInfo, PropertyId propertyId) throws ItemNotFoundException, RepositoryException; to public IteratorPropertyInfo getPropertyInfo(SessionInfo

[jira] Commented: (JCR-1399) Backport JCR-1197 to 1.3 branch

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572432#action_12572432 ] Alexander Klimetschek commented on JCR-1399: Created a separate issue for the

[jira] Updated: (JCR-1420) Add test for Node.restore() may throw InvalidStateException (1.3 branch)

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1420: --- Attachment: jackrabbit-core.unit-test-for-jcr-1197.patch Unit test for this problem,

[jira] Updated: (JCR-1399) Backport JCR-1197 to 1.3 branch

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1399: --- Attachment: (was: jackrabbit-core.unit-test-for-jcr-1197.patch) Backport JCR-1197

[jira] Updated: (JCR-1419) Add test for database auto-reconnection (1.3 branch)

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1419: --- Attachment: jackrabbit-core.test-for-1400.patch Fixed the problem, now runs under mvn

[jira] Updated: (JCR-1419) Add test for database auto-reconnection (1.3 branch)

2008-02-26 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Klimetschek updated JCR-1419: --- Attachment: (was: jackrabbit-core.test-for-1400.patch) Add test for database

[jira] Created: (JCR-1421) Backport JCR-1111 to 1.3 branch

2008-02-26 Thread Przemo Pakulski (JIRA)
Backport JCR- to 1.3 branch --- Key: JCR-1421 URL: https://issues.apache.org/jira/browse/JCR-1421 Project: Jackrabbit Issue Type: Improvement Components: versioning Affects Versions: 1.3.3,

[jira] Updated: (JCR-1421) Backport JCR-1111 to 1.3 branch

2008-02-26 Thread Przemo Pakulski (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Przemo Pakulski updated JCR-1421: - Attachment: JCR-1421.diff Backport patch attached. Backport JCR- to 1.3 branch

[jira] Resolved: (JCR-1416) [PATCH] No need to call toString on a String

2008-02-26 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1416. --- Resolution: Fixed Fix Version/s: (was: core 1.4.2) 1.5 Applied

[jira] Resolved: (JCR-1417) [PATCH] remove code stutter

2008-02-26 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1417. --- Resolution: Fixed Fix Version/s: (was: core 1.4.2) 1.5 Applied

[jira] Resolved: (JCR-1420) Add test for Node.restore() may throw InvalidStateException (1.3 branch)

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved JCR-1420. Resolution: Duplicate Fix Version/s: (was: 1.3.4) Resolving as Duplicate of JCR-1399. A

[jira] Updated: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1399: --- Assignee: Jukka Zitting Issue Type: Bug (was: Task) Summary: Backport JCR-1197:

[jira] Resolved: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved JCR-1399. Resolution: Fixed The test case is better handled as an integral part of this issue. Applied the

[jira] Updated: (JCR-1400) Backport JCR-940: add db connection autoConnect for BundleDbPersistenceManager

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1400: --- Issue Type: Improvement (was: Task) Summary: Backport JCR-940: add db connection autoConnect

Re: [jira] Resolved: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Alexander Klimetschek
Hi! Am 26.02.2008 um 17:06 schrieb Jukka Zitting (JIRA): The test case is better handled as an integral part of this issue. I split them up because the test cases did not exist in the trunk. So I thought it would be better for referencing the specific test case issues when

[jira] Updated: (JCR-1420) Add test for Node.restore() may throw InvalidStateException

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1420: --- Fix Version/s: 1.5 Summary: Add test for Node.restore() may throw InvalidStateException

[jira] Reopened: (JCR-1420) Add test for Node.restore() may throw InvalidStateException (1.3 branch)

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting reopened JCR-1420: Assignee: Jukka Zitting Reopening with to add the test case in Jackrabbit trunk instead of the 1.3

Re: [jira] Resolved: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Jukka Zitting
Hi, On Tue, Feb 26, 2008 at 6:21 PM, Alexander Klimetschek [EMAIL PROTECTED] wrote: Am 26.02.2008 um 17:06 schrieb Jukka Zitting (JIRA): The test case is better handled as an integral part of this issue. I split them up because the test cases did not exist in the trunk. So I thought it

Re: [jira] Resolved: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Alexander Klimetschek
Am 26.02.2008 um 17:58 schrieb Jukka Zitting: So far I haven't figured out a good way to set such configuration through mvn eclipse:eclipse, but if someone comes up with a way to do that, I'd be very happy to add it in Jackrabbit. Maybe it's possible through the generic additionalConfig

Re: [jira] Resolved: (JCR-1399) Backport JCR-1197: Node.restore() may throw InvalidItemStateException

2008-02-26 Thread Alexander Klimetschek
I have found this link: http://www.peterfriese.de/formatting-your-code-using-the-eclipse-code-formatter/ It says that .settings/org.eclipse.jdt.core.prefs contains all formatting settings. I'll have a look at this later. Alex Am 26.02.2008 um 18:08 schrieb Alexander Klimetschek: Am

[jira] Resolved: (JCR-1421) Backport JCR-1111 to 1.3 branch

2008-02-26 Thread Przemo Pakulski (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Przemo Pakulski resolved JCR-1421. -- Resolution: Fixed Resolved in rev. 631310 Backport JCR- to 1.3 branch

[jira] Created: (JCR-1422) Support and Document Node Type Definitions in XML or Java API

2008-02-26 Thread hector rovira (JIRA)
Support and Document Node Type Definitions in XML or Java API - Key: JCR-1422 URL: https://issues.apache.org/jira/browse/JCR-1422 Project: Jackrabbit Issue Type: Improvement

[jira] Updated: (JCR-1116) Database persistence managers: log database and driver name and version

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1116: --- Fix Version/s: 1.3.4 Merged (with adaptations for JCR-940/JCR-1400) to the 1.3 branch in revision

[jira] Updated: (JCR-1412) [Patch] Java-based test configuration of Jackrabbit (no repository.xml needed)

2008-02-26 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1412: --- Fix Version/s: (was: 1.3.4) 1.5 Assignee: Jukka Zitting I committed

[jira] Updated: (JCR-954) Allow to disable referential integrity checking for workspace

2008-02-26 Thread Przemo Pakulski (JIRA)
[ https://issues.apache.org/jira/browse/JCR-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Przemo Pakulski updated JCR-954: Fix Version/s: 1.5 1.4.1 1.3.4

[jira] Commented: (JCR-954) Allow to disable referential integrity checking for workspace

2008-02-26 Thread Przemo Pakulski (JIRA)
[ https://issues.apache.org/jira/browse/JCR-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572697#action_12572697 ] Przemo Pakulski commented on JCR-954: - Without such option it is not possible to clone,

[jira] Updated: (JCR-954) Allow to disable referential integrity checking for workspace

2008-02-26 Thread Przemo Pakulski (JIRA)
[ https://issues.apache.org/jira/browse/JCR-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Przemo Pakulski updated JCR-954: Attachment: JCR-954-simple.diff Simpler version of patch attached : - no public api method, - no

[jira] Created: (JCR-1424) [PATCH] simplify conversion of strings to primitives by using parseXXX, not valueOf(xxx).xxxValue()

2008-02-26 Thread Dave Brosius (JIRA)
[PATCH] simplify conversion of strings to primitives by using parseXXX, not valueOf(xxx).xxxValue() --- Key: JCR-1424 URL:

[jira] Updated: (JCR-1423) [PATCH] fix clone implementation

2008-02-26 Thread Dave Brosius (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated JCR-1423: -- Attachment: fix_clone_impl.patch [PATCH] fix clone implementation

[jira] Updated: (JCR-1424) [PATCH] simplify conversion of strings to primitives by using parseXXX, not valueOf(xxx).xxxValue()

2008-02-26 Thread Dave Brosius (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated JCR-1424: -- Attachment: simplify_string_to_primitive.patch [PATCH] simplify conversion of strings to primitives by

[jira] Created: (JCR-1423) [PATCH] fix clone implementation

2008-02-26 Thread Dave Brosius (JIRA)
[PATCH] fix clone implementation Key: JCR-1423 URL: https://issues.apache.org/jira/browse/JCR-1423 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-core Affects Versions: core

[jira] Updated: (JCR-1425) [PATCH] reduce duplicate conversions from OffsetCharSequence to (lower/upper) strings

2008-02-26 Thread Dave Brosius (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated JCR-1425: -- Attachment: reduce_string_gen_stutter.patch [PATCH] reduce duplicate conversions from

[jira] Created: (JCR-1425) [PATCH] reduce duplicate conversions from OffsetCharSequence to (lower/upper) strings

2008-02-26 Thread Dave Brosius (JIRA)
[PATCH] reduce duplicate conversions from OffsetCharSequence to (lower/upper) strings - Key: JCR-1425 URL: https://issues.apache.org/jira/browse/JCR-1425 Project:

[jira] Commented: (JCR-1424) [PATCH] simplify conversion of strings to primitives by using parseXXX, not valueOf(xxx).xxxValue()

2008-02-26 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572812#action_12572812 ] angela commented on JCR-1424: - as far as i know the Boolean.parseBoolean(String) is available as

[jira] Updated: (JCR-1424) [PATCH] simplify conversion of strings to primitives by using parseXXX, not valueOf(xxx).xxxValue()

2008-02-26 Thread Dave Brosius (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Brosius updated JCR-1424: -- Attachment: simplify_string_to_primitive.patch Remove Boolean.valueOf(xxx).booleanValue() as correctly