Re: [PR] OAK-10544: oak-jcr: remapping a namespace prefix leaves namespace resolver in broken state [jackrabbit-oak]

2024-01-23 Thread via GitHub
thomasmueller commented on code in PR #1283: URL: https://github.com/apache/jackrabbit-oak/pull/1283#discussion_r1464468447 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionNamespaces.java: ## @@ -86,6 +88,11 @@ synchronized void setNamespacePrefix(String

Re: [PR] OAK-10595 : test case added [jackrabbit-oak]

2024-01-23 Thread via GitHub
rishabhdaim commented on code in PR #1261: URL: https://github.com/apache/jackrabbit-oak/pull/1261#discussion_r1463451524 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreSweepTest.java: ## @@ -70,12 +81,266 @@ public void before()

[PR] OAK-10544: oak-jcr: remapping a namespace prefix leaves namespace resolver in broken state [jackrabbit-oak]

2024-01-23 Thread via GitHub
reschke opened a new pull request, #1283: URL: https://github.com/apache/jackrabbit-oak/pull/1283 ...based on @mreutegg 's suggestion to fix this on oak-jcr. I don't believe we'd need a feature toggle for this. Feedback appreciated. -- This is an automated message from the

Re: [PR] OAK-10544: oak-jcr: remapping a namespace prefix leaves namespace resolver in broken state [jackrabbit-oak]

2024-01-23 Thread via GitHub
reschke commented on PR #1199: URL: https://github.com/apache/jackrabbit-oak/pull/1199#issuecomment-1906236884 @mreutegg - that's an interesting suggestion; I'll try this with the test in oak-jcr and the proposed tests in vlt -- This is an automated message from the Apache Git

Re: [PR] OAK-10611: o.a.j.o.namepath.JcrPathParser does not handle invalid characters correctly [jackrabbit-oak]

2024-01-23 Thread via GitHub
mbaedke merged PR #1281: URL: https://github.com/apache/jackrabbit-oak/pull/1281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10611: o.a.j.o.namepath.JcrPathParser does not handle invalid characters correctly [jackrabbit-oak]

2024-01-23 Thread via GitHub
mbaedke commented on code in PR #1281: URL: https://github.com/apache/jackrabbit-oak/pull/1281#discussion_r1463303254 ## oak-core-spi/src/test/java/org/apache/jackrabbit/oak/namepath/PathParserTest.java: ## @@ -301,20 +300,21 @@ public void testUnexpectedOpeningSquareBracket()

[jira] [Comment Edited] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809951#comment-17809951 ] Julian Reschke edited comment on JCRVLT-737 at 1/23/24 1:34 PM: Before

[jira] [Commented] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809951#comment-17809951 ] Julian Reschke commented on JCRVLT-737: --- Before, we didn't have a test that actually reproduced the

[jira] [Commented] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809950#comment-17809950 ] Joerg Hoh commented on JCRVLT-737: -- [~reschke] I think that we could improve the error message to ease

Re: [PR] OAK-10623: oak-core: log a warning when it needs to remap/add a namespace [jackrabbit-oak]

2024-01-23 Thread via GitHub
reschke merged PR #1282: URL: https://github.com/apache/jackrabbit-oak/pull/1282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10623: oak-core: log a warning when it needs to remap/add a namespace [jackrabbit-oak]

2024-01-23 Thread via GitHub
reschke opened a new pull request, #1282: URL: https://github.com/apache/jackrabbit-oak/pull/1282 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10611: o.a.j.o.namepath.JcrPathParser does not handle invalid characters correctly [jackrabbit-oak]

2024-01-23 Thread via GitHub
reschke commented on code in PR #1281: URL: https://github.com/apache/jackrabbit-oak/pull/1281#discussion_r1463271693 ## oak-core-spi/src/test/java/org/apache/jackrabbit/oak/namepath/PathParserTest.java: ## @@ -301,20 +300,21 @@ public void testUnexpectedOpeningSquareBracket()

[PR] OAK-10611: o.a.j.o.namepath.JcrPathParser does not handle invalid cha… [jackrabbit-oak]

2024-01-23 Thread via GitHub
mbaedke opened a new pull request, #1281: URL: https://github.com/apache/jackrabbit-oak/pull/1281 …racters correctly Fixed treatment of square brackets in some edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] OAK-10617: oak-search-elastic fix deadlock with includePathRestrictions=false and multiple filtered results [jackrabbit-oak]

2024-01-23 Thread via GitHub
fabriziofortino merged PR #1276: URL: https://github.com/apache/jackrabbit-oak/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10616: Make error messages from o.a.j.o.namepath.JcrNameParser/Jc… [jackrabbit-oak]

2024-01-23 Thread via GitHub
mbaedke merged PR #1277: URL: https://github.com/apache/jackrabbit-oak/pull/1277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JCRVLT-737: test case [jackrabbit-filevault]

2024-01-23 Thread via GitHub
kwin commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1463074893 ## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ## @@

[jira] [Updated] (JCRVLT-742) Stop generating MD5, SHA1 and SHA512 with Ant

2024-01-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-742: --- Description: Currently there is still manual generation of MD5, SHA1 and SHA512 checksum via

[jira] [Updated] (JCRVLT-742) Stop generating MD5, SHA1 and SHA512 with Ant

2024-01-23 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-742: --- Summary: Stop generating MD5, SHA1 and SHA512 with Ant (was: Stop generating MD5 and SHA1

[jira] [Created] (JCRVLT-742) Stop generating MD5 and SHA1 with Ant

2024-01-23 Thread Konrad Windszus (Jira)
Konrad Windszus created JCRVLT-742: -- Summary: Stop generating MD5 and SHA1 with Ant Key: JCRVLT-742 URL: https://issues.apache.org/jira/browse/JCRVLT-742 Project: Jackrabbit FileVault Issue

Re: [PR] OAK-10617: oak-search-elastic fix deadlock with includePathRestrictions=false and multiple filtered results [jackrabbit-oak]

2024-01-23 Thread via GitHub
nit0906 commented on code in PR #1276: URL: https://github.com/apache/jackrabbit-oak/pull/1276#discussion_r1463008272 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResponseListener.java: ## @@ -68,8 +68,9 @@ default void

Re: [PR] OAK-10617: oak-search-elastic fix deadlock with includePathRestrictions=false and multiple filtered results [jackrabbit-oak]

2024-01-23 Thread via GitHub
nit0906 commented on code in PR #1276: URL: https://github.com/apache/jackrabbit-oak/pull/1276#discussion_r1463008272 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResponseListener.java: ## @@ -68,8 +68,9 @@ default void

[PR] OAK-10615 - Azure Service Principal Support in oak-run [jackrabbit-oak]

2024-01-23 Thread via GitHub
dulceanu opened a new pull request, #1280: URL: https://github.com/apache/jackrabbit-oak/pull/1280 First un-tested implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCRVLT-737: -- Priority: Minor (was: Major) > IdConflictPolicy.LEGACY: Parent node not found when installing

[jira] [Commented] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809851#comment-17809851 ] Julian Reschke commented on JCRVLT-737: --- I think we have now proven that Filevault does what it's

[jira] [Updated] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCRVLT-737: -- Issue Type: Improvement (was: Bug) > IdConflictPolicy.LEGACY: Parent node not found when

[jira] [Updated] (JCRVLT-737) IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve test coverage

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCRVLT-737: -- Summary: IdConflictPolicy.LEGACY: Parent node not found when installing a package - improve

[jira] [Assigned] (JCRVLT-737) Parent node not found when installing a package

2024-01-23 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned JCRVLT-737: - Assignee: Julian Reschke > Parent node not found when installing a package >