[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #828: OAK-10022 make package 'org.apache.jackrabbit.oak.segment.remote' internal

2023-01-20 Thread GitBox
sonarcloud[bot] commented on PR #828: URL: https://github.com/apache/jackrabbit-oak/pull/828#issuecomment-1398720665 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] smiroslav merged pull request #828: OAK-10022 make package 'org.apache.jackrabbit.oak.segment.remote' internal

2023-01-20 Thread GitBox
smiroslav merged PR #828: URL: https://github.com/apache/jackrabbit-oak/pull/828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] smiroslav opened a new pull request, #828: OAK-10022 make package 'org.apache.jackrabbit.oak.segment.remote' internal

2023-01-20 Thread GitBox
smiroslav opened a new pull request, #828: URL: https://github.com/apache/jackrabbit-oak/pull/828 …ernal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #800: Issue/oak 10022

2023-01-20 Thread GitBox
reschke commented on code in PR #800: URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1082738771 ## oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/package-info.java: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software

[GitHub] [jackrabbit-oak] reschke commented on pull request #800: Issue/oak 10022

2023-01-20 Thread GitBox
reschke commented on PR #800: URL: https://github.com/apache/jackrabbit-oak/pull/800#issuecomment-1398595561 By all means: *please* update JIRA issues when merging fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #827: OAK-10076 - Bump netty dependency from 4.1.68.Final to 4.1.86.Final

2023-01-20 Thread GitBox
sonarcloud[bot] commented on PR #827: URL: https://github.com/apache/jackrabbit-oak/pull/827#issuecomment-1398591578 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-20 Thread GitBox
thomasmueller commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082553775 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -222,26 +235,53 @@ public

[GitHub] [jackrabbit-oak] smiroslav merged pull request #800: Issue/oak 10022

2023-01-20 Thread GitBox
smiroslav merged PR #800: URL: https://github.com/apache/jackrabbit-oak/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #269: JCRVLT-680: vault-validation - explicitly add commons-collections4 as test dependency

2023-01-20 Thread GitBox
reschke commented on code in PR #269: URL: https://github.com/apache/jackrabbit-filevault/pull/269#discussion_r1082340633 ## vault-validation/pom.xml: ## @@ -247,6 +247,12 @@ slf4j-simple test + + +

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-20 Thread GitBox
reschke commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082286015 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -222,26 +235,53 @@ public List

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-20 Thread GitBox
amit-jain commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082281696 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -222,26 +235,53 @@ public List

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-20 Thread GitBox
amit-jain commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082253306 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -222,26 +235,53 @@ public List

[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-20 Thread GitBox
fabriziofortino commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082205408 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -31,13 +32,16 @@ import

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #826: OAK-10048: DocumentStoreIndexerBase#buildFlatFileStore outputs the wrong path when FlatFileSplitter used

2023-01-19 Thread GitBox
thomasmueller commented on code in PR #826: URL: https://github.com/apache/jackrabbit-oak/pull/826#discussion_r1082172951 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -222,26 +235,53 @@ public

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #95: Direct binary access with oak 7589

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #95: URL: https://github.com/apache/jackrabbit-oak/pull/95#issuecomment-1397833893 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #96: Oak Direct Binary Access feature (version 2)

2023-01-19 Thread GitBox
github-actions[bot] commented on PR #96: URL: https://github.com/apache/jackrabbit-oak/pull/96#issuecomment-1397833861 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-filevault] kwin merged pull request #270: JCRVLT-677 store attributes within "entries.xml"

2023-01-19 Thread GitBox
kwin merged PR #270: URL: https://github.com/apache/jackrabbit-filevault/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #800: Issue/oak 10022

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #800: URL: https://github.com/apache/jackrabbit-oak/pull/800#issuecomment-1396977338 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #97: Fixed Spelling.

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #97: URL: https://github.com/apache/jackrabbit-oak/pull/97#issuecomment-1396344496 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #122: Oak 8114

2023-01-18 Thread GitBox
github-actions[bot] closed pull request #122: Oak 8114 URL: https://github.com/apache/jackrabbit-oak/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #98: Changed wording of supported blob stores to be more clear.

2023-01-18 Thread GitBox
github-actions[bot] commented on PR #98: URL: https://github.com/apache/jackrabbit-oak/pull/98#issuecomment-1396344454 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #269: JCRVLT-680: vault-validation - explicitly add commons-collections4 as test dependency

2023-01-18 Thread GitBox
kwin commented on code in PR #269: URL: https://github.com/apache/jackrabbit-filevault/pull/269#discussion_r1073712333 ## vault-validation/pom.xml: ## @@ -247,6 +247,12 @@ slf4j-simple test + + +

[GitHub] [jackrabbit-filevault] kwin opened a new pull request, #270: JCRVLT-677 store attributes within "entries.xml"

2023-01-18 Thread GitBox
kwin opened a new pull request, #270: URL: https://github.com/apache/jackrabbit-filevault/pull/270 This fixes the NPE being issued when trying to resolve conflicts Convert tests to JUnit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #100: Updated Azure 'azure-storage' and 'azure-keyvault-core' dependencies

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #100: URL: https://github.com/apache/jackrabbit-oak/pull/100#issuecomment-1386356935 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #123: OAK-8138 | Switching statistical facet mode to secure in case hit cou…

2023-01-17 Thread GitBox
github-actions[bot] closed pull request #123: OAK-8138 | Switching statistical facet mode to secure in case hit cou… URL: https://github.com/apache/jackrabbit-oak/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #124: OAK-8233 use System.currentTimeMillis()

2023-01-17 Thread GitBox
github-actions[bot] closed pull request #124: OAK-8233 use System.currentTimeMillis() URL: https://github.com/apache/jackrabbit-oak/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #99: OAK-7746 Refactor TypePredicate location and usage

2023-01-17 Thread GitBox
github-actions[bot] commented on PR #99: URL: https://github.com/apache/jackrabbit-oak/pull/99#issuecomment-1386356968 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] anchela merged pull request #825: OAK-10067 : ExternalGroupPrincipalProvider does not resolve inherited groups that cross IDP boundaries

2023-01-17 Thread GitBox
anchela merged PR #825: URL: https://github.com/apache/jackrabbit-oak/pull/825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #825: OAK-10067 : ExternalGroupPrincipalProvider does not resolve inherited groups that cross IDP boundaries

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #825: URL: https://github.com/apache/jackrabbit-oak/pull/825#issuecomment-1385509954 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #825: OAK-10067 : ExternalGroupPrincipalProvider does not resolve inherited groups that cross IDP boundaries

2023-01-17 Thread GitBox
sonarcloud[bot] commented on PR #825: URL: https://github.com/apache/jackrabbit-oak/pull/825#issuecomment-1385101841 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #102: OAK-7824 - fv similarity search reranking improvement

2023-01-16 Thread GitBox
github-actions[bot] commented on PR #102: URL: https://github.com/apache/jackrabbit-oak/pull/102#issuecomment-1384741150 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #125: OAK-8245 [v1.12] add "statement" column to explain query result row.

2023-01-16 Thread GitBox
github-actions[bot] closed pull request #125: OAK-8245 [v1.12] add "statement" column to explain query result row. URL: https://github.com/apache/jackrabbit-oak/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #126: OAK-8245 [v1.10] add "statement" column to explain query result row.

2023-01-16 Thread GitBox
github-actions[bot] closed pull request #126: OAK-8245 [v1.10] add "statement" column to explain query result row. URL: https://github.com/apache/jackrabbit-oak/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] reschke merged pull request #824: OAK-10070: Oak 1.22.14 Candidate Release Notes

2023-01-16 Thread GitBox
reschke merged PR #824: URL: https://github.com/apache/jackrabbit-oak/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] github-actions[bot] commented on pull request #105: Fixing flaky test OrderedPropertyIndexProviderTest.multipleQueryRuns

2023-01-15 Thread GitBox
github-actions[bot] commented on PR #105: URL: https://github.com/apache/jackrabbit-oak/pull/105#issuecomment-1383353047 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #128: OAK-8309: SLOW_QUERY_COUNT don't get updated for each slow query

2023-01-15 Thread GitBox
github-actions[bot] closed pull request #128: OAK-8309: SLOW_QUERY_COUNT don't get updated for each slow query URL: https://github.com/apache/jackrabbit-oak/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #127: OAK-8245 [v1.8] add "statement" column to explain query result row.

2023-01-15 Thread GitBox
github-actions[bot] closed pull request #127: OAK-8245 [v1.8] add "statement" column to explain query result row. URL: https://github.com/apache/jackrabbit-oak/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-filevault] reschke merged pull request #267: JCRVLT-678: avoid use of transitively inherited commons-collections in FSPackageRegistryIT

2023-01-15 Thread GitBox
reschke merged PR #267: URL: https://github.com/apache/jackrabbit-filevault/pull/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #129: OAK-8328 | Config errors in index defintion causes index update to ge…

2023-01-14 Thread GitBox
github-actions[bot] closed pull request #129: OAK-8328 | Config errors in index defintion causes index update to ge… URL: https://github.com/apache/jackrabbit-oak/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] github-actions[bot] closed pull request #130: OAK-8261: Indexing lane failing but the index is not marked corrupt

2023-01-14 Thread GitBox
github-actions[bot] closed pull request #130: OAK-8261: Indexing lane failing but the index is not marked corrupt URL: https://github.com/apache/jackrabbit-oak/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jackrabbit-filevault] kwin merged pull request #266: JCRVLT-677 emit stack trace with every throwable

2023-01-14 Thread GitBox
kwin merged PR #266: URL: https://github.com/apache/jackrabbit-filevault/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382720003 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382718357 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-14 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382718246 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] kwin commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382683552 Right, look at https://openjdk.org/jeps/247 for details. The release parameter triggers the check. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] reschke commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
reschke commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382673024 I believe this was needed to check that when targeting Java X, we must ensure not to use APIs from X + 1. AFAIU, this is now taken care by javac itself. @kwin - is that right? --

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382167138 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382160560 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382156171 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069637570 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 +${java.version} +${java.version} Review

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069638211 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 +${java.version} +${java.version} Review

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
reschke commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069636859 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 +${java.version} +${java.version} Review

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
reschke commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069637783 ## oak-parent/pom.xml: ## @@ -111,25 +113,14 @@ maven-compiler-plugin + 3.8.1 Review Comment: no idea how that got

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634028 ## oak-parent/pom.xml: ## @@ -111,25 +113,14 @@ maven-compiler-plugin + 3.8.1 Review Comment: why downgrading the newer

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634977 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 Review Comment: ```suggestion 11

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634028 ## oak-parent/pom.xml: ## @@ -111,25 +113,14 @@ maven-compiler-plugin + 3.8.1 Review Comment: why overwriting the newer

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1382020007 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
sonarcloud[bot] commented on PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#issuecomment-1381693826 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
reschke commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069234948 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069216488 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069214280 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069214280 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #546: Bump groovy from 2.5.2 to 2.5.14 in /oak-examples/webapp

2023-01-12 Thread GitBox
dependabot[bot] closed pull request #546: Bump groovy from 2.5.2 to 2.5.14 in /oak-examples/webapp URL: https://github.com/apache/jackrabbit-oak/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #546: Bump groovy from 2.5.2 to 2.5.14 in /oak-examples/webapp

2023-01-12 Thread GitBox
dependabot[bot] commented on PR #546: URL: https://github.com/apache/jackrabbit-oak/pull/546#issuecomment-1381381352 Looks like org.codehaus.groovy:groovy is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] reschke merged pull request #822: OAK-10066: update groovy dependency to 2.5.x

2023-01-12 Thread GitBox
reschke merged PR #822: URL: https://github.com/apache/jackrabbit-oak/pull/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #822: OAK-10066: update groovy dependency to 2.5.x

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #822: URL: https://github.com/apache/jackrabbit-oak/pull/822#issuecomment-1381062006 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #822: OAK-10066: update groovy dependency to 2.5.x

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #822: URL: https://github.com/apache/jackrabbit-oak/pull/822#issuecomment-1380985179 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #821: OAK-10065: avoid-use of groovy-all artefact

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #821: URL: https://github.com/apache/jackrabbit-oak/pull/821#issuecomment-1380591563 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] reschke merged pull request #821: OAK-10065: avoid-use of groovy-all artefact

2023-01-12 Thread GitBox
reschke merged PR #821: URL: https://github.com/apache/jackrabbit-oak/pull/821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg merged pull request #812: OAK-10034 : created an background thread to purge unmerged branch com…

2023-01-12 Thread GitBox
mreutegg merged PR #812: URL: https://github.com/apache/jackrabbit-oak/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #624: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-blob-cloud

2023-01-12 Thread GitBox
dependabot[bot] closed pull request #624: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-blob-cloud URL: https://github.com/apache/jackrabbit-oak/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-oak] dependabot[bot] closed pull request #625: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-segment-aws

2023-01-12 Thread GitBox
dependabot[bot] closed pull request #625: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-segment-aws URL: https://github.com/apache/jackrabbit-oak/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #624: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-blob-cloud

2023-01-12 Thread GitBox
dependabot[bot] commented on PR #624: URL: https://github.com/apache/jackrabbit-oak/pull/624#issuecomment-1380244953 Looks like com.amazonaws:aws-java-sdk-s3 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] dependabot[bot] commented on pull request #625: Bump aws-java-sdk-s3 from 1.11.700 to 1.12.261 in /oak-segment-aws

2023-01-12 Thread GitBox
dependabot[bot] commented on PR #625: URL: https://github.com/apache/jackrabbit-oak/pull/625#issuecomment-1380244955 Looks like com.amazonaws:aws-java-sdk-s3 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jackrabbit-oak] mreutegg merged pull request #816: OAK-10056 : provided support for jakarta & hyderabad region for S3

2023-01-12 Thread GitBox
mreutegg merged PR #816: URL: https://github.com/apache/jackrabbit-oak/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #820: OAK-10050 - Enable access to the secondary Azure blobstore service en…

2023-01-12 Thread GitBox
sonarcloud[bot] commented on PR #820: URL: https://github.com/apache/jackrabbit-oak/pull/820#issuecomment-1380231179 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [jackrabbit-oak] dulceanu opened a new pull request, #820: OAK-10050 - Enable access to the secondary Azure blobstore service en…

2023-01-12 Thread GitBox
dulceanu opened a new pull request, #820: URL: https://github.com/apache/jackrabbit-oak/pull/820 …dpoint in Oak segment node store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jackrabbit-oak] nit0906 merged pull request #817: OAK-10063 | Fixing log message to print the complete log

2023-01-12 Thread GitBox
nit0906 merged PR #817: URL: https://github.com/apache/jackrabbit-oak/pull/817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] anchela merged pull request #819: OAK-10061 : WARN when for an external group a local group with the same name is already present

2023-01-11 Thread GitBox
anchela merged PR #819: URL: https://github.com/apache/jackrabbit-oak/pull/819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #819: OAK-10061 : WARN when for an external group a local group with the same name is already present

2023-01-11 Thread GitBox
sonarcloud[bot] commented on PR #819: URL: https://github.com/apache/jackrabbit-oak/pull/819#issuecomment-1378772825 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] anchela opened a new pull request, #819: OAK-10061 : WARN when for an external group a local group with the same name is already present

2023-01-11 Thread GitBox
anchela opened a new pull request, #819: URL: https://github.com/apache/jackrabbit-oak/pull/819 hi @joerghoh , i would appreciate if you could review the suggested improvement wrt log output. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [jackrabbit-oak] reschke merged pull request #818: OAK-10062: consolidate and update groovy versions to 2.4.21

2023-01-11 Thread GitBox
reschke merged PR #818: URL: https://github.com/apache/jackrabbit-oak/pull/818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #818: OAK-10062: consolidate and update groovy versions to 2.4.21

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #818: URL: https://github.com/apache/jackrabbit-oak/pull/818#issuecomment-1378348582 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] rishabhdaim commented on pull request #816: OAK-10056 : provided support for jakarta & hyderabad region for S3

2023-01-10 Thread GitBox
rishabhdaim commented on PR #816: URL: https://github.com/apache/jackrabbit-oak/pull/816#issuecomment-1377062160 @mreutegg @amit-jain could you please review and share feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #815: OAK-10059: webapp: avoid use of Jackrabbit's transitive commons-collections dependency

2023-01-10 Thread GitBox
sonarcloud[bot] commented on PR #815: URL: https://github.com/apache/jackrabbit-oak/pull/815#issuecomment-1376962458 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] reschke merged pull request #815: OAK-10059: webapp: avoid use of Jackrabbit's transitive commons-collections dependency

2023-01-10 Thread GitBox
reschke merged PR #815: URL: https://github.com/apache/jackrabbit-oak/pull/815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #812: OAK-10034 : created an background thread to purge unmerged branch com…

2023-01-09 Thread GitBox
mreutegg commented on code in PR #812: URL: https://github.com/apache/jackrabbit-oak/pull/812#discussion_r1064807971 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java: ## @@ -569,11 +569,14 @@ public boolean

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
thomasmueller merged PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
sonarcloud[bot] commented on PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#issuecomment-1375783666 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
reschke commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064698301 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegate.java: ## @@ -78,6 +80,23 @@ public class SessionDelegate { static final

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
reschke commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064611458 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/ItemImpl.java: ## @@ -17,6 +17,7 @@ package org.apache.jackrabbit.oak.jcr.session; import

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
thomasmueller commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064599107 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/ItemImpl.java: ## @@ -17,6 +17,7 @@ package org.apache.jackrabbit.oak.jcr.session; import

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
thomasmueller commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064596209 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegate.java: ## @@ -78,6 +79,23 @@ public class SessionDelegate { static final

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #814: OAK-10055 Auto refreshing IndexTracker causes online reindexing to fail

2023-01-09 Thread GitBox
thomasmueller merged PR #814: URL: https://github.com/apache/jackrabbit-oak/pull/814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
reschke commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064516975 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/ItemImpl.java: ## @@ -17,6 +17,7 @@ package org.apache.jackrabbit.oak.jcr.session; import

[GitHub] [jackrabbit-oak] reschke commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
reschke commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064515687 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegate.java: ## @@ -78,6 +79,23 @@ public class SessionDelegate { static final

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
thomasmueller commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064511135 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegate.java: ## @@ -78,6 +79,23 @@ public class SessionDelegate { static final

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
thomasmueller commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064508224 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/ItemImpl.java: ## @@ -17,6 +17,7 @@ package org.apache.jackrabbit.oak.jcr.session; import

[GitHub] [jackrabbit-oak] nfsantos commented on a diff in pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-09 Thread GitBox
nfsantos commented on code in PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#discussion_r1064505114 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/ItemImpl.java: ## @@ -17,6 +17,7 @@ package org.apache.jackrabbit.oak.jcr.session; import

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #813: OAK-10054 Improved trace level logging of JCR method calls

2023-01-06 Thread GitBox
sonarcloud[bot] commented on PR #813: URL: https://github.com/apache/jackrabbit-oak/pull/813#issuecomment-1373765350 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

  1   2   3   4   5   6   7   8   9   10   >