kwin commented on code in PR #269:
URL:
https://github.com/apache/jackrabbit-filevault/pull/269#discussion_r1073712333
##########
vault-validation/pom.xml:
##########
@@ -247,6 +247,12 @@
<artifactId>slf4j-simple</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <!-- see JCRVLT-680 -->
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-collections4</artifactId>
+ <scope>test</scope>
Review Comment:
IMHO this is not only a test scope dependency, but really a runtime one
(i.e. client using the validation API will need it). Therefore this should have
scope "provided". All consumers probably need a fix as well as "provided" is
not transitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
