[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-11 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r870487942 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,24 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867283602 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867283424 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867235841 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements OptionsBean {

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867233951 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867233642 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -79,6 +79,8 @@ class TextExtractor implements Closeable { private

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-06 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867232958 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -55,6 +57,8 @@ public boolean isHelpRequested(){ return

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

2022-05-05 Thread GitBox
Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r866419970 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements OptionsBean {