[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069637570 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 +${java.version} +${java.version} Review Comm

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069638211 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 +${java.version} +${java.version} Review Comm

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634028 ## oak-parent/pom.xml: ## @@ -111,25 +113,14 @@ maven-compiler-plugin + 3.8.1 Review Comment: why downgrading the newer vers

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634977 ## oak-parent/pom.xml: ## @@ -69,8 +68,11 @@ 1.17.5 4.13.1 2.5.20 -1.8 -java18 + +11 Review Comment: ```suggestion 11 ${j

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069634028 ## oak-parent/pom.xml: ## @@ -111,25 +113,14 @@ maven-compiler-plugin + 3.8.1 Review Comment: why overwriting the newer vers

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069216488 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069214280 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

2023-01-13 Thread GitBox
kwin commented on code in PR #823: URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069214280 ## oak-parent/pom.xml: ## @@ -111,25 +110,17 @@ maven-compiler-plugin + 3.8.1 +${java.version} +