Ben Helleman created JCRVLT-720:
-----------------------------------

             Summary: Importer does not identify the missing node in the 
exception
                 Key: JCRVLT-720
                 URL: https://issues.apache.org/jira/browse/JCRVLT-720
             Project: Jackrabbit FileVault
          Issue Type: Improvement
    Affects Versions: 3.7.0
            Reporter: Ben Helleman


When a [parent 
node|https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L1103]
 is not located by the importer, the cause of the exception does not contain 
what the missing node was.  It would be helpful to have this information in the 
exception such that callers can use something like 
[ExceptionUtils.getRootCauseMessage|https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/exception/ExceptionUtils.html#getRootCauseMessage-java.lang.Throwable-]
 and have a detailed message that includes the path to the missing parent.

[https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L1103]

 
{code:java}
Caused by: org.apache.jackrabbit.vault.packaging.PackageException: Error 
creating/updating node /content/alpa/us/en/commercial-auto-insurance/jcr:content
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1177) 
[org.apache.jackrabbit.vault:3.7.0]
        at org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:976) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1018) 
[org.apache.jackrabbit.vault:3.7.0]
        at org.apache.jackrabbit.vault.fs.io.Importer.run(Importer.java:531) 
[org.apache.jackrabbit.vault:3.7.0]
        ... 93 common frames omitted
Caused by: java.lang.IllegalStateException: Parent node not found.
        at 
org.apache.jackrabbit.vault.fs.io.Importer.commit(Importer.java:1103) 
[org.apache.jackrabbit.vault:3.7.0]
        ... 101 common frames omitted
 {code}
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to