[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873578#action_12873578
]
Felix Meschberger commented on JCR-2640:
About public methods: having *every* method
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872216#action_12872216
]
Felix Meschberger commented on JCR-2640:
The point is to avoid public getters of
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872226#action_12872226
]
Thomas Mueller commented on JCR-2640:
-
But modularization is about separation of
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872268#action_12872268
]
Jukka Zitting commented on JCR-2640:
I committed the patch and a number of followup
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871530#action_12871530
]
Thomas Mueller commented on JCR-2640:
-
exposing implementation details through public
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871538#action_12871538
]
Thomas Mueller commented on JCR-2640:
-
our lives easier down the road if we want to go
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871546#action_12871546
]
Thomas Mueller commented on JCR-2640:
-
+0: I don't want to block this change, I just want
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871584#action_12871584
]
Stefan Guggisberg commented on JCR-2640:
i like the idea of the patch in general.
a
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871620#action_12871620
]
Tobias Bocanegra commented on JCR-2640:
---
why not create a RepositoryContext interface
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871621#action_12871621
]
Jukka Zitting commented on JCR-2640:
why not create a RepositoryContext interface and
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871730#action_12871730
]
Marcel Reutegger commented on JCR-2640:
---
Patch looks good to me.
+1
Internal
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871141#action_12871141
]
Thomas Mueller commented on JCR-2640:
-
I confess I don't understand what problem this
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871151#action_12871151
]
Felix Meschberger commented on JCR-2640:
I do not understand the problem either ?
To
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871155#action_12871155
]
Jukka Zitting commented on JCR-2640:
The main goal here is to be able to break the tight
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871158#action_12871158
]
Thomas Mueller commented on JCR-2640:
-
break the tight package-private coupling
And
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871161#action_12871161
]
Jukka Zitting commented on JCR-2640:
break the tight package-private coupling
And
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871167#action_12871167
]
Thomas Mueller commented on JCR-2640:
-
without having to expose Jackrabbit internals to
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871176#action_12871176
]
Jukka Zitting commented on JCR-2640:
Why is it problem if methods are public?
See the
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871183#action_12871183
]
Thomas Mueller commented on JCR-2640:
-
I see, Angela and Stefan don't like to make stuff
[
https://issues.apache.org/jira/browse/JCR-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871212#action_12871212
]
Jukka Zitting commented on JCR-2640:
FTR, I agree with Angela and Stefan on JCR-890,
20 matches
Mail list logo