[ https://issues.apache.org/jira/browse/JCR-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892254#action_12892254 ]
Thomas Mueller commented on JCR-2685: ------------------------------------- Hi, Thanks for the patch! It looks good (well, it would be better if there is a factory for ConnectionHelper so that it always picks the correct one, but that's another story). About "schemaObjectPrefix.toUpperCase()": in theory the user name is case sensitive (as far as I know). In practice, I don't think it's a big problem, and toUpperCase is more likely to solve a problem that to create a new one. However there is one problem using the Turkish locale and toUpperCase(). It's important to use toUpperCase(Locale.ENGLISH) instead. See also http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6208680 Unless somebody objects, I will apply the patch, but with toUpperCase(Locale.ENGLISH) > DbDataStore: table check fails on Oracle with multiple users > ------------------------------------------------------------ > > Key: JCR-2685 > URL: https://issues.apache.org/jira/browse/JCR-2685 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: 2.1.0 > Reporter: Stephan Huttenhuis > Attachments: JCR-2685.patch > > > If several users run several JackRabbit instances on the same Oracle database > the check if the DATATORE table exists always returns true if one user > already created the table. As a result, the table is not created for other > users. This can be fixed by supplying the username as schema by using the > OracleConnectionHelper if the database type is Oracle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.