[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12895195#action_12895195
]
Jukka Zitting commented on JCR-2688:
Could we move the org.apache.jackrabbit.flat package
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12895226#action_12895226
]
Michael Dürig commented on JCR-2688:
Sorry for the miss placed packages. Flat package
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12895277#action_12895277
]
Michael Dürig commented on JCR-2688:
I'm basically fine with the patch. However I would
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894855#action_12894855
]
Jukka Zitting commented on JCR-2688:
There's no need for the tests in jcr-commons to
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894603#action_12894603
]
Michael Dürig commented on JCR-2688:
I created JCR-2692 to track the issue of splitting
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894027#action_12894027
]
Marcel Reutegger commented on JCR-2688:
---
I suggest you go with 3)
We already did this
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12894054#action_12894054
]
Felix Meschberger commented on JCR-2688:
(6) would probably be best and also solve
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893129#action_12893129
]
Michael Dürig commented on JCR-2688:
Open questions:
- Currently these utility classes
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893130#action_12893130
]
Thomas Mueller commented on JCR-2688:
-
That about a test dependency?
Provide utility
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893171#action_12893171
]
Justin Edelson commented on JCR-2688:
-
I would use a test dependency. Placing the tests
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893177#action_12893177
]
Michael Dürig commented on JCR-2688:
Maven seems to fine with jackrabbit-core as test
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893181#action_12893181
]
Justin Edelson commented on JCR-2688:
-
Maven seems to fine with jackrabbit-core as test
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893193#action_12893193
]
Michael Dürig commented on JCR-2688:
So I see four option for the unit tests:
1. Move
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893204#action_12893204
]
Alexander Klimetschek commented on JCR-2688:
1. is the right way: if jackrabbit's
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893208#action_12893208
]
Michael Dürig commented on JCR-2688:
Yes technically 1. is the right way... However I
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893209#action_12893209
]
Justin Edelson commented on JCR-2688:
-
5. Leave the unit tests in jcr-commons and use
[
https://issues.apache.org/jira/browse/JCR-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893212#action_12893212
]
Michael Dürig commented on JCR-2688:
5. means basically reimplementing JCR...
6. is more
17 matches
Mail list logo