[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12420309 ]
angela commented on JCR-473:
oh. i can help you if you want me to.
apart from the deprecated calls, it would be nice to have all the hardcoded
index (0, 1), the depth and the name
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419685 ]
Tobias Bocanegra commented on JCR-473:
--
besides some javadoc errors, the patch looks ok.
+1 for patch V2
Some enhancements to jackrabbit commons
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419739 ]
Stefan Guggisberg commented on JCR-473:
---
+1 for 2nd patch from me as well
Some enhancements to jackrabbit commons
---
Key:
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419419 ]
angela commented on JCR-473:
InternalValue:
we should find something nicer. for example, drop the to methods
that take the nsresolver:
maybe i'm missing your point. from my
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419439 ]
Tobias Bocanegra commented on JCR-473:
--
jukka, you're right. ValueFactory has nothing to do with resolving names.
moving the InternalValue.create to the ValueHelper looks
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419443 ]
Tobias Bocanegra commented on JCR-473:
--
sorry. i'm a bit dizzy today:
- this was just a first ides but you're right.
+ this was just a first idea but you're right.
-
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419446 ]
angela commented on JCR-473:
a bit? i'm angela not jukka... unfortunately ;)
i would put all convertion code into ValueHelper, and
ValueFactoryImpl and InternalValue can then
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419447 ]
angela commented on JCR-473:
and for the latter (modifications within core classes) i suggested 2 solutions
from the top of my head (because i was thinking about this before). if
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419456 ]
Jukka Zitting commented on JCR-473:
---
Tobias:
but i ment 'jukka'. it was a response to your post :-)
Ah, OK. Just got confused as I didn't mention anything about
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419458 ]
Julian Reschke commented on JCR-473:
Regarding QName...:
Did anybody consider to require JAXP 1.3 (available as seperate download for
JDK 1.4), and just to use
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419460 ]
Marcel Reutegger commented on JCR-473:
--
Yes, I did, but the JCR QName are different from an XML QName. E.g. in JCR you
may start a name with a digit, which is not possible
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419462 ]
Jukka Zitting commented on JCR-473:
---
Julian:
Did anybody consider to require JAXP 1.3 (available as seperate download for
JDK 1.4), and just to use
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419464 ]
Stefan Guggisberg commented on JCR-473:
---
Julian Reschke commented on JCR-473:
Regarding QName...:
Did anybody consider to
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419466 ]
Tobias Bocanegra commented on JCR-473:
--
i guess you responded to a post, which gmail considered to be written by
jukka...
hehthey start getting subversive... it was
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419218 ]
Jukka Zitting commented on JCR-473:
---
Angela:
regarding interfaces for Path, QName:
Ah, sorry for being a bit unclear. I'd still keep them as concrete classes,
preferably
15 matches
Mail list logo
