[jira] [Updated] (JCR-4387) Wrong error message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4387: Attachment: JCR-4387.diff > Wrong error message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Major > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4387) Wrong error message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691699#comment-16691699 ] Julian Reschke commented on JCR-4387: - Test case moved into separate class: https://issues.apache.org/jira/secure/attachment/12948721/JCR-4387.diff > Wrong error message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Major > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4387: Fix Version/s: 2.18 > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4387: Labels: candidate_jcr_2_16 (was: ) > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4387: Summary: Incorrect exception message when same-name-sibling is prevented on import (was: Wrong error message when same-name-sibling is prevented on import) > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Major > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4387: Priority: Minor (was: Major) > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_16 > Fix For: 2.18 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-4387. - Resolution: Fixed Fix Version/s: 2.17.7 > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_16 > Fix For: 2.18, 2.17.7 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4387) Incorrect exception message when same-name-sibling is prevented on import
[ https://issues.apache.org/jira/browse/JCR-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691719#comment-16691719 ] Julian Reschke commented on JCR-4387: - trunk: [r1846896|http://svn.apache.org/r1846896] > Incorrect exception message when same-name-sibling is prevented on import > - > > Key: JCR-4387 > URL: https://issues.apache.org/jira/browse/JCR-4387 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core >Affects Versions: 2.16.2 >Reporter: Jörg von Frantzius >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_jcr_2_16 > Fix For: 2.18, 2.17.7 > > Attachments: DocumentViewTest.java, JCR-4387.diff, JCR-4387.diff, > SessionImporter.java > > > When importing XML for a node with the same name as an existing node, but > with different UUID, an ItemExistsException is thrown, effectively preventing > the creation of a same-name sibling on import. > Assuming that same-name siblings are supposed to be prevented on import, > that's totally perfect, but the error message of the Exception thrown is > wrong and very misleading: "Node with the same UUID exists", where it should > be something like "Node with same *name* exists, must prevent > same-name-sibling". > [https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/xml/SessionImporter.java#L381] > As a suggestion, perhaps the code should further check for > javax.jcr.nodetype.NodeDefinition#allowsSameNameSiblings before throwing the > exception? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Intent to backport OAK-7867 to Oak 1.8 and 1.6
Hi, I intend to backport OAK-7867 to Oak 1.8 and 1.6. This fixes an issue that can cause sever data loss with the segment node store. There is a medium to high risk with this backport as it touches some of the core parts of the segment node store. To mitigate the risk we ran a 14 days longevity test internally (Adobe), which did not show any significant difference with any of the tracked metrics. Furthermore I plan to run each of those backports through the same longevity test before including them in a release. Michael
Re: Intent to backport OAK-7867 to Oak 1.8 and 1.6
+1 On Mon, 19 Nov 2018 at 17:50, Michael Dürig wrote: > Hi, > > I intend to backport OAK-7867 to Oak 1.8 and 1.6. This fixes an issue > that can cause sever data loss with the segment node store. There is a > medium to high risk with this backport as it touches some of the core > parts of the segment node store. To mitigate the risk we ran a 14 days > longevity test internally (Adobe), which did not show any significant > difference with any of the tracked metrics. Furthermore I plan to run > each of those backports through the same longevity test before including > them in a release. > > Michael >
Re: Intent to backport OAK-7867 to Oak 1.8 and 1.6
On Mon, Nov 19, 2018 at 11:50 AM Michael Dürig wrote: > > Hi, > > I intend to backport OAK-7867 to Oak 1.8 and 1.6. This fixes an issue > that can cause sever data loss with the segment node store. There is a > medium to high risk with this backport as it touches some of the core > parts of the segment node store. To mitigate the risk we ran a 14 days > longevity test internally (Adobe), which did not show any significant > difference with any of the tracked metrics. Furthermore I plan to run > each of those backports through the same longevity test before including > them in a release. Cool! Thank you very much! Woonsan > > Michael
