[GitHub] [jackrabbit-oak] rishabhdaim commented on pull request #560: OAK-9757 : increased node name limit for mongo 4.2 version

rishabhdaim commented on PR #560: URL: https://github.com/apache/jackrabbit-oak/pull/560#issuecomment-1119294326 @reschke That's a good idea to move util function to DocumentStore and that would help us avoiding in calling metadata multiple times. Let me make changes and raise the PR

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

thomasmueller commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r866526453 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not

[GitHub] [jackrabbit-oak] thomasmueller commented on a diff in pull request #562: OAK-9760 Oak run index purge command active index check is in correct

thomasmueller commented on code in PR #562: URL: https://github.com/apache/jackrabbit-oak/pull/562#discussion_r866548521 ## oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/IndexVersionOperation.java: ## @@ -86,42 +92,65 @@ public static List

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

nit0906 commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r866537233 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements OptionsBean {

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #560: OAK-9757 : increased node name limit for mongo 4.2 version

mreutegg commented on PR #560: URL: https://github.com/apache/jackrabbit-oak/pull/560#issuecomment-1119646255 I suggest we take a slightly different approach. To me it feels wrong that `Utils.isLongPath()` is currently responsible for detecting when a node name is too long. I think this is

[GitHub] [jackrabbit-oak] FrancoisZhang commented on a diff in pull request #562: OAK-9760 Oak run index purge command active index check is in correct

FrancoisZhang commented on code in PR #562: URL: https://github.com/apache/jackrabbit-oak/pull/562#discussion_r867005282 ## oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/IndexVersionOperation.java: ## @@ -86,42 +92,65 @@ public static List

[GitHub] [jackrabbit-oak] mreutegg commented on pull request #560: OAK-9757 : increased node name limit for mongo 4.2 version

mreutegg commented on PR #560: URL: https://github.com/apache/jackrabbit-oak/pull/560#issuecomment-1119649190 Also note that checks fails because two new files for classes `MongoVersion` and `MongoVersionTest` do not have a license header. -- This is an automated message from the Apache

[GitHub] [jackrabbit-oak] FrancoisZhang commented on a diff in pull request #562: OAK-9760 Oak run index purge command active index check is in correct

FrancoisZhang commented on code in PR #562: URL: https://github.com/apache/jackrabbit-oak/pull/562#discussion_r867005027 ## oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/IndexVersionOperation.java: ## @@ -86,42 +92,65 @@ public static List

[GitHub] [jackrabbit-oak] FrancoisZhang commented on a diff in pull request #562: OAK-9760 Oak run index purge command active index check is in correct

FrancoisZhang commented on code in PR #562: URL: https://github.com/apache/jackrabbit-oak/pull/562#discussion_r867011034 ## oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/IndexVersionOperation.java: ## @@ -86,42 +92,65 @@ public static List

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867233642 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -79,6 +79,8 @@ class TextExtractor implements Closeable { private

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867232958 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -55,6 +57,8 @@ public boolean isHelpRequested(){ return

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867235841 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/run/cli/CommonOptions.java: ## @@ -36,13 +36,15 @@ public class CommonOptions implements OptionsBean {

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867233951 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] klcodanr commented on a diff in pull request #535: OAK-9740 - Offset / Limit Option

klcodanr commented on code in PR #535: URL: https://github.com/apache/jackrabbit-oak/pull/535#discussion_r867017876 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java: ## @@ -1102,13 +1113,16 @@ private SelectorExecutionPlan getBestSelectorExecutionPlan(

[GitHub] [jackrabbit-oak] klcodanr commented on pull request #535: OAK-9740 - Offset / Limit Option

klcodanr commented on PR #535: URL: https://github.com/apache/jackrabbit-oak/pull/535#issuecomment-1119822357 @thomasmueller I believe I've addressed your feedback, can you re:review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867283602 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being

[GitHub] [jackrabbit-oak] Ewocker commented on a diff in pull request #561: OAK-9758 error out if tika dependencies are missing and improve loggi…

Ewocker commented on code in PR #561: URL: https://github.com/apache/jackrabbit-oak/pull/561#discussion_r867283424 ## oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/TextExtractor.java: ## @@ -270,22 +272,22 @@ public InputStream get() { // not being