[jira] [Commented] (JCRVLT-138) Unzip test-packages for easier maintenance
[ https://issues.apache.org/jira/browse/JCRVLT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617925#comment-15617925 ] Tobias Bocanegra commented on JCRVLT-138: - nice. however, zipping the test packages on-the-fly is probably better, because this way it also tests the unzipping. > Unzip test-packages for easier maintenance > -- > > Key: JCRVLT-138 > URL: https://issues.apache.org/jira/browse/JCRVLT-138 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: vlt >Affects Versions: 3.1.30 >Reporter: Julian Sedding >Priority: Minor > > As discussed in JCRVLT-111 it would be easier for maintenance of tests, and > more accessible, if the content-packages used in tests were exploaded. > This can be done relatively easily, as shown in an [example > project|https://github.com/code-distillery/filevault-oak-reindex-hook/blob/master/src/test/java/net/distilledcode/tools/InstallHookTestUtils.java#L39]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (JCRVLT-111) Add support for o.a.j.api.security.authorization.PrincipalSetPolicy
[
https://issues.apache.org/jira/browse/JCRVLT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617748#comment-15617748
]
Julian Sedding edited comment on JCRVLT-111 at 10/29/16 8:56 AM:
-
[~tripod] if you look at the implementation of TestVaultPackage it's
exceedingly simple: it exposes a protected constructor accepting an {{Archive}}
that is already present in ZipVaultPackage. Zipping the package on the fly
probably requires more code and makes the tests slower. We could even consider
providing a public constructor or utility to make testing in downstream
projects easier.
I created JCRVLT-138 to track this improvement. Let's discuss over there in
order not to further side-track the discussion in this ticket.
was (Author: jsedding):
[~tripod] if you look at the implementation of TestVaultPackage it's
exceedingly simple: it exposes a protected constructor accepting an {{Archive}}
that is already present in ZipVaultPackage. Zipping the package on the fly
probably requires more code and makes the tests slower. We could even consider
providing a public constructor or utility to make testing in downstream
projects easier.
> Add support for o.a.j.api.security.authorization.PrincipalSetPolicy
> ---
>
> Key: JCRVLT-111
> URL: https://issues.apache.org/jira/browse/JCRVLT-111
> Project: Jackrabbit FileVault
> Issue Type: New Feature
>Reporter: angela
>Assignee: Tobias Bocanegra
> Fix For: 3.1.30
>
> Attachments: JCRVLT-111.patch
>
>
> jackrabbit API has been extended by an additional type of access control
> policy, which isn't an ACL. fvault should be adjusted to be able to properly
> import that type of access control policy.
> as discussed: ac-handling {{MERGE}} and {{MERGE_PRESERVE}} should be
> implemented the same way and just add extra principal names that are not yet
> present in the set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (JCRVLT-138) Unzip test-packages for easier maintenance
Julian Sedding created JCRVLT-138: - Summary: Unzip test-packages for easier maintenance Key: JCRVLT-138 URL: https://issues.apache.org/jira/browse/JCRVLT-138 Project: Jackrabbit FileVault Issue Type: Improvement Components: vlt Affects Versions: 3.1.30 Reporter: Julian Sedding Priority: Minor As discussed in JCRVLT-111 it would be easier for maintenance of tests, and more accessible, if the content-packages used in tests were exploaded. This can be done relatively easily, as shown in an [example project|https://github.com/code-distillery/filevault-oak-reindex-hook/blob/master/src/test/java/net/distilledcode/tools/InstallHookTestUtils.java#L39]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCRVLT-111) Add support for o.a.j.api.security.authorization.PrincipalSetPolicy
[
https://issues.apache.org/jira/browse/JCRVLT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617748#comment-15617748
]
Julian Sedding commented on JCRVLT-111:
---
[~tripod] if you look at the implementation of TestVaultPackage it's
exceedingly simple: it exposes a protected constructor accepting an {{Archive}}
that is already present in ZipVaultPackage. Zipping the package on the fly
probably requires more code and makes the tests slower. We could even consider
providing a public constructor or utility to make testing in downstream
projects easier.
> Add support for o.a.j.api.security.authorization.PrincipalSetPolicy
> ---
>
> Key: JCRVLT-111
> URL: https://issues.apache.org/jira/browse/JCRVLT-111
> Project: Jackrabbit FileVault
> Issue Type: New Feature
>Reporter: angela
>Assignee: Tobias Bocanegra
> Fix For: 3.1.30
>
> Attachments: JCRVLT-111.patch
>
>
> jackrabbit API has been extended by an additional type of access control
> policy, which isn't an ACL. fvault should be adjusted to be able to properly
> import that type of access control policy.
> as discussed: ac-handling {{MERGE}} and {{MERGE_PRESERVE}} should be
> implemented the same way and just add extra principal names that are not yet
> present in the set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
