Re: [VOTE] Release Apache Jackrabbit Oak 1.6.15

2018-11-15 Thread Woonsan Ko
[X] +1 Release this package as Apache Jackrabbit Oak 1.6.15

RELEASE-NOTES.txt looks good and all checks ok where:

[INFO] Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T21:39:06+02:00)
[INFO] OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
[INFO] Java version: 1.8.0_144, vendor: Oracle Corporation

Kind regards,

Woonsan

On Wed, Nov 14, 2018 at 12:34 PM Davide Giannella  wrote:
>
> A candidate for the Jackrabbit Oak 1.6.15 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.6.15/
>
> The release candidate is a zip archive of the sources in:
>
>
> https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.6.15/
>
> The SHA1 checksum of the archive is
> e7e5e28f55fdc1876f3024d609d3d9407f39d656.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit
> $ sh check-release.sh oak 1.6.15
> e7e5e28f55fdc1876f3024d609d3d9407f39d656
>
> Please vote on releasing this package as Apache Jackrabbit Oak 1.6.15.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit Oak 1.6.15
> [ ] -1 Do not release this package because...
>
> D.


[jira] [Created] (JCRVLT-324) In case of a long project description in CDATA the resulting MANIFEST.MF is invalid

2018-11-15 Thread Krystian Nowak (JIRA)
Krystian Nowak created JCRVLT-324:
-

 Summary: In case of a long project description in CDATA the 
resulting MANIFEST.MF is invalid
 Key: JCRVLT-324
 URL: https://issues.apache.org/jira/browse/JCRVLT-324
 Project: Jackrabbit FileVault
  Issue Type: Bug
  Components: package maven plugin
Reporter: Krystian Nowak


In case of a long project description in CDATA e.g.:

{noformat}



{noformat}

a package with the following MANIFEST.MF is produced:

{noformat}
Manifest-Version: 1.0
Implementation-Title: Lorem Ipsum - Package
Implementation-Version: 2.2.2-SNAPSHOT
Archiver-Version: Plexus Archiver
Built-By: krystian
Implementation-Vendor-Id: org.lorem.ipsum
Content-Package-Dependencies: a/b/c:d:2.1.0
Content-Package-Type: mixed
Content-Package-Description: Lorem ipsum dolor sit amet, consectetur a
 dipiscing elit. Vestibulum mattis, erat vel ultrices scelerisque, vel
 it velit laoreet quam, id dignissim elit ex nec magna. Vivamus non di
 am non libero posuere lacinia. Suspendisse vel facilisis mi. Duis hen
 drerit massa diam.

- Quisque commodo vitae tellus vitae:
Morbi finib
 us nec tortor sed pellentesque. Sed nulla magna, interdum ut iaculis 
 quis, cursus et urna. Donec ornare eget lectus at vestibulum.
Etiam v
 enenatis nulla aliquet quam dapibus rhoncus.
Aliquam eget turpis vita
 e leo maximus porttitor non eget augue.
Curabitur aliquam imperdiet v
 ulputate.

- Duis viverra posuere est nec vehicula fringilla:
Mauris 
 nec feugiat ante, sed porta metus. Fusce vehicula, odio sit amet male
 suada varius, ante metus accumsan ex, id ornare lectus lorem ac felis
 .
Vivamus sed nibh nec arcu sodales commodo.

- Quisque molestie feug
 iat sem quis rhoncus lectus ornare:
Fusce consectetur varius enim ac 
 viverra. Integer id semper lorem, eget sollicitudin lectus. Maecenas 
 sit amet ex sed arcu consequat eleifend. Praesent eu est quis nulla v
 estibulum venenatis. Curabitur ipsum dolor, dapibus a maximus id, fau
 cibus in quam fermentum.
Class aptent taciti sociosqu ad litora torqu
 ent per conubia nostra, per inceptos himenaeos. Nunc sed libero purus
 .

Pellentesque lobortis placerat lectus eleifend:
Praesent sapien sem
https://issues.apache.
 org/jira/projects/JCRVLT">Sed egestas luctus sapien
Content-Package-Roots: /foo/bar,/foo/baz
Created-By: Apache Maven
Build-Jdk: 1.8.0_181
Content-Package-Id: org/lorem/ipsum:lorem-ipsum-pkg:2.2.2-SNAPSHOT
{noformat}

This MANIFEST.MF is incorrect, as when reading it by _java.util.jar.Manifest_ 
an exception on invalid format is thrown:
{noformat}
java.io.IOException: invalid manifest format
at java.util.jar.Manifest.read(Manifest.java:225)
at java.util.jar.Manifest.(Manifest.java:69)
{noformat}

Only when the description of the project is reformatted into:
{noformat}



{noformat}

the MANIFEST.MF produced is:

{noformat}
Manifest-Version: 1.0
Implementation-Title: Lorem Ipsum - Package
Implementation-Version: 2.2.2-SNAPSHOT
Archiver-Version: Plexus Archiver
Built-By: krystian
Implementation-Vendor-Id: org.lorem.ipsum
Content-Package-Dependencies: a/b/c:d:2.1.0
Content-Package-Type: mixed
Content-Package-Description: Lorem ipsum dolor sit amet, consectetur a
 dipiscing elit. Vestibulum mattis, erat vel ultrices scelerisque, vel
 it velit laoreet quam, id dignissim elit ex nec magna. Vivamus non di
 am non libero posuere lacinia. Suspendisse vel facilisis mi. Duis hen
 drerit massa diam.
 - Quisque commodo vitae tellus vitae:
 Morbi fini
 bus nec tortor sed pellentesque. Sed nulla magna, interdum ut iaculis
  quis, cursus et urna. Donec ornare eget lectus at vestibulum.
 Etiam
  venenatis nulla aliquet quam dapibus rhoncus.
 Aliquam eget turpis v
 itae leo maximus porttitor non eget augue.
 Curabitur aliquam imperdi
 et vulputate.
 - Duis viverra posuere est nec vehicula fringilla:
 Ma
 uris nec feugiat ante, sed porta metus. Fusce vehicula, odio sit amet
  malesuada varius, ante metus accumsan ex, id ornare lectus lorem ac 
 felis.
 Vivamus sed nibh nec arcu sodales commodo.
 - Quisque molesti
 e feugiat sem quis rhoncus lectus ornare:
 Fusce consectetur varius e
 nim ac viverra. Integer id semper lorem, eget sollicitudin lectus. Ma
 ecenas sit amet ex sed arcu consequat eleifend. Praesent eu est quis 
 nulla vestibulum venenatis. Curabitur ipsum dolor, dapibus a maximus 
 id, faucibus in quam fermentum.
 Class aptent taciti sociosqu ad lito
 ra torquent per conubia nostra, per inceptos himenaeos. Nunc sed libe
 ro purus.
 Pellentesque lobortis placerat lectus eleifend:
 https://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html#M
 anifest_Specification">Praesent sapien sem
 https://issu
 es.apache.org/jira/projects/JCRVLT">Sed egestas luctus sapien
Content-Package-Roots: /foo/bar,/foo/baz
Created-By: Apache Maven
Build-Jdk: 1.8.0_181
Content-Package-Id: 

[jira] [Commented] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688341#comment-16688341
 ] 

Julian Reschke commented on JCR-4120:
-

I agree - changing the default for the workspace seems to be unrelated to "JSR 
283 Access Control Management" (JCR-2113). Thus we should  simply restore the 
correct behavior in the affected branches.

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4120:

Priority: Minor  (was: Major)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Minor
>  Labels: candidate_jcr_2_16
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688341#comment-16688341
 ] 

Julian Reschke edited comment on JCR-4120 at 11/15/18 4:53 PM:
---

I agree - changing the default for the workspace seems to be unrelated to "JSR 
283 Access Control Management" (JCR-2113). Thus we should  simply restore the 
correct behavior in the affected branches.

(changed back to "minor bug" and marked for backport)


was (Author: reschke):
I agree - changing the default for the workspace seems to be unrelated to "JSR 
283 Access Control Management" (JCR-2113). Thus we should  simply restore the 
correct behavior in the affected branches.

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Minor
>  Labels: candidate_jcr_2_16
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4120:

Labels: candidate_jcr_2_16  (was: )

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Minor
>  Labels: candidate_jcr_2_16
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4120:

Issue Type: Bug  (was: Improvement)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
>  Labels: candidate_jcr_2_16
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688264#comment-16688264
 ] 

Konrad Windszus commented on JCR-4120:
--

I would still argue that this is a bug being introduced by 
https://issues.apache.org/jira/browse/JCR-2113. Since that has been backported 
to other jackrabbit versions I would also appreciate to also backport this fix.

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688264#comment-16688264
 ] 

Konrad Windszus edited comment on JCR-4120 at 11/15/18 4:06 PM:


I would still argue that this is a bug being introduced by 
https://issues.apache.org/jira/browse/JCR-2113 (i.e. since Jackrabbit 2.9). I 
would therefore appreciate to also backport this fix to all versions which 
contain JCR-2113.


was (Author: kwin):
I would still argue that this is a bug being introduced by 
https://issues.apache.org/jira/browse/JCR-2113. Since that has been backported 
to other jackrabbit versions I would also appreciate to also backport this fix.

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela updated JCR-4120:

Priority: Major  (was: Minor)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela updated JCR-4120:

Labels:   (was: candidate_jcr_2_16)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela updated JCR-4120:

Issue Type: Improvement  (was: Bug)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Minor
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela updated JCR-4120:

Priority: Minor  (was: Major)

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Minor
>  Labels: candidate_jcr_2_16
> Fix For: 2.18, 2.17.7
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCRVLT-323) Unable to perform sync due to wrong default workspace handling

2018-11-15 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/JCRVLT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688245#comment-16688245
 ] 

Konrad Windszus commented on JCRVLT-323:


Now JCR-4120 is finally fixed. To fix this issue as well the next FileVault 
release should just upgrade to the (not yet released) version 2.18 of 
jackrabbit-spi2dav.

> Unable to perform sync due to wrong default workspace handling
> --
>
> Key: JCRVLT-323
> URL: https://issues.apache.org/jira/browse/JCRVLT-323
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: vlt
>Affects Versions: 3.1.38
>Reporter: Konrad Windszus
>Priority: Major
>
> This issue is similar to JCRVLT-144 but it happens while performing the 
> {{sync}} instead of {{checkout}}. Please fix this as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela updated JCR-4120:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed revision 1846665.
I committed the changes to 'Spi2davexRepositoryServiceFactory' with slightly 
modified comments in particular also linking to JCR-4120 as for any setup with 
jcrserver <1.5 this modification is most probably a breaking change.
in terms of testing: i ran the ConformanceTest present with 
_jackrabbit-jcr2dav_ and all executed tests passed with no default workspace 
name set in the factory (verified that this code is actually executed).

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


BUILD FAILURE: Jackrabbit Oak - Build # 1793 - Still Failing

2018-11-15 Thread Apache Jenkins Server
The Apache Jenkins build system has built Jackrabbit Oak (build #1793)

Status: Still Failing

Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/1793/ to 
view the results.

Changes:
[angela] OAK-7900 : Allow to spot User.disable with a new, dedicated UserAction

 

Test results:
43 tests failed.
FAILED:  org.apache.jackrabbit.oak.plugins.document.BlobTest.addBlobs

Error Message:
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64

Stack Trace:
java.lang.NoClassDefFoundError: 
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64


FAILED:  
org.apache.jackrabbit.oak.plugins.document.BlobTest.testBlobSerialization

Error Message:
Unable to start docker container: DockerConfig{name=MongoDB}

Stack Trace:
java.lang.RuntimeException: Unable to start docker container: 
DockerConfig{name=MongoDB}
Caused by: com.spotify.docker.client.exceptions.ContainerNotFoundException: 
Container not found: MongoDB
Caused by: com.spotify.docker.client.exceptions.DockerRequestException: 
Request error: GET unix://localhost:80/containers/MongoDB/json: 404, body: 
{"message":"No such container: MongoDB"}

Caused by: com.spotify.docker.client.shaded.javax.ws.rs.NotFoundException: HTTP 
404 Not Found


FAILED:  
org.apache.jackrabbit.oak.plugins.document.ClusterTest.rollbackAfterConflict

Error Message:
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64

Stack Trace:
java.lang.NoClassDefFoundError: 
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64


FAILED:  org.apache.jackrabbit.oak.plugins.document.ClusterTest.clusterNodeInfo

Error Message:
Unable to start docker container: DockerConfig{name=MongoDB}

Stack Trace:
java.lang.RuntimeException: Unable to start docker container: 
DockerConfig{name=MongoDB}
Caused by: com.spotify.docker.client.exceptions.ContainerNotFoundException: 
Container not found: MongoDB
Caused by: com.spotify.docker.client.exceptions.DockerRequestException: 
Request error: GET unix://localhost:80/containers/MongoDB/json: 404, body: 
{"message":"No such container: MongoDB"}

Caused by: com.spotify.docker.client.shaded.javax.ws.rs.NotFoundException: HTTP 
404 Not Found


FAILED:  
org.apache.jackrabbit.oak.plugins.document.ClusterTest.revisionVisibility

Error Message:
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64

Stack Trace:
java.lang.NoClassDefFoundError: 
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64


FAILED:  org.apache.jackrabbit.oak.plugins.document.ClusterTest.threeNodes

Error Message:
Unable to start docker container: DockerConfig{name=MongoDB}

Stack Trace:
java.lang.RuntimeException: Unable to start docker container: 
DockerConfig{name=MongoDB}
Caused by: com.spotify.docker.client.exceptions.ContainerNotFoundException: 
Container not found: MongoDB
Caused by: com.spotify.docker.client.exceptions.DockerRequestException: 
Request error: GET unix://localhost:80/containers/MongoDB/json: 404, body: 
{"message":"No such container: MongoDB"}

Caused by: com.spotify.docker.client.shaded.javax.ws.rs.NotFoundException: HTTP 
404 Not Found


FAILED:  org.apache.jackrabbit.oak.plugins.document.ClusterTest.openCloseOpen

Error Message:
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64

Stack Trace:
java.lang.NoClassDefFoundError: 
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64


FAILED:  
org.apache.jackrabbit.oak.plugins.document.ClusterTest.fromExternalChange

Error Message:
Unable to start docker container: DockerConfig{name=MongoDB}

Stack Trace:
java.lang.RuntimeException: Unable to start docker container: 
DockerConfig{name=MongoDB}
Caused by: com.spotify.docker.client.exceptions.ContainerNotFoundException: 
Container not found: MongoDB
Caused by: com.spotify.docker.client.exceptions.DockerRequestException: 
Request error: GET unix://localhost:80/containers/MongoDB/json: 404, body: 
{"message":"No such container: MongoDB"}

Caused by: com.spotify.docker.client.shaded.javax.ws.rs.NotFoundException: HTTP 
404 Not Found


FAILED:  org.apache.jackrabbit.oak.plugins.document.ClusterTest.conflict

Error Message:
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64

Stack Trace:
java.lang.NoClassDefFoundError: 
repackaged/com/arakelian/docker/junit/org/apache/commons/codec/binary/Base64


FAILED:  
org.apache.jackrabbit.oak.plugins.document.ClusterTest.clusterNodeInfoLease

Error Message:
Unable to start docker container: DockerConfig{name=MongoDB}

Stack Trace:
java.lang.RuntimeException: Unable to start docker container: 
DockerConfig{name=MongoDB}
Caused by: com.spotify.docker.client.exceptions.ContainerNotFoundException: 
Container not found: MongoDB
Caused by: com.spotify.docker.client.exceptions.DockerRequestException: 
Request error: GET unix://localhost:80/containers/MongoDB/json: 404, body: 
{"message":"No such container: MongoDB"}


[jira] [Commented] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread Konrad Windszus (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688071#comment-16688071
 ] 

Konrad Windszus commented on JCR-4120:
--

I added the javadoc modification to make it clearer to understand what the 
patch tries to fix. Feel free to leave them out, but I think they add more 
clarity (and javadoc fixes should not lead to regressions and all of them are 
in the context of this issues).

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


[ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688002#comment-16688002
 ] 

angela commented on JCR-4120:
-

[~kwin], for future contributions: please don't add unrelated changes to a 
patch. just looked at the patch and saw unrelated changes to exceptions, 
trivial javadoc modifications (but then not making this consistently). I will 
only review the part that is related to this issue and will not commit 
unrelated modifications.

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[ANNOUNCE] Apache Jackrabbit Oak 1.9.11 released

2018-11-15 Thread Davide Giannella
The Apache Jackrabbit community is pleased to announce the release of
Apache Jackrabbit Oak. The release is available for download at:

http://jackrabbit.apache.org/downloads.html

See the full release notes below for details about this release:

Release Notes -- Apache Jackrabbit Oak -- Version 1.9.11

Introduction


Jackrabbit Oak is a scalable, high-performance hierarchical content
repository designed for use as the foundation of modern world-class
web sites and other demanding content applications.

Apache Jackrabbit Oak 1.9.11 is an unstable release cut directly from
Jackrabbit Oak trunk, with a focus on new features and other
improvements. For production use we recommend the latest stable 1.8.x
release.

The Oak effort is a part of the Apache Jackrabbit project.
Apache Jackrabbit is a project of the Apache Software Foundation.

Changes in Oak 1.9.11


Bug

[OAK-7605] - Giving multiple result when executing query (for a
constraints with OR condition) for Facetextraction
[OAK-7608] - Throw exception if all properties name are given
wrong for faceting
[OAK-7613] - Taking more time for iterating row of query Result
which contain Facets
[OAK-7877] - Avoid unnecessary operations when logging read
operations
[OAK-7885] - Performance regression in FlatTreeUpdateTest
[OAK-7886] - Re-registering node type may corrupt registry

Improvement

[OAK-7850] - Indexes that don't support facets being queried
should not participate in execution plan
[OAK-7873] - Delete o.a.j.o.segment.util.RoleUtils
[OAK-7874] - Upgrade docker-junit-rule to version 2.2.2

Task

[OAK-7892] - LogCustomizer should support slf4j log levels

In addition to the above-mentioned changes, this release contains
all changes included up to the Apache Jackrabbit Oak 1.7.x release.

For more detailed information about all the changes in this and other
Oak releases, please see the Oak issue tracker at

  https://issues.apache.org/jira/browse/OAK

Release Contents


This release consists of a single source archive packaged as a zip file.
The archive can be unpacked with the jar tool from your JDK installation.
See the README.md file for instructions on how to build this release.

The source archive is accompanied by SHA1 and SHA512 checksums and a
PGP signature that you can use to verify the authenticity of your
download. The public key used for the PGP signature can be found at
https://www.apache.org/dist/jackrabbit/KEYS.

About Apache Jackrabbit Oak
---

Jackrabbit Oak is a scalable, high-performance hierarchical content
repository designed for use as the foundation of modern world-class
web sites and other demanding content applications.

The Oak effort is a part of the Apache Jackrabbit project. 
Apache Jackrabbit is a project of the Apache Software Foundation.

For more information, visit http://jackrabbit.apache.org/oak

About The Apache Software Foundation


Established in 1999, The Apache Software Foundation provides organizational,
legal, and financial support for more than 140 freely-available,
collaboratively-developed Open Source projects. The pragmatic Apache License
enables individual and commercial users to easily deploy Apache software;
the Foundation's intellectual property framework limits the legal exposure
of its 3,800+ contributors.

For more information, visit http://www.apache.org/




[ANNOUNCE] Apache Jackrabbit Oak 1.9.11 released

2018-11-15 Thread Davide Giannella
The Apache Jackrabbit community is pleased to announce the release of
Apache Jackrabbit Oak. The release is available for download at:

http://jackrabbit.apache.org/downloads.html

See the full release notes below for details about this release:

Release Notes -- Apache Jackrabbit Oak -- Version 1.9.11

Introduction


Jackrabbit Oak is a scalable, high-performance hierarchical content
repository designed for use as the foundation of modern world-class
web sites and other demanding content applications.

Apache Jackrabbit Oak 1.9.11 is an unstable release cut directly from
Jackrabbit Oak trunk, with a focus on new features and other
improvements. For production use we recommend the latest stable 1.8.x
release.

The Oak effort is a part of the Apache Jackrabbit project.
Apache Jackrabbit is a project of the Apache Software Foundation.

Changes in Oak 1.9.11


Bug

[OAK-7605] - Giving multiple result when executing query (for a
constraints with OR condition) for Facetextraction
[OAK-7608] - Throw exception if all properties name are given
wrong for faceting
[OAK-7613] - Taking more time for iterating row of query Result
which contain Facets
[OAK-7877] - Avoid unnecessary operations when logging read
operations
[OAK-7885] - Performance regression in FlatTreeUpdateTest
[OAK-7886] - Re-registering node type may corrupt registry

Improvement

[OAK-7850] - Indexes that don't support facets being queried
should not participate in execution plan
[OAK-7873] - Delete o.a.j.o.segment.util.RoleUtils
[OAK-7874] - Upgrade docker-junit-rule to version 2.2.2

Task

[OAK-7892] - LogCustomizer should support slf4j log levels

In addition to the above-mentioned changes, this release contains
all changes included up to the Apache Jackrabbit Oak 1.7.x release.

For more detailed information about all the changes in this and other
Oak releases, please see the Oak issue tracker at

  https://issues.apache.org/jira/browse/OAK

Release Contents


This release consists of a single source archive packaged as a zip file.
The archive can be unpacked with the jar tool from your JDK installation.
See the README.md file for instructions on how to build this release.

The source archive is accompanied by SHA1 and SHA512 checksums and a
PGP signature that you can use to verify the authenticity of your
download. The public key used for the PGP signature can be found at
https://www.apache.org/dist/jackrabbit/KEYS.

About Apache Jackrabbit Oak
---

Jackrabbit Oak is a scalable, high-performance hierarchical content
repository designed for use as the foundation of modern world-class
web sites and other demanding content applications.

The Oak effort is a part of the Apache Jackrabbit project. 
Apache Jackrabbit is a project of the Apache Software Foundation.

For more information, visit http://jackrabbit.apache.org/oak

About The Apache Software Foundation


Established in 1999, The Apache Software Foundation provides organizational,
legal, and financial support for more than 140 freely-available,
collaboratively-developed Open Source projects. The pragmatic Apache License
enables individual and commercial users to easily deploy Apache software;
the Foundation's intellectual property framework limits the legal exposure
of its 3,800+ contributors.

For more information, visit http://www.apache.org/




[jira] [Assigned] (JCR-4120) Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to "default"

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/JCR-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela reassigned JCR-4120:
---

Assignee: angela

> Spi2DavexRepositoryServiceImpl always hardcodes the default workspace name to 
> "default"
> ---
>
> Key: JCR-4120
> URL: https://issues.apache.org/jira/browse/JCR-4120
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-spi2dav
>Reporter: Konrad Windszus
>Assignee: angela
>Priority: Major
> Fix For: 2.18
>
>
> Basically the patch from JCR-2113 breaks the default workspace handling when 
> the {{org.apache.jackrabbit.spi2davex.Spi2davexRepositoryServiceFactory}} is 
> being used, because it always assumes that the default workspace name is 
> {{default}}. This is unfortunately not always true. The only reason why the 
> default workspace name need to be passed at all seems to be backwards 
> compatibility (prior to version 1.5 this was mandatory, see JCR-1842). 
> Unfortunately the assumed default workspace name being {{default}} may lead 
> to issues, as this is then used to with each call to 
> {{org.apache.jackrabbit.spi2dav.RepositoryServiceImpl.obtain(...)}} where it 
> falls back to the default workspace name when no explicit workspace name is 
> given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)